Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync eng/common directory with azure-sdk-tools for PR 2322 #16242

Merged
merged 36 commits into from
Nov 23, 2021

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#2322 See eng/common workflow

sima-zhu and others added 30 commits November 22, 2021 23:03
@azure-sdk azure-sdk requested review from benbp and a team as code owners November 22, 2021 23:18
@azure-sdk azure-sdk requested review from sima-zhu and removed request for a team November 22, 2021 23:18
@azure-sdk azure-sdk added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Nov 22, 2021
@azure-sdk azure-sdk merged commit 04f6aa2 into main Nov 23, 2021
@azure-sdk azure-sdk deleted the sync-eng/common-codeowner_script-2322 branch November 23, 2021 00:29
jhendrixMSFT pushed a commit to jhendrixMSFT/azure-sdk-for-go that referenced this pull request Jan 12, 2022
* Install and Run code owner tools in get-codeowner.ps1

* return command when exists

* Update eng/common/scripts/get-codeowners.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/scripts/get-codeowners.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Address comments

* Added test to script

* change return type

* change wrong params

* default to toolpath

* typo

* correct exit on Test

* change to right function name

* Fixed log message

* log message

* Added more test cases

* Correct the parameters

* Update eng/common/scripts/get-codeowners.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/scripts/get-codeowners.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Update eng/common/scripts/get-codeowners.ps1

Co-authored-by: Wes Haggard <[email protected]>

* Remove exit 0 in test function

* change the path delimiter

* More changes on var

* Hide error behind

* Comment back all tests

* exit 0

* Update eng/common/scripts/get-codeowners.ps1

Co-authored-by: Wes Haggard <[email protected]>

* remove default value

* changes for new get-codeowners

* Update eng/common/scripts/get-codeowners.ps1

Co-authored-by: Wes Haggard <[email protected]>

* update version and parameter

* add user

* more fix

* add messages

* Added real cases

* fixed typo

* Make program work

Co-authored-by: sima-zhu <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants