-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync eng/common directory with azure-sdk-tools for PR 2322 #16242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
azure-sdk
added
Central-EngSys
This issue is owned by the Engineering System team.
EngSys
This issue is impacting the engineering system.
labels
Nov 22, 2021
sima-zhu
approved these changes
Nov 22, 2021
jhendrixMSFT
pushed a commit
to jhendrixMSFT/azure-sdk-for-go
that referenced
this pull request
Jan 12, 2022
* Install and Run code owner tools in get-codeowner.ps1 * return command when exists * Update eng/common/scripts/get-codeowners.ps1 Co-authored-by: Wes Haggard <[email protected]> * Update eng/common/scripts/get-codeowners.ps1 Co-authored-by: Wes Haggard <[email protected]> * Address comments * Added test to script * change return type * change wrong params * default to toolpath * typo * correct exit on Test * change to right function name * Fixed log message * log message * Added more test cases * Correct the parameters * Update eng/common/scripts/get-codeowners.ps1 Co-authored-by: Wes Haggard <[email protected]> * Update eng/common/scripts/get-codeowners.ps1 Co-authored-by: Wes Haggard <[email protected]> * Update eng/common/scripts/get-codeowners.ps1 Co-authored-by: Wes Haggard <[email protected]> * Remove exit 0 in test function * change the path delimiter * More changes on var * Hide error behind * Comment back all tests * exit 0 * Update eng/common/scripts/get-codeowners.ps1 Co-authored-by: Wes Haggard <[email protected]> * remove default value * changes for new get-codeowners * Update eng/common/scripts/get-codeowners.ps1 Co-authored-by: Wes Haggard <[email protected]> * update version and parameter * add user * more fix * add messages * Added real cases * fixed typo * Make program work Co-authored-by: sima-zhu <[email protected]> Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Central-EngSys
This issue is owned by the Engineering System team.
EngSys
This issue is impacting the engineering system.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#2322 See eng/common workflow