Simplify injecting custom pipeline policies #14480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed NewConnectionWithPipeline() in favor of policy slices in ConnectionOptions. The slices are to control where the policies are injected in the pipeline, either before or after the retry policy. Update version number for pending release.
jhendrixMSFT
commented
Mar 31, 2021
| policies = append(policies, azcore.NewRetryPolicy(&options.Retry), | ||
| policies = append(policies, options.PerCallPolicies...) | ||
| policies = append(policies, azcore.NewRetryPolicy(&options.Retry)) | ||
| policies = append(policies, options.PerRetryPolicies...) |
There was a problem hiding this comment.
I placed this before the authentication policy to prevent tampering with the credential. Any objections?
JeffreyRichter
approved these changes
Mar 31, 2021
|
@ArcturusZhang FYI |
mohsha-msft
added a commit
that referenced
this pull request
Apr 21, 2021
* Replace Connection's Do() with Pipeline() (#13409) LROs and pagers require access to the Connection's pipeline. * Sync eng/common directory with azure-sdk-tools for PR 1163 (#13338) * Update subscription configuration schema to include new parameters * Support platform specific arm template parameters and legacy hashtable format * Update arm template parameter comment to include top level key * Restore AdditionalParameters. Merge ArmTemplateParameters from stringified hash literal * Handle duplicate keys more explicitly for arm and env vars * Regenerate New-TestResources.ps1 markdown * revert variable name to environmentVariables to fix post-scripts * Handle empty arm template parameters better * Remove arm template parameter merge logic from deploy template * Add merge hashes function to New-TestResources.ps1 * Add merge hashes function to New-TestResources.ps1 * Add env variable overwrite warning. Use ContainsKey checks * Temporarily manually fix invalid generated markdown links Co-authored-by: Ben Broderick Phillips <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1178 (#13412) * Refactor eng/common/README.md * Add doc directory Co-authored-by: Chidozie Ononiwu <[email protected]> * Fix broken eng/common doc link (#13492) Co-authored-by: Chidozie Ononiwu <[email protected]> * Fix deadlock in bearer token refresh (#13494) * Fix deadlock in bearer token refresh If GetToken() fails the renewing flag wasn't reset, leading to a deadlock. Ensure the flag is reset before exiting. * refine and add test * Sync eng/common directory with azure-sdk-tools for PR 1188 (#13507) * Add debug flag to arm deployment command * Only set debug preference when $CI is true Co-authored-by: Ben Broderick Phillips <[email protected]> * Remove invalid characters in basename sourced from username (#13508) Co-authored-by: Ben Broderick Phillips <[email protected]> * Add generator tool to run in the sdk automation pipeline (#13477) * Add generator tool to run in the sdk automation pipeline * Fix compromised tests * Trying to satisfy linter * Add generate options * Sync eng/common directory with azure-sdk-tools for PR 1170 (#13337) * Added the preprocess scripts. * string array to string Co-authored-by: Sima Zhu <[email protected]> * Config files update for SDK automation pipeline (#13476) * Config files update for SDK automation pipeline * Update swagger_to_sdk_config.json * update scripts Co-authored-by: Phoenix He <[email protected]> * Refactor various public surface area (#13495) * Refactor various public surface area Made several option fields non-pointers as there is no semantic difference between nil and their zero-value. Added missing default options constructors. Added doc comment to options structs explaining to use their corresponding constructor funcs. Unexported a few things that didn't need to be exported. Renamed URI to URL in public surface area only. * fixed some misspelled words * fix test after rebasing * fix handling of AZURE_AUTHORITY_HOST don't override explicitly set AuthorityHost with env var * reduce retry delay to make tests run faster * Add Invoke-DevOpsAPI.ps1, Add functions for Canceling and Listing Builds (#13238) Co-authored-by: Chidozie Ononiwu <[email protected]> * Change live test resource DeleteAfterHours tag to 8 hours (#13564) Co-authored-by: Ben Broderick Phillips <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1202 (#13566) * Add debugging link on resource deployment failures to log output * Update aka link for live test help docs. Use here string and empty throw. Co-authored-by: Ben Broderick Phillips <[email protected]> * Minor release v48.2.0 (#13602) * Generated from tag package-2020-11 of containerservice (commit hash: 48e7415267518cc2b92f6e6002466f676bdef1a5) * Generated from tag package-2020-10-01-preview of redisenterprise (commit hash: 48e7415267518cc2b92f6e6002466f676bdef1a5) * Generated from tag package-2019-10 of policyinsights (commit hash: 48e7415267518cc2b92f6e6002466f676bdef1a5) * Generated from tag package-2020-10-01 of attestation (commit hash: 48e7415267518cc2b92f6e6002466f676bdef1a5) * v48.2.0 * Don't implement stateless polices as first-class funcs (#13509) They are needlessly allocated on the heap. * Add support for clouds other than public (#13496) * Add support for clouds other than public Renamed DefaultEndpoint to AzurePublicCloud. Added const for the sovereign clouds. Construct token scope based on the cloud. Updated NewRPRegistrationPolicy() to take an endpoint param. * rename func per feedback * Sync eng/common directory with azure-sdk-tools for PR 1153 (#13606) * Improve Update-ChangeLog Logic * Updates to ChangeLog-Operations.ps1, copy-docs-to-blobstorage.ps1, Invoke-GitHubAPI.ps1 and Package-Properties.ps1 * More changeLog Logic Improvements * Update date parsing Co-authored-by: Chidozie Ononiwu <[email protected]> * Remove RedirectURL parameter from auth code flow (#13565) To align with the MSAL implementation which relies on the native client redirect URL. * Sync eng/common directory with azure-sdk-tools for PR 1210 (#13607) * Cache created service principal for iteration Useful when testing changes over and over again without passing your own -TestApplicationId and -TestApplicationSecret. * Restore initial AzContext for New-TestResources * Make sure PSBoundParameters is correct Fixes #1177 Co-authored-by: Heath Stewart <[email protected]> * adding ci.yml for track2 arm modules (#13652) * fix path to eng directory (#13653) * fix path to eng directory * fix service directory * Sync eng/common directory with azure-sdk-tools for PR 1203 (#13659) * Refactoring artifact-metadata-parsing.ps1, update-docs-metadata.ps1, and create-tags-and-git-release.ps1 * Clean up common imports * Refactor Update-docs-ci.ps1 Co-authored-by: Chidozie Ononiwu <[email protected]> * Swtich back to smoke-test before doc publishing error gets fixed. (#13702) Co-authored-by: Sima Zhu <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1219 (#13710) * Move entire docgeneration into common tools * Move docindex to common * Added the package replacement logic * Fixed on parameters * Fixed param * Change function to dash * Added regex on function * Added display name. * Update eng/common/docgeneration/Generate-DocIndex.ps1 Co-authored-by: Wes Haggard <[email protected]> * Deal with js * Add no new line args * revert some test changes * Need to default to the double quotes for JS regex * Update Generate-DocIndex.ps1 * Added the appTitle * type Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Wes Haggard <[email protected]> * Adding Seek() method and updating payload() (#13703) * Adding Seek() method and updating payload() * updates based on comments * add tests * Bug fix: adding body back to response (#13701) * adding body back to response * Adding azcore dependant seek for body * updating azcore version * undo azcore version.go change * assign Seek error to poller * Include telemetry string in User-Agent (#13731) * Add telemetry string to User-Agent (#13732) * adding user agent string (#13734) * Fix generator (#13666) * We should never produce null packages, instead we should produce an empty array of packages when there is not any * Add a prefix for the logs of autorest * gofmt * Sync eng/common directory with azure-sdk-tools for PR 1226 (#13735) * Fixed the docindex.yml and rename the files * Reset the mutated changes * Force checkout as the changes have already copied out * Minor changes for parameters * Update Generate-DocIndex.ps1 * Update Generate-DocIndex.ps1 * Update Generate-DocIndex.ps1 * Added function to common * Update Generate-DocIndex.ps1 Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Sima Zhu <[email protected]> * Fixed the bug of the wrong parameter (#13750) Co-authored-by: Sima Zhu <[email protected]> * Exclude bypass-local-dns step when a container variable is specified (#13733) Co-authored-by: Ben Broderick Phillips <[email protected]> * Adds armresources module with examples (#13224) * Adds armresources module with examples * update README * make examples self-contained * update README * Adding more resource group samples * Update vars in resource group update sample * Adding missing armresources samples * fix code err check * update codegen with latest generator added CHANGELOG.md * improving samples * update example names * Remove status code print from poller samples * rebuild with latest code generator * regenerate with latest code generator * update README * update README * update dependencies * remove -u from install instructions * add build tags * regenerate code and update changelog * rebuild with latest code generator * regenerate with latest code generator Co-authored-by: Catalina Peralta <[email protected]> * Add ARM Keyvault module and samples (#13410) * Add ARM Keyvault module and samples * go fmt * Add module docs * update generated code * improving comments, readme and ci.yml * regenerate with preview.6 and update changelog * updating readme * moving readme * adding build tags * regenerate code and update changelog * regenerate with latest generator and update changelog * regenerating code * Adding ARM storage module and samples (#13493) * Adding generated code and docs * updated changelog * Adding blob containers samples * Adding storage accounts and usage samples, with go.mod update * update test parameters and result prints * go mod tidy * updating generated code * updating generated code, changelog, readme * updating readme and moving up to service directory * adding build tags * regenerate code and update changelog * regenerate code with new generator and update changelog * regenerate code * Adding ARM network module and samples (#13563) * Adding network code and initial docs * Adding examples * code fixes * Add comment to subnet examples * updating example messages * update generated code and changelog * update readme * go mod tidy * moving and updating readme * adding build tags * regenerate code and update changelog * regenerate code with new generator and update changelog * rebuild with latest code generator Co-authored-by: Joel Hendrix <[email protected]> * Adding ARM compute module and samples (#13605) * Adding armcompute module and docs * Adding samples and regenerated code * Adding more examples * update changelog and telemetry string * Move+update readme, remove ci.yml * update readme * adding build tags * improve readme * regenerating code and updating changelog * update example names * regenerate code with new generator and update changelog * removing dependence on internal module * regenerate code * Major version release v49.0.0 (#13808) * Bump autorest.go version * Generated from azure-rest-api-specs 4cc5be9c6a34e0fe2525caf7eb7615cf197b9d8b * v49.0.0 * Rename some packages * Add a note in changelog * Refresh profiles * Removed unused baseURI param in NewAuthorizerFromFile() * Remove the problematic new package * fix changelog * Removed bad package adp * Pick up the new iothub package that would be used by profiles Co-authored-by: Joel Hendrix <[email protected]> * Add profile 2020-09-01 (#12596) * add 2020-09-01 profile definitions * Update definition to exclude iothub since it does not exist yet * refresh new profiles * readd iothub and regenerate * quick fix (#13829) * Sync eng/common directory with azure-sdk-tools for PR 1233 (#13857) * reformatted parameter arguments to both update-docs scripts. added parameter requirements and renamed CIRepository to DocRepoLocation which is a lot clearer. Added additional CIConfig parameter to update-docs-metadata to support specific write locations per moniker. Co-authored-by: scbedd <[email protected]> * Refactor apidiff (#13795) * Simplify parameters of report.Generate * refactor package command * export some functions and types * remove some redundant interfaces * rename a function to reflect the true purpose of the function * extract some package report related struct to the report package * refactor markdown writer to its own package * some fix and more refactor * more refactor * some changes to satisfy the linter * Refactor generator to use the metadata generated by autorest instead of analyzing output folders via `git diff` (#13830) * introduced metadata processor to replace the previous get packages function * refactor * some comment to satisfy the linter * adding more comment to satisfy the linter * refine and fix linter * add some comment to satisfy linter * gofmt * rename function to satisfy linter * Sync eng/common directory with azure-sdk-tools for PR 1257 (#13911) * Make up the css using for .net sdk github io pages * Remove index.html * Make changes to js Co-authored-by: Sima Zhu <[email protected]> * Update MSI App Service 2017 api-version (#13912) * update MSI app service query param and expiresOn parsing * add comment and remove padding characters * Clean up modules direcotry in eng/common since they are no longer being used. (#13838) Co-authored-by: Chidozie Ononiwu <[email protected]> * Create PR to target against master (#13947) Co-authored-by: Sima Zhu <[email protected]> * Add redirectURI param back to auth code flow (#13942) * Add logging options to ConnectionOptions (#13955) * Add logging options to all option types (#13956) * Add logging options to all option types * add missing default initializers * Sync eng/common directory with azure-sdk-tools for PR 1270 (#13958) * resolve git longpath error when applying documentation updates Co-authored-by: scbedd <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1274 (#13957) * Added a step of skipping package json update for spring boot packages * Added skip package json config * Update the indentation Co-authored-by: Sima Zhu <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1273 (#13959) * Support alpha and azure pipeline build version formats for SemVer parsing and sorting * Minor build number fixes * Support zero-padding of build versions more generically in SemVer script * Fix pre-release label conditional for HasValidPrereleaseLabel in semver script * Set default convention for build number separator in semver script Co-authored-by: Ben Broderick Phillips <[email protected]> * Add ability to log request/response bodies (#13948) * Add ability to log request/response bodies Added IncludeBody to LogOptions to enable logging of HTTP request and response bodies. The default is false and cannot be enabled by way of environment variable. * consolidate duplicated code * azidentity: Adding SubjectName/Issuer support (#13995) * Adding SNI support * adding test to check for properly incorporated certificate chain in the JWT * azidentity: Adding doc.go (#13996) * Adding doc.go * move credential list up * address feedback * Fixed the bug of replacing img src with href text (#14011) Co-authored-by: Sima Zhu <[email protected]> * Release v49.1.0 (#14015) * bump autorest.go version * Fix issue https://github.com/Azure/azure-sdk-for-go/issues/13882 * Generated from tags [package-2020-09] of specification/cdn/resource-manager/readme.md (commit hash: 3a3a9452f965a227ce43e6b545035b99dd175f23) * Generated from tags [package-2020-07] of specification/network/resource-manager/readme.md (commit hash: 3a3a9452f965a227ce43e6b545035b99dd175f23) * Generated from tags [package-composite-v3] of specification/security/resource-manager/readme.md (commit hash: 3a3a9452f965a227ce43e6b545035b99dd175f23) * Generated from tags [package-2019-06-01-preview] of specification/synapse/resource-manager/readme.md (commit hash: 3a3a9452f965a227ce43e6b545035b99dd175f23) * Generated from tags [package-2020-05-01-preview] of specification/cpim/resource-manager/readme.md (commit hash: 3a3a9452f965a227ce43e6b545035b99dd175f23) * Generated from tags [package-2018-06] of specification/datafactory/resource-manager/readme.md (commit hash: 3a3a9452f965a227ce43e6b545035b99dd175f23) * Generated from tags [package-2020-06] of specification/redis/resource-manager/readme.md (commit hash: 3a3a9452f965a227ce43e6b545035b99dd175f23) * Generated from tags [package-2016-06] of specification/recoveryservices/resource-manager/readme.md (commit hash: 3a3a9452f965a227ce43e6b545035b99dd175f23) * v49.1.0 * Fix links in CHANGELOG * Add latest profile for track 2 (#14012) * Add latest profile for track 2 * add CI file * Sync eng/common directory with azure-sdk-tools for PR 1287 (#14030) * Move common code to create API review into eng common in tools * Exclude tests when parsing packages (#14031) * Exclude tests when parsing packages * include list of packages in error info * change LoadPackageErrorInfo to report packages * add support for interfaces that embed other interfaces improve error message when failing to add a constant * Release v49.2.0 (#14062) * Generated from specification/netapp/resource-manager/readme.md tag package-netapp-2020-09-01 (commit hash: b08824e05817297a4b2874d8db5e6fc8c29349c9) * Generated from specification/hdinsight/resource-manager/readme.md tag package-2018-06-preview (commit hash: b08824e05817297a4b2874d8db5e6fc8c29349c9) * Generated from specification/redisenterprise/resource-manager/readme.md tag package-2020-10-01-preview (commit hash: b08824e05817297a4b2874d8db5e6fc8c29349c9) * Generated from specification/guestconfiguration/resource-manager/readme.md tag package-2020-06-25 (commit hash: b08824e05817297a4b2874d8db5e6fc8c29349c9) * Generated from specification/containerservice/resource-manager/readme.md tag package-2020-12 (commit hash: b08824e05817297a4b2874d8db5e6fc8c29349c9) * Generated from specification/appplatform/resource-manager/readme.md tag package-preview-2020-11 (commit hash: b08824e05817297a4b2874d8db5e6fc8c29349c9) * Generated from specification/resources/resource-manager/readme.md tag package-templatespecs-2019-06-preview (commit hash: b08824e05817297a4b2874d8db5e6fc8c29349c9) * v49.2.0 * Adding port option for interactive browser (#14052) * Adding port option for interactive browser * add test for setting the port * Add port field comment, use azcore.JoinPaths for url * remove function to check authority host format * APIDIFF: Fixing bugs in content generation (#14053) * improving const content generation * revert error message format * Generator: generate the changelog from a backup instead of playing with git (#13910) * generate the changelog from a backup instead of playing with git * goimports * update the format of changelog * fix one minor issue * add a summary line * Fix typo in README.md (#14086) * Update to Update-Changelog.ps1 (#14075) Co-authored-by: Chidozie Ononiwu <[email protected]> * Add Devops Release Item scripts (#14089) - Add set of helpers to work with devops work items - Add script to create devops release package items - Update SemVer to support version type Co-authored-by: Wes Haggard <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1298 (#14088) * Update latest folder with one index.html includes the redirect links * Update the redirect links and remove everything in latest * Address feedback * Have the entire copy for latest GA. Co-authored-by: Sima Zhu <[email protected]> * remove the tilde symbol to fix the autorest.go version (#14104) * Sync eng/common directory with azure-sdk-tools for PR 1302 (#14094) * Make the user agent configurable. * Address comments * Default to current Chrome version * Revert the yaml file changes Co-authored-by: Sima Zhu <[email protected]> * Remove old Update-Change-Log.ps1 (#14093) Co-authored-by: Chidozie Ononiwu <[email protected]> * Update generator to include the validations of output-folder (#14074) * update generator to include the validations of output-folder * refine error messages * fix linter * stable cannot be in preview subdirectory * Ensure CLI CredentialUnavailableError has a message (#14112) If there was no output written to stderr, fall back to the message from the error. * allow configuration of a suffix for each config item. (#14113) Co-authored-by: scbedd <[email protected]> * Revert "Remove old Update-Change-Log.ps1 (#1301)" (#14115) This reverts commit b967cb62bd8db451a2f02d903f3658cf21f92db1. Co-authored-by: Chidozie Ononiwu <[email protected]> * Fix condition for test generation in prepare-pipelines (#14122) Co-authored-by: Wes Haggard <[email protected]> * Adding track2 API diff tools (#14092) * copying existing apidiff tool * fix references, add internal package * adding track2 format to the tool * add missing license headers * Add quotes around the parameter (#14123) Co-authored-by: Wes Haggard <[email protected]> * Release v50.0.0 (#14108) * append information of readme and tag in all changelogs * remove a package whose swaggers have been removed by the service team * bump autorest.go version * Regenerate all packages using autorest.go @microsoft.azure/[email protected] * Refresh profiles * Generated from specification/resources/resource-manager/readme.md tag package-resources-2020-10 (commit hash: 4c93f28f89435f6d244f4db61bbf810b5d20f09f) * Generated from specification/monitor/resource-manager/readme.md tag package-2019-11 (commit hash: 4c93f28f89435f6d244f4db61bbf810b5d20f09f) * Generated from specification/alertsmanagement/resource-manager/readme.md tag package-2019-06-preview (commit hash: 4c93f28f89435f6d244f4db61bbf810b5d20f09f) * Generated from specification/healthbot/resource-manager/readme.md tag package-2020-12-08 (commit hash: 4c93f28f89435f6d244f4db61bbf810b5d20f09f) * Generated from specification/iotcentral/resource-manager/readme.md tag package-2018-09-01 (commit hash: 4c93f28f89435f6d244f4db61bbf810b5d20f09f) * v50.0.0 * Modify changelog, update dependencies * rename profiles/2020-09-01/compute to profiles/2020-09-01/compute/mgmt/compute * fix broken link * remove the major-updater tool because it is not used and does not work now (#14137) * Update pipeline generation tool to support test variant pipelines (#14142) Co-authored-by: Wes Haggard <[email protected]> * removing apidiff tool from sdk directory (#14140) * Accept zero-value options for default values (#14124) * Accept zero-value options for default values Specify zero-value options structs to accept default values. Remove DefaultXxxOptions() methods. Fixed up docs for RetryOptions. * Do no silently change TryTimeout on negative values * make per-try timeout opt-in * fix type-o add missing test coverage * Switching the environment variable check for ManagedIdentityCredential (#14139) * switching the environment variable check order for MSI * remove comment * The output-folder for a profile now no longer reports errors (#14161) * the output-folder for a profile now no longer reports errors * refine the error message to give more clear guidance of fixing * Generator detect removed packages (#14138) * introduce a new command list to list all packages * refactor io of pipeline * now we first clean up all related packages before generating any new packages * add some comments * Add a todo note * refine the logic of clean up * add changelog related processor * refinement on structure * now we can identify those packages that should be removed * clean up some dead code * swap clone and sdk in generation of changelog * fix linter * final refactor * fix linter * Armcore defaults (#14162) * Accept zero-value options for default values Specify zero-value options structs to accept default values. Remove DefaultXxxOptions() methods. Fixed up options documentation. * Remove RegisterRPOptions from ConnectionOptions Replaced with DisableRPRegistration which is the most common reason to modify the policy. Flow ConnectionOptions to the RegisterRPPolicy config. Make a copy of options before modifying. * clean-up * omit the registration policy when disabled * fix changelog generation error (#14167) * Release v50.1.0 (#14168) * Generated from specification/confluent/resource-manager/readme.md tag package-2020-03-01 (commit hash: d4bad535d456ee82c7fd17d1ec2b8802a0b83205) * Generated from specification/network/resource-manager/readme.md tag package-2020-08 (commit hash: d4bad535d456ee82c7fd17d1ec2b8802a0b83205) * Generated from specification/cosmos-db/resource-manager/readme.md tag package-2020-06-preview (commit hash: d4bad535d456ee82c7fd17d1ec2b8802a0b83205) * Generated from specification/authorization/resource-manager/readme.md tag package-2020-04-01-preview (commit hash: d4bad535d456ee82c7fd17d1ec2b8802a0b83205) * v50.1.0 * add dns to profiles/2020-09-01 (#14134) * fix clean up packages (#14173) * [SDK automation] Add namespace validation (#14169) * introduce a new command list to list all packages * refactor io of pipeline * now we first clean up all related packages before generating any new packages * add some comments * Add a todo note * refine the logic of clean up * add changelog related processor * refinement on structure * now we can identify those packages that should be removed * clean up some dead code * swap clone and sdk in generation of changelog * fix linter * final refactor * bump autorest.go version and enable namespace validation * Fix CI * azidentity: Remove DefaultXxxOptions() funcs (#14147) * remove default options funcs * updating bearer token policy tests * code fixes * revert skipping test * init copy of options structs * fix msi test * remove TryTimeout from default pipeline * set negative try timeout for deadlock test * Add support for PKCE in interactive auth flow (#14171) * Add support for PKCE in interactive auth flow Implement as specified in RFC7636 to prevent auth code interception attacks. Enabled by default, can be disabled. * refactor authEndpoint * Update error message in tools repo (#14177) Co-authored-by: Chidozie Ononiwu <[email protected]> * Enable 1ES hosted pools (#14148) * Enable 1ES hosted pools * Azidentity doc updates (#14176) * Fix credential comments * updating doc.go * fix comment * capitalize sentence * Fix analyze step to use Ubuntu (#14182) Limit analyze to the service directory (it was scanning all of track 2) * Updating apidiff tool to use track2 format (#14164) * updating apidiff tool to use track2 format * fix test * address feedback * Add comment to ToMarkdown() * improve code * Fix linting and add extra debug spew (#14183) * fix working dir for analyze steps (#14184) * fix working dir again and remove extra slash (#14186) * fix incorrect paths for analyze tasks (#14187) * update armcompute with latest codegen and swagger (#14181) * update armcompute with latest codegen and swagger * update changelog to new format * update armkeyvault with latest codegen and swagger (#14189) * update armnetwork with latest codegen and swagger (#14190) * update armresources with latest codegen and swagger (#14192) * update armstorage with latest codegen and swagger (#14193) * Sync eng/common directory with azure-sdk-tools for PR 1317 (#14191) * retarget the tool clone to a release tag Co-authored-by: scbedd <[email protected]> * Sync eng/common directory with azure-sdk-tools repository (#14188) * Ensure bypass conditional template gets run for 1es ubuntu image (#14194) Co-authored-by: Ben Broderick Phillips <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1251 (#14197) * Add PrepareRelease Script * Generalize Prepare-Release Script * Update Update-ChangeLog.ps1 * Update Package-Properties.ps1 * Update Collect-ChangeLog Script * Update Collect-ChangeLog.ps1 and Collect-Unreleased.ps1 * Update GeneralReleaseNotesParser.ps1 script * Update Prepare-Release Script to use recent DevOps Scripts * Move Get-LanguageName to eng\common\scripts\Helpers\DevOps-WorkItem-Helpers.ps1, improve error message, add logic to detect changes made by prepare-release script * Use LanguageDisplayName, move Get-CSVMetadata to Package-Properties.ps1 Co-authored-by: Chidozie Ononiwu <[email protected]> * Retry on a nil response (#14210) * Retry on a nil response On rare occasion there is a nil response and error. Ensure that the transport returns a nil response in this case. Moved custom TryTimeout value to the one test that relies on it and fixed its validation logic. * relocate new test to clarify diff * Release v50.2.0 (#14208) * Generated from specification/hdinsight/resource-manager/readme.md tag package-2018-06-preview (commit hash: 12b41f4c0ff9814429a6dcfc4a72d5f9d52d1f62) * Generated from specification/reservations/resource-manager/readme.md tag package-2020-10-25 (commit hash: 12b41f4c0ff9814429a6dcfc4a72d5f9d52d1f62) * v50.2.0 * update the error handling in generator (#14180) * Sync eng/common directory with azure-sdk-tools for PR 1335 (#14212) * Lossen up $RELEASE_TITLE_REGEX to accomodate wrongly formated changelogs * Update changelog logic to use ordered hashtable * Update semver and Changelog logic Co-authored-by: Chidozie Ononiwu <[email protected]> * Update APIDIFF changelog command (#14217) * update changelog command to include track2 headers * revert changes to diff command * Fixed the problem of no display name issue (#14227) Co-authored-by: Sima Zhu <[email protected]> * updating module dependencies in test (#14229) * Sync eng/common directory with azure-sdk-tools for PR 1341 (#14230) * Run the link verification step even previous step failed. * Make the tab right * Address comments * Run default condition if no RunOnFailure set. * Changed back to simple condition Co-authored-by: Sima Zhu <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1345 (#14239) * Enforce API approval status for GA and include SDK type in package properties * Fix per review comment * Fixes as per review comments to avoid changing constructor signature * Fixes as per review comments to handle track 1 packages * Fix yaml format error Co-authored-by: praveenkuttappan <[email protected]> * Release v51.0.0 (#14249) * Generated from specification/operationalinsights/resource-manager/readme.md tag package-2020-03-preview (commit hash: 138759b8a5987252fd66658078907e1d93969c85) * Generated from specification/quantum/resource-manager/readme.md tag package-2019-11-04-preview (commit hash: 138759b8a5987252fd66658078907e1d93969c85) * Generated from specification/synapse/resource-manager/readme.md tag package-2020-12-01 (commit hash: 138759b8a5987252fd66658078907e1d93969c85) * Generated from specification/securityinsights/resource-manager/readme.md tag package-2019-01-preview-only (commit hash: 138759b8a5987252fd66658078907e1d93969c85) * Generated from specification/purview/resource-manager/readme.md tag package-2020-12-01-preview (commit hash: 138759b8a5987252fd66658078907e1d93969c85) * Generated from specification/cdn/resource-manager/readme.md tag package-2020-09 (commit hash: 138759b8a5987252fd66658078907e1d93969c85) * v51.0.0 * fix profiles Co-authored-by: Arcturus Zhang <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1351 (#14253) * tweaks to New-TestResources readme * Ensure interactive auth flow can be cancelled (#14216) * Ensure interactive auth flow can be cancelled Replaced WaitGroup with channel. Flow context to WaitForCallback() and select on both channels. Disabling PKCE should not be allowed. The functionality was disabled and the config option can be removed in the next breaking change. * Remove DisablePKCE option * Fix DateTime bug (#14256) Co-authored-by: Chidozie Ononiwu <[email protected]> * Fix a concurrency issue in profileBuilder (#14252) * limit the maximum concurrency to 8 by default, add a flag to manually set this * update description * mistook specRoot as commit hash previously, fix it (#14219) * Sync eng/common directory with azure-sdk-tools for PR 1353 (#14257) * Use a helper function to normalize the package name for readme * Get the readme name from artifact-metadata-parsing * Change to the readme * Update eng/common/scripts/artifact-metadata-parsing.ps1 Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Wes Haggard <[email protected]> * turn the concurrency off by default (#14258) * Sync eng/common directory with azure-sdk-tools for PR 1364 (#14265) * Support sub directory for artifact location * Fix as per review comment to avoid artifact sub path * Package property file is not created for track1 and management pacakges. * Fix property name case * Fix as per review comments * Fix as per review comments * Use Config File param value as is * Change to make path joineasily readable Co-authored-by: praveenkuttappan <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1365 (#14266) * Updated cosmos emulator yml script to remove the existing installation, install latest version and run emulator with latest version * Added default emulator start arguments if none provided * Updated default start params * Updated default start params in PS script * Updated default start params in PS script Co-authored-by: Kushagra Thapar <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1366 (#14267) * Scan all duplicate artifacts which set hide to true * Update eng/common/docgeneration/Generate-DocIndex.ps1 Co-authored-by: Wes Haggard <[email protected]> * Update Generate-DocIndex.ps1 Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Wes Haggard <[email protected]> * Release v51.1.0 (#14273) * Generated from specification/operationalinsights/resource-manager/readme.md tag package-2020-03-preview (commit hash: 0b17e6a5e811fd7b122d383b4942441d95e5e8cf) * Generated from specification/mixedreality/resource-manager/readme.md tag package-2021-01 (commit hash: 0b17e6a5e811fd7b122d383b4942441d95e5e8cf) * Generated from specification/storage/resource-manager/readme.md tag package-2020-08-preview (commit hash: 0b17e6a5e811fd7b122d383b4942441d95e5e8cf) * Generated from specification/storagecache/resource-manager/readme.md tag package-2020-10-01 (commit hash: 0b17e6a5e811fd7b122d383b4942441d95e5e8cf) * Generated from specification/compute/resource-manager/readme.md tag package-2020-10-01-preview (commit hash: 0b17e6a5e811fd7b122d383b4942441d95e5e8cf) * v51.1.0 * Use Clone() method to clone default transport (#14262) Introduced in Go 1.13. * Add a method to return new cosmos client (#14276) * Add Pager and Poller interfaces to azcore (#14277) * Update devops helper script based on changes in azure-sdk repo (#14286) - Sync devops helper script changes - Fix issue in SemVer script when using strict mode with Language not set Co-authored-by: Wes Haggard <[email protected]> * Add helper for time.Time (#14293) * Sync eng/common directory with azure-sdk-tools for PR 1393 (#14294) * Hide the package which set to true instead of putting to Other page * Hide the package not showing in csv * Added logging message * fix the variable * leave an extra space * Update eng/common/docgeneration/Generate-DocIndex.ps1 Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Wes Haggard <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1303 (#14296) * Add PrepareRelease Script * Update Package-Properties.ps1 * Update Collect-ChangeLog Script * Update Collect-ChangeLog.ps1 and Collect-Unreleased.ps1 * Update GeneralReleaseNotesParser.ps1 script * Change GeneralReleaseNotesParser logic * Change GeneralReleaseNotesParser.ps1 logic * Remoce GeneralReleaseNotesParsercopy * Update collect changelog and generalreleasenotes parser logic * Refine CollectChangelog Logic * Add logic for filtering collected changelog * Add Filter-ReleaseHighlights function * Update General ReleasNotes Logic * Delete GeneralReleaseNotesLogic.ps1 * Update Collect ChangeLogLogic Co-authored-by: Chidozie Ononiwu <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1358 (#14297) * Extend Get-GitHubPullRequest to return only files * Add check to prevent eng/common changes that are not proper syncs * Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml Co-authored-by: Wes Haggard <[email protected]> * Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Wes Haggard <[email protected]> * Enable passing devops pat for work item scripts (#14298) Co-authored-by: Wes Haggard <[email protected]> * Change script parameters to boolean (#14299) Co-authored-by: Chidozie Ononiwu <[email protected]> * Release v51.2.0 (#14302) * update autorest.go version to 2.1.171 * Generated from azure-rest-api-specs b08824e05817297a4b2874d8db5e6fc8c29349c9 * Generated from specification/cosmos-db/resource-manager/readme.md tag package-2020-09 (commit hash: a1eee0489c374782a934ec1f093abd16fa7718ca) * Generated from specification/resourcemover/resource-manager/readme.md tag package-2021-01-01 (commit hash: a1eee0489c374782a934ec1f093abd16fa7718ca) * Generated from specification/redisenterprise/resource-manager/readme.md tag package-2021-03 (commit hash: a1eee0489c374782a934ec1f093abd16fa7718ca) * Generated from specification/synapse/data-plane/readme.md tag package-access-control-2020-08-01-preview (commit hash: a1eee0489c374782a934ec1f093abd16fa7718ca) * Generated from specification/sql/resource-manager/readme.md tag package-composite-v4 (commit hash: a1eee0489c374782a934ec1f093abd16fa7718ca) * Generated from specification/compute/resource-manager/readme.md tag package-2020-12-01 (commit hash: a1eee0489c374782a934ec1f093abd16fa7718ca) * Generated from specification/datafactory/resource-manager/readme.md tag package-2018-06 (commit hash: a1eee0489c374782a934ec1f093abd16fa7718ca) * Generated from specification/iotcentral/resource-manager/readme.md tag package-2018-09-01 (commit hash: a1eee0489c374782a934ec1f093abd16fa7718ca) * v51.2.0 * Update 2020-09 documentdb to correct preview path * Move cosmos-db preview directory to include day * Regenerate cosmos-db profiles * Fix import path fore cosmos-db interfaces Co-authored-by: arcturusZhang <[email protected]> * Update eng-common-workflow-enforcer (#14301) Co-authored-by: Chidozie Ononiwu <[email protected]> * Allow logging into specific subscription (#14303) Resolves #1404 Co-authored-by: Heath Stewart <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1408 (#14304) * Improve TestResources docs and logging Resolves #1388 Resolves #1407 Also ignores cached service principal if it no longer exists. I ran into this while testing since I cleaned up old SPs. * Add ADP test sub to look-up Co-authored-by: Heath Stewart <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1371 (#14288) * Rework verify agent OS step. * Address feedback * Justing string matching instead. * ! instead of -not Co-authored-by: Mitch Denny <[email protected]> * Re-enable agent OS verification (#14285) * Re-enable agent OS verification * Sync eng/common directory with azure-sdk-tools for PR 1374 (#14307) * Create package property file using artifact name * Add option to pass config file dir * Set default config file directory to avoid script execution failure Co-authored-by: praveenkuttappan <[email protected]> * fix generation metadata (#14315) * Sync eng/common directory with azure-sdk-tools for PR 1396 (#14324) * Change other version to all versions * Exclude the packages which already show up in latest GA and preview * Update main.js Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Sima Zhu <[email protected]> * Release v51.3.0 (#14327) * Generated from specification/monitor/resource-manager/readme.md tag package-2020-10 (commit hash: 8240593bde5350e6762015523ccd57cb61e32da5) * Generated from specification/web/resource-manager/readme.md tag package-2020-09 (commit hash: 8240593bde5350e6762015523ccd57cb61e32da5) * Generated from specification/cosmos-db/resource-manager/readme.md tag package-2021-01 (commit hash: 8240593bde5350e6762015523ccd57cb61e32da5) * Generated from specification/storagecache/resource-manager/readme.md tag package-2020-10-01 (commit hash: 8240593bde5350e6762015523ccd57cb61e32da5) * Generated from specification/mixedreality/resource-manager/readme.md tag package-2021-03-01-preview (commit hash: 8240593bde5350e6762015523ccd57cb61e32da5) * Generated from specification/eventgrid/resource-manager/readme.md tag package-2020-10-preview (commit hash: 8240593bde5350e6762015523ccd57cb61e32da5) * v51.3.0 * Only run eng/common check when target branch is master (#14313) Co-authored-by: Chidozie Ononiwu <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1425 (#14325) * Trim off the target branch * Update eng/common/scripts/get-markdown-files-from-changed-files.ps1 Co-authored-by: Wes Haggard <[email protected]> * Update get-markdown-files-from-changed-files.ps1 * Update get-markdown-files-from-changed-files.ps1 * Trim the slash Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Wes Haggard <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1429 (#14330) * Add job matrix generation scripts * Add working job matrix example pipeline and common matrix generation pipeline. * Update job matrix tests path * Parameterize matrix generation job path * Add global variable to override nuget security checks to sample matrix pipeline * Update readme matrix pipeline example to match sample file Co-authored-by: Ben Broderick Phillips <[email protected]> * Update pipeline generator version to include weekly convention name fix (#14332) Co-authored-by: Ben Broderick Phillips <[email protected]> * Restore pipeline output variable for Agent OS name (#14331) Co-authored-by: Ben Broderick Phillips <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1421 (#14339) * Add common tools for spell check * Updates from further iteration * Review feedback: Add check for git as well * Review feedback * Use common approach to resolving base branch name * Eliminate default base branch "master" as this will be changed later, providing no default and using a mandatory parameter means a dev must provide the value * Check for existence of $CspellConfigPath * No need to Set-Location if run from the root of the repo (most common scenario) * -join * Review feedback: Rename TargetRef -> TargetBranch, add SourceBranch, Add reference to spelling docs, exit 0, Rename to check-spelling-in-changed-files.ps1, * Review feedback: Remove ValidateNotNullOrEmpty (we do more definitive validation farther down that will also catch these errors), Update comments and script name Co-authored-by: Daniel Jurek <[email protected]> * Release v52.0.0 (#14355) * switch uuid package to gofrs/uuid * bump autorest.go version * Generated from azure-rest-api-specs 4c93f28f89435f6d244f4db61bbf810b5d20f09f * Refresh profiles * Generated from specification/kubernetesconfiguration/resource-manager/readme.md tag package-2021-03 (commit hash: 92ab22b49bd085116af0c61fada2c6c360702e9e) * Generated from specification/mixedreality/resource-manager/readme.md tag package-2021-03-01-preview (commit hash: 92ab22b49bd085116af0c61fada2c6c360702e9e) * Generated from specification/netapp/resource-manager/readme.md tag package-netapp-2020-11-01 (commit hash: 92ab22b49bd085116af0c61fada2c6c360702e9e) * Generated from specification/storage/resource-manager/readme.md tag package-2021-01 (commit hash: 92ab22b49bd085116af0c61fada2c6c360702e9e) * Generated from specification/appplatform/resource-manager/readme.md tag package-preview-2020-11 (commit hash: 92ab22b49bd085116af0c61fada2c6c360702e9e) * Generated from specification/containerinstance/resource-manager/readme.md tag package-2020-11 (commit hash: 92ab22b49bd085116af0c61fada2c6c360702e9e) * Generated from specification/managementgroups/resource-manager/readme.md tag package-2020-05 (commit hash: 92ab22b49bd085116af0c61fada2c6c360702e9e) * Generated from specification/managementgroups/resource-manager/readme.md tag package-2020-02 (commit hash: 92ab22b49bd085116af0c61fada2c6c360702e9e) * Generated from specification/mediaservices/resource-manager/readme.md tag package-2020-05 (commit hash: 92ab22b49bd085116af0c61fada2c6c360702e9e) * v52.0.0 * fix profiles * Update Prepare-Release script (#14365) - Remove BuildType parameter as we can default it from package properties - Stop passing BuildType and GroupId and instead defaul them from package properties - Enable StrictMode to help identify potential errors - Start passing sdktype and isnewsdk properties to devops script - Sync latest changes with devops work item to fix a couple bugs Co-authored-by: Wes Haggard <[email protected]> * Release v52.1.0 (#14368) * Generated from specification/cosmos-db/resource-manager/readme.md tag package-2021-03-preview (commit hash: fbdca24500e7218ef975ca2947651d6d84933ef9) * v52.1.0 * Release v52.2.0 (#14373) * Generated from specification/deviceupdate/resource-manager/readme.md tag package-2020-03-01-preview (commit hash: af4929aa7f919ce1fe7ac0a1b1a340baa1331611) * v52.2.0 * Fix LanguageShort typo (#14384) Co-authored-by: Chidozie Ononiwu <[email protected]> * Release v52.3.0 (#14385) * Generated from specification/containerservice/resource-manager/readme.md tag package-2021-02 (commit hash: 80e4e1b77162711ca1123042f50db03ffbf1bb40) * Generated from specification/hybridkubernetes/resource-manager/readme.md tag package-2021-03-01 (commit hash: 80e4e1b77162711ca1123042f50db03ffbf1bb40) * Generated from specification/postgresql/resource-manager/readme.md tag package-2020-02-14-preview (commit hash: 80e4e1b77162711ca1123042f50db03ffbf1bb40) * v52.3.0 * add eng/common workflow enforcer (#14375) * Move SetTestPipelineVersion.ps1 to eng/common (#14389) Co-authored-by: Chidozie Ononiwu <[email protected]> * Fix PackageName typo (#14391) Co-authored-by: Chidozie Ononiwu <[email protected]> * Enable APIView status check (#14390) Co-authored-by: praveenkuttappan <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1448 (#14386) * Added more logging to API view create * Updated logs with arch board rescue email address * Fix as per review comments * Update logging to show API URL Co-authored-by: praveenkuttappan <[email protected]> * Fix bug where imported matrix parameter duplicates are not overrided (#14394) Co-authored-by: Ben Broderick Phillips <[email protected]> * Fix logic in SetTestPipelineVersionInEngCommon (#14397) Co-authored-by: Chidozie Ononiwu <[email protected]> * Storage fixes (#14395) Omit x-ms-blob-type request header for AppendBlock() operation. Fixed XML error unmarshalling for some table APIs. * move SetTestPipeline into its own template (#14398) Co-authored-by: Chidozie Ononiwu <[email protected]> * update the changelog's header format in generator (#14260) * Sync eng/common directory with azure-sdk-tools for PR 1452 (#14403) * Use sparse checkout for generate matrix job * Add repository parameter Co-authored-by: Ben Broderick Phillips <[email protected]> * Use latest pipeline generator. (#14406) Co-authored-by: Mitch Denny <[email protected]> * Sort changelogs by date then version (#14413) Fixes #1389 Co-authored-by: Heath Stewart <[email protected]> * Release v52.4.0 (#14414) * Generated from specification/kubernetesconfiguration/resource-manager/readme.md tag package-2020-07-01-preview (commit hash: d9506558e6389e62926ae385f1d625a1376a0f9d) * Generated from specification/network/resource-manager/readme.md tag package-2020-11 (commit hash: d9506558e6389e62926ae385f1d625a1376a0f9d) * Generated from specification/storagecache/resource-manager/readme.md tag package-2021-03 (commit hash: d9506558e6389e62926ae385f1d625a1376a0f9d) * Generated from specification/datadog/resource-manager/readme.md tag package-2020-02-preview (commit hash: d9506558e6389e62926ae385f1d625a1376a0f9d) * Generated from specification/digitaltwins/resource-manager/readme.md tag package-2020-12 (commit hash: d9506558e6389e62926ae385f1d625a1376a0f9d) * v52.4.0 * adding adfs support (#14013) * Fix bug in Changelog URL path using packageDirectoryName (#14419) Co-authored-by: Chidozie Ononiwu <[email protected]> * Address PR feedback (#14410) Co-authored-by: Sima Zhu <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1490 (#14428) * Create a publish-artifact.yml template step within eng/common. This template utilizes PublishPipelineArtifactV1 to upload your artifact only in the case where steps up till the invocation are succeeded(). Otherwise, the artifacts will be uploaded to an alternate artifact name. * Sync eng/common directory with azure-sdk-tools for PR 1418 (#14370) * Update Package Properties Logic, make prepare release require only 1 argument, make rerun of Get-PkgProperties in Update-Changelog not required * Remove ServiceDirectory parameter from PrepareRelease.ps1 * changes to argument names * pass service directory to Get-AllPackageInfoFromRepo * Remove changes in Update-ChangeLog.ps1 * updates to Package-Properties.ps1 Co-authored-by: Chidozie Ononiwu <[email protected]> * Revert to Checking only ci.yml (#14430) Pull only artifacts from `ci.yml` to resolve issue with conflicting package names. Co-authored-by: Chidozie Ononiwu <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1463 (#14431) * Add 'replace' support. Improve handling of dynamic parameter types. * Support display name import and overrides * Support regex capture groups for replace. Force fully matching regex. Co-authored-by: Ben Broderick Phillips <[email protected]> * Add support for encoding JSON null values (#14429) * Add support for encoding JSON null values This adds NullValue() and IsNullValue() functions for setting and detecting sentinel values used for encoding a JSON null. Cleaned up some improper error wrapping and removed out-dated comments. * fix docs * Release v52.5.0 (#14434) * Generated from specification/apimanagement/resource-manager/readme.md tag package-2020-12 (commit hash: 0ea0b8af7e197ecc85696f770057ee47d6d9d3ba) * Generated from specification/communication/resource-manager/readme.md tag package-2020-08-20 (commit hash: 0ea0b8af7e197ecc85696f770057ee47d6d9d3ba) * Generated from specification/datadog/resource-manager/readme.md tag package-2021-03 (commit hash: 0ea0b8af7e197ecc85696f770057ee47d6d9d3ba) * Generated from specification/netapp/resource-manager/readme.md tag package-netapp-2020-12-01 (commit hash: 0ea0b8af7e197ecc85696f770057ee47d6d9d3ba) * v52.5.0 * update version * Sync eng/common directory with azure-sdk-tools for PR 1498 (#14432) * Fix null check against matrix parameter array * add negative test cases Co-authored-by: Ben Broderick Phillips <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1489 (#14436) * Add draft to Submit-PullRequest.ps1 * Add -Draft to create-pull-request.yml * Add documentation * Rename: Draft[Pr] -> OpenAsDraft * Update docs Co-authored-by: Daniel Jurek <[email protected]> * Ensure version is sorted as semVer (#14439) Co-authored-by: Chidozie Ononiwu <[email protected]> * Add helpers for arrays (#14437) * Add helpers for arrays * refactor names * Add ReleaseTrackingOnly option to Prepare-Release (#14446) Co-authored-by: Wes Haggard <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1514 (#14448) * Handle null values when generating display names * Fix issue processing matrices where the base matrix is only an import Co-authored-by: Ben Broderick Phillips <[email protected]> * Release v52.6.0 (#14453) * Generated from specification/authorization/resource-manager/readme.md tag package-2020-04-01-preview (commit hash: 0f0e41fa4e3679510fcf03ecd60084f1cdbd5805) * Generated from specification/changeanalysis/resource-manager/readme.md tag package-2021-04-01 (commit hash: 0f0e41fa4e3679510fcf03ecd60084f1cdbd5805) * Generated from specification/compute/resource-manager/readme.md tag package-2021-03-01 (commit hash: 0f0e41fa4e3679510fcf03ecd60084f1cdbd5805) * Generated from specification/databoxedge/resource-manager/readme.md tag package-2020-12-01 (commit hash: 0f0e41fa4e3679510fcf03ecd60084f1cdbd5805) * Generated from specification/deviceupdate/resource-manager/readme.md tag package-2020-03-01-preview (commit hash: 0f0e41fa4e3679510fcf03ecd60084f1cdbd5805) * Generated from specification/dnc/resource-manager/readme.md tag package-2021-03-15 (commit hash: 0f0e41fa4e3679510fcf03ecd60084f1cdbd5805) * Generated from specification/extendedlocation/resource-manager/readme.md tag package-2021-03-15-preview (commit hash: 0f0e41fa4e3679510fcf03ecd60084f1cdbd5805) * v52.6.0 * Sync eng/common directory with azure-sdk-tools for PR 1517 (#14455) * Add chagelogpath to Update-ChangeLog.ps1 * Make PackageName and ServiceDirectory not mandatory, test ChangelogPath Co-authored-by: Chidozie Ononiwu <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1478 (#14456) * actually pass the _content_ of the reviewers or teamreviewers variable within create-pull-request.yml, update logic in Set-GitHubParameter * Sync eng/common directory with azure-sdk-tools for PR 1508 (#14445) * Skip API create step when running from feature branch with non GA version * Use default branch variable instead of hardcoding master branch name * Updated as per review comments * Use only branch name instead of path to check * Fix issue in response code check Co-authored-by: praveenkuttappan <[email protected]> * Support default branch for the workflow. Part 1 (#14457) Co-authored-by: Sima Zhu <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1521 (#14460) * Fix issue where 2d index arrays with length 1 get flattened by powershell * Pass NonSparseParameters to imported matrix generation Co-authored-by: Ben Broderick Phillips <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1477 (#14458) * Checked in the changes directly. * Address feedback and remove the check of set-default-branch * Fixed base repo branch * Update git-branch-push.ps1 * Fixed the docs-metadata-release * Change the typo * Update eng/common/scripts/git-branch-push.ps1 Co-authored-by: Wes Haggard <[email protected]> * Keep origin format * Update git-branch-push.ps1 * Keep fixing the typo Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Sima Zhu <[email protected]> Co-authored-by: Wes Haggard <[email protected]> * Add support for multi-part form data (#14461) * Add support for multi-part form data Added method WriteMultipartFormData() to Request. * rename * Add DependsOn parameter to matrix job generation template (#14475) Co-authored-by: Ben Broderick Phillips <[email protected]> * Sync eng/common directory with azure-sdk-tools repository (#14479) * Simplify injecting custom pipeline policies (#14480) Removed NewConnectionWithPipeline() in favor of policy slices in ConnectionOptions. The slices are to control where the policies are injected in the pipeline, either before or after the retry policy. Update version number for pending release. * Migrate license to MIT (#14477) * bump autorest.go version and update the lisence * Generated from specification/apimanagement/resource-manager/readme.md tag package-2020-12 (commit hash: 8d3b22458da4bb9309c0207c2ebc1903de741249) * Generated from specification/communication/resource-manager/readme.md tag package-2020-08-20 (commit hash: 8d3b22458da4bb9309c0207c2ebc1903de741249) * Generated from specification/datadog/resource-manager/readme.md tag package-2021-03 (commit hash: 8d3b22458da4bb9309c0207c2ebc1903de741249) * Generated from specification/netapp/resource-manager/readme.md tag package-netapp-2020-12-01 (commit hash: 8d3b22458da4bb9309c0207c2ebc1903de741249) * Generated from azure-rest-api-specs 3a3a9452f965a227ce43e6b545035b99dd175f23 * replace license in classic packages * change the template in profile builder * regenerate the profiles * regenerate 2020-09-01/compute profile * replace license in storage * replace license in tools * replace license.txt * Refactor `pkgchk` tool and expose some api (#14393) * refactor pkgchk tool and expose some api * minor refactor * fix a bug * rename functions to emphasize the track 1 packages * leave track 2 pkgchk for future implementation * simplify and goimports * fix linter * move the things of track 1 to track 1 package * add lisense headers * get rid of the errors package * add the validation to generator * fix merge issues * Release v53.0.0 (#14486) * Generated from specification/cosmos-db/resource-manager/readme.md tag package-2021-03 (commit hash: e0f8b9ab0f5fe5e71b7429ebfea8a33c19ec9d8d) * Generated from specification/cost-management/resource-manager/readme.md tag package-2020-06 (commit hash: e0f8b9ab0f5fe5e71b7429ebfea8a33c19ec9d8d) * Generated from specification/resourcegraph/resource-manager/readme.md tag package-2021-03 (commit hash: e0f8b9ab0f5fe5e71b7429ebfea8a33c19ec9d8d) * Generated from specification/synapse/resource-manager/readme.md tag package-2021-03 (commit hash: e0f8b9ab0f5fe5e71b7429ebfea8a33c19ec9d8d) * Generated from specification/web/resource-manager/readme.md tag package-2020-12 (commit hash: e0f8b9ab0f5fe5e71b7429ebfea8a33c19ec9d8d) * Generated from specification/compute/resource-manager/readme.md tag package-2020-12-01 (commit hash: e0f8b9ab0f5fe5e71b7429ebfea8a33c19ec9d8d) * Generated from specification/datafactory/resource-manager/readme.md tag package-2018-06 (commit hash: e0f8b9ab0f5fe5e71b7429ebfea8a33c19ec9d8d) * Generated from specification/guestconfiguration/resource-manager/readme.md tag package-2020-06-25 (commit hash: e0f8b9ab0f5fe5e71b7429ebfea8a33c19ec9d8d) * v53.0.0 * fix changelog * Sync eng/common directory with azure-sdk-tools for PR 1525 (#14481) * Use SubscriptionId throughout TestResources Fixes #1454 * Resolve PR feedback * Default DeleteAfterHours to 48 for SDK team Also makes a few other adjustments for subscriptions, like restoring the previous one if available and another was specified. * Resolve PR feedback * Change deployment mode to Complete Also fixes an issue where if the user opted not to deploy to the same resource group, the script would continue execution anyway. * Use consistent aka links to satisfy link checker Only need it for the new Update-TestResources.ps1 script, but I wanted them to look consistent. Co-authored-by: Heath Stewart <[email protected]> * Use single quotes for matrix generator command line arguments (#14487) Co-authored-by: Ben Broderick Phillips <[email protected]> * add some missing headers, and change some headers to MIT (those are missed in last major release) (#14500) * Release v53.1.0 (#14505) * Generated from specification/containerservice/resource-manager/readme.md tag package-2021-03 (commit hash: 5d89c9807d3e84a5890b381a68a308198f9ef141) * Generated from specification/hybridnetwork/resource-manager/readme.md tag package-2020-01-01-preview (commit hash: 5d89c9807d3e84a5890b381a68a308198f9ef141) * v53.1.0 * Fix BaseName initialization (#14510) Initializing the BaseName with a ServiceDirectory that contains a "/", because it is a multiple level path, causes the BaseName initialization code to fail because it doesn't support the validation pattern. In all the known cases we already pass the ResourceGroupName explicitly so don't need to set the BaseName so we can skip the initialization in those cases. Co-authored-by: Wes Haggard <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1548 (#14512) * Remove passing -Mode Complete to deployment When passing Complete it will remove any resources already in the resource group that weren't part of the current deployment. That removal breaks a lot of assumptions, like multiple deployments when testing things like smoke-tests or if you are reusing an existing resource group. We don't want that to happen. * Remove ServiceDirectory as required parameter for remove/update When this was made mandatory it broke some usages which didn't pass the value. Those usages don't need to pass it because the pass required information in other ways so removing the requirement for the parameter to be passed. Co-authored-by: Wes Haggard <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1515 (#14507) * Add lease to runs. * Add YAML file. * Remove commented out code. * Move days valid into template with a default. Co-authored-by: Mitch Denny <[email protected]> * Migrate license to MIT (#14494) * Migrate license to MIT (#14495) * Removed the update CI target packages step. (#14514) Co-authored-by: Sima Zhu <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1551 (#14515) * make -checkout: none an optional phase Co-authored-by: scbedd <[email protected]> * Update eng/common dev version template. (#14516) Co-authored-by: Mitch Denny <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 1553 (#14517) * Remove condition. * Fix up system access token usage. Co-authored-by: Mitch Denny <[email protected]> * Metadata file format update (#14497) * metadata data structur…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed NewConnectionWithPipeline() in favor of policy slices in
ConnectionOptions. The slices are to control where the policies are
injected in the pipeline, either before or after the retry policy.
Update version number for pending release.