Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in OpenAI Sample #21629

Closed
bobtabor-msft opened this issue Sep 27, 2023 · 1 comment · Fixed by #21634
Closed

Bug in OpenAI Sample #21629

bobtabor-msft opened this issue Sep 27, 2023 · 1 comment · Fixed by #21634
Assignees
@richardpark-msft
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Docs OpenAI

Comments

@bobtabor-msft
Copy link
Contributor

bobtabor-msft commented Sep 27, 2023 •
edited by sandeep-sen
Loading

Bug Report

  • Import package: github.com/Azure/azure-sdk-for-go/sdk/ai/azopenai
  • SDK version: main, latest, 0.3.0
  • Go version: 1.18
  • Docs example issue

https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/ai/azopenai#example-Client.GetChatCompletions-BringYourOwnDataWithCognitiveSearch

... this line of code:

Deployment: "gpt-4",

... should not be hard coded. Instead, it should be:

Deployment: modelDeploymentID,

... because if I choose a different model (like gpt-35-turbo ... which is one of a set of limited options from the Azure OpenAI Studio currently) when creating a deployment, the code sample will throw 400 error.
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Sep 27, 2023
@sandeep-sen sandeep-sen added bug This issue requires a change to an existing behavior in the product in order to be resolved. Docs OpenAI and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 27, 2023
@sandeep-sen
Copy link
Member

modelDeploymentID defined at azure-sdk-for-go/ai/azopenai/example_client_getchatcompletions_extensions_test.go#L22

Deployment assigned at azure-sdk-for-go/ai/azopenai/example_client_getchatcompletions_extensions_test.go#L77

@richardpark-msft richardpark-msft mentioned this issue Sep 28, 2023
Merged
richardpark-msft added a commit that referenced this issue Sep 28, 2023
@richardpark-msft
[azopenai] Fixing unused variable in example. (#21634)
2952409 
Fixes #21629
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richardpark-msft richardpark-msft

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Docs OpenAI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[azopenai] Fixing unused variable in example. richardpark-msft/azure-sdk-for-go
3 participants
@sandeep-sen @bobtabor-msft @richardpark-msft