Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azopenai] Turn on --rawjson-as-bytes when generating the client #21009

Closed
richardpark-msft opened this issue Jun 13, 2023 · 0 comments · Fixed by #23167
Closed

[azopenai] Turn on --rawjson-as-bytes when generating the client #21009

richardpark-msft opened this issue Jun 13, 2023 · 0 comments · Fixed by #23167
Assignees
@richardpark-msft
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. OpenAI

Comments

@richardpark-msft
Copy link
Member

(from here: #20617 (comment))

This particular field though has a proper type now, @mikekistler must have fixed that awhile ago.

There aren't that many fields that are any so I'll need to check what they are supposed to be.

I noticed that one of the any fields is a field that can either be a string or a []string: link. We'll have to figure out the right way to represent this before we turn on --rawjson-as-bytes (which then turns it into a []byte).
@richardpark-msft richardpark-msft added Client This issue points to a problem in the data-plane of the library. OpenAI labels Jun 13, 2023
@richardpark-msft richardpark-msft self-assigned this Jun 13, 2023
@richardpark-msft richardpark-msft mentioned this issue Jun 13, 2023
Merged
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 13, 2023
@jhendrixMSFT jhendrixMSFT removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 15, 2023
@RickWinter RickWinter added the feature-request This issue requires a new behavior in the product in order be resolved. label Jul 25, 2023
@richardpark-msft richardpark-msft changed the title [azopenai] Turn on --raw-json-as-bytes when generating the client [azopenai] Turn on --rawjson-as-bytes when generating the client Jul 8, 2024
richardpark-msft pushed a commit to richardpark-msft/azure-sdk-for-go that referenced this issue Jul 8, 2024
Updating to use the rawjson-as-bytes config option. It doesn't change…
32bea44 
… anything in our client, as it is today, because we've properly typed all 'any' fields.

Fixes Azure#21009
@richardpark-msft richardpark-msft mentioned this issue Jul 8, 2024
Merged
richardpark-msft added a commit that referenced this issue Jul 8, 2024
@richardpark-msft
[azopenai] Updating to use the rawjson-as-bytes config option. No cod…
689ec06 
…e changes. (#23167)

Updating to use the rawjson-as-bytes config option. It doesn't change anything in our client, as it is today, because we've properly typed all 'any' fields.

Also, made Charles a CODEOWNER for this folder.

Fixes #21009
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richardpark-msft richardpark-msft

Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. OpenAI
Projects
None yet
Milestone
No milestone
3 participants
@RickWinter @jhendrixMSFT @richardpark-msft