Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gofmt/govet/golint for ./arm/... #196

Closed
ahmetb opened this issue Aug 29, 2015 · 3 comments
Closed

Enable gofmt/govet/golint for ./arm/... #196

ahmetb opened this issue Aug 29, 2015 · 3 comments
Assignees
@brendandixon

Comments

@ahmetb
Copy link
Contributor

ahmetb commented Aug 29, 2015

@brendandixon please feel free to edit .travis.yml accordingly when you feel comfortable enabling those checks for the arm package.
@brendandixon
Copy link
Contributor

@ahmetalpbalkan It's on the to-do list.

@brendandixon brendandixon mentioned this issue Oct 2, 2015
Merged
@ahmetb
Copy link
Contributor Author

ahmetb commented Mar 7, 2016

apparently done. :)

@brendandixon GitHub protip: If you add your commit message something like "Fixes #xxx" or "Closes #xxx", when commit is merged, issue(s) will close automatically once the commit is merged. https://help.github.com/articles/closing-issues-via-commit-messages/

@ahmetb ahmetb closed this as completed Mar 7, 2016
@brendandixon
Copy link
Contributor

@ahmetalpbalkan Sweet. I did not know that.

richardpark-msft pushed a commit to richardpark-msft/azure-sdk-for-go that referenced this issue Aug 5, 2021
@ProfessorMc @alpadotsh @jhendrixMSFT
Fix for Websocket behind Proxy Issue (Azure#196)
ff0e3f0 
* Fix lastError race

* Move websocket pkg out of std lib to deal with proxy.

* Add WebsocketEOF to connection closed error check.

* add comment

* added ctx to flow to ns.newClient

Co-authored-by: Alexander Pashkov <[email protected]>
Co-authored-by: Chris <[email protected]>
Co-authored-by: Joel Hendrix <[email protected]>
benbp pushed a commit to benbp/azure-sdk-for-go that referenced this issue Sep 15, 2021
@ProfessorMc @alpadotsh
@jhendrixMSFT @benbp
Fix for Websocket behind Proxy Issue (Azure#196)
8d5ce8e 
* Fix lastError race

* Move websocket pkg out of std lib to deal with proxy.

* Add WebsocketEOF to connection closed error check.

* add comment

* added ctx to flow to ns.newClient

Co-authored-by: Alexander Pashkov <[email protected]>
Co-authored-by: Chris <[email protected]>
Co-authored-by: Joel Hendrix <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brendandixon brendandixon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahmetb @brendandixon