Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Insights WebTestDefinition Missing Request and ValidationRules Structs #18435

Closed
nerddtvg opened this issue Jun 17, 2022 · 2 comments
Closed
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. Previous Versions Work related to track1 and track1.5 SDKs question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@nerddtvg
Copy link

Starting in REST API version 2018-05-01-preview, there was the addition of a Standard kind which required Request and ValidationRules structs and an optional Configuration field. This was also included in the 2020-10-05-preview version. Unfortunately the REST documentation itself is missing this information, but it is available in the ARM/Bicep docs. Can this be added into the Go SDK to match?

https://docs.microsoft.com/en-us/azure/templates/microsoft.insights/2018-05-01-preview/webtests?tabs=bicep

https://docs.microsoft.com/en-us/azure/templates/microsoft.insights/2020-10-05-preview/webtests?tabs=bicep

type WebTestProperties struct {
// SyntheticMonitorID - Unique ID of this WebTest. This is typically the same value as the Name field.
SyntheticMonitorID *string `json:"SyntheticMonitorId,omitempty"`
// WebTestName - User defined name if this WebTest.
WebTestName *string `json:"Name,omitempty"`
// Description - Purpose/user defined descriptive test for this WebTest.
Description *string `json:"Description,omitempty"`
// Enabled - Is the test actively being monitored.
Enabled *bool `json:"Enabled,omitempty"`
// Frequency - Interval in seconds between test runs for this WebTest. Default value is 300.
Frequency *int32 `json:"Frequency,omitempty"`
// Timeout - Seconds until this WebTest will timeout and fail. Default value is 30.
Timeout *int32 `json:"Timeout,omitempty"`
// WebTestKind - The kind of web test this is, valid choices are ping and multistep. Possible values include: 'WebTestKindPing', 'WebTestKindMultistep'
WebTestKind WebTestKind `json:"Kind,omitempty"`
// RetryEnabled - Allow for retries should this WebTest fail.
RetryEnabled *bool `json:"RetryEnabled,omitempty"`
// Locations - A list of where to physically run the tests from to give global coverage for accessibility of your application.
Locations *[]WebTestGeolocation `json:"Locations,omitempty"`
// Configuration - An XML configuration specification for a WebTest.
Configuration *WebTestPropertiesConfiguration `json:"Configuration,omitempty"`
// ProvisioningState - READ-ONLY; Current state of this component, whether or not is has been provisioned within the resource group it is defined. Users cannot change this value but are able to read from it. Values will include Succeeded, Deploying, Canceled, and Failed.
ProvisioningState *string `json:"provisioningState,omitempty"`
}

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 17, 2022
@lirenhe lirenhe added the Previous Versions Work related to track1 and track1.5 SDKs label Jun 20, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 20, 2022
@lirenhe lirenhe added Mgmt This issue is related to a management-plane library. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jun 20, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 20, 2022
@tadelesh
Copy link
Member

@nerddtvg Thank you for the feedback. Please note, the package github.com/Azure/azure-sdk-for-go/services/preview/appinsights/mgmt/2022-02-01-preview/insights has been deprecated. A replacement package is available github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/applicationinsights/armapplicationinsights. See Migration Guide for guidance on upgrading. Could you please upgrade to the new version first and feel free to feedback if any further problem?

@tadelesh tadelesh added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Jun 20, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-go that referenced this issue Jun 21, 2022
[Hub Generated] Review request for Microsoft.Media to add version stable/2021-11-01 (Azure#18435)

* Copy 2021-06-01 Account service files to 2021-11-01 folder with version change. can be ignored for review.

* Update account service with the latest 2021-11-01 version with breaking change.

* Add missing examples

* fix tag name

* add type array to the privateEndpointConnections.
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Jun 27, 2022
@ghost
Copy link

ghost commented Jun 27, 2022

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@ghost ghost closed this as completed Jul 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. Previous Versions Work related to track1 and track1.5 SDKs question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

3 participants