Execute go mod tidy for perf tests when using live azcore (#21471)

* Execute go mod tidy for perf tests when using live azcore This ensures that any updated dependencies are propagated. * set default value and fix devops syntax * runtime expression * switch param to string * stricter check, fixed some logging * debugging * fix syntax * define task var, clean up lint * fix syntax * define default from a runtime expression * syntax * more syntax * switch back to bool, remove debug logging
Azure · Sep 1, 2023 · ee7c3a2 · ee7c3a2
1 parent cc212a8
commit ee7c3a2
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 5 deletions.
diff --git a/eng/pipelines/templates/jobs/archetype-go-release.yml b/eng/pipelines/templates/jobs/archetype-go-release.yml
@@ -9,7 +9,7 @@ stages:
       - template: /eng/pipelines/templates/variables/globals.yml
     displayName: 'Check Release: ${{ parameters.ServiceDirectory }}'
     dependsOn: ${{ parameters.DependsOn }}
-    condition: and(succeeded(), ne(variables['SetDevVersion'], 'true'), ne(variables['Skip.Release'], 'true'), ne(variables['Build.Repository.Name'], 'Azure/azure-sdk-for-go-pr'), ne(variables['Use.AzcoreFromMain'], 'true'))
+    condition: and(succeeded(), ne(variables['SetDevVersion'], 'true'), ne(variables['Skip.Release'], 'true'), ne(variables['Build.Repository.Name'], 'Azure/azure-sdk-for-go-pr'), ne(variables.UseAzcoreFromMain, 'true'))
     jobs:
       - job: CheckReleaseJob
         displayName: "Check whether need to release"

diff --git a/eng/pipelines/templates/steps/build-test.yml b/eng/pipelines/templates/steps/build-test.yml
@@ -21,7 +21,7 @@ parameters:
 steps:
   - task: Powershell@2
     displayName: Use azcore from main
-    condition: eq(variables['Use.AzcoreFromMain'], 'true')
+    condition: eq(variables.UseAzcoreFromMain, 'true')
     env:
       GO111MODULE: 'on'
     inputs:
@@ -86,7 +86,7 @@ steps:
     inputs:
       targetType: 'filePath'
       filePath: ./eng/scripts/Build_Perf.ps1
-      arguments: '${{ parameters.ServiceDirectory }}'
+      arguments: '${{ parameters.ServiceDirectory }} $$(UseAzcoreFromMain)'
       pwsh: true
 
   - ${{ if eq(parameters.TestProxy, true) }}:

diff --git a/eng/pipelines/templates/variables/globals.yml b/eng/pipelines/templates/variables/globals.yml
@@ -8,3 +8,6 @@ variables:
 
   # Disable CodeQL injections except for where we specifically enable it
   Codeql.SkipTaskAutoInjection: true
+
+  # Set the default value so that 'Build Performance Tests' step can resolve it
+  UseAzcoreFromMain: $[eq(variables['Use.AzcoreFromMain'], 'true')]
diff --git a/eng/scripts/Build_Perf.ps1 b/eng/scripts/Build_Perf.ps1
@@ -1,7 +1,8 @@
 #Requires -Version 7.0
 
 Param(
-    [string] $serviceDirectory
+    [string] $serviceDirectory,
+    [bool] $useAzcoreFromMain
 )
 
 Push-Location sdk/$serviceDirectory
@@ -10,7 +11,7 @@ Push-Location sdk/$serviceDirectory
 $perfDirectories = Get-ChildItem -Path . -Filter testdata -Recurse
 
 if ($perfDirectories.Length -eq 0) {
-    Write-Host "Did not find any performance tests in the directory $(pwd)"
+    Write-Host "##[command] Did not find any performance tests in the directory $(Get-Location)"
     exit 0
 }
 
@@ -23,6 +24,15 @@ foreach ($perfDir in $perfDirectories) {
         Push-Location perf
         Write-Host "##[command] Building and vetting performance tests in $perfDir/perf"
 
+        if ($useAzcoreFromMain) {
+            # using a live azcore might be dragging in updated dependencies
+            Write-Host "##[command] Executing 'go mod tidy' in $perfDir/perf"
+            go mod tidy
+            if ($LASTEXITCODE) {
+                $failed = $true
+            }
+        }
+
         Write-Host "##[command] Executing 'go build .' in $perfDir/perf"
         go build .
         if ($LASTEXITCODE) {