Get rid of gocheck, and add specific gas tests

.travis.yml

@@ -10,12 +10,13 @@ install:
   - go get -u golang.org/x/net/context
   - go get -u github.com/HewlettPackard/gas
   - go get -u gopkg.in/godo.v2/cmd/godo
-  - go get -u github.com/kisielk/errcheck
   - export GO15VENDOREXPERIMENT=1
   - glide install
 
 script:
   - gas -skip=*/arm/*/models.go -skip=*/management/examples/*.go -skip=*vendor* -skip=*/Gododir/* ./...
+  - gas -exclude=G101 ./arm/... ./management/examples/...
+  - gas -exclude=G204 ./Gododir/...
   - test -z "$(gofmt -s -l $(find ./arm/* -type d -print) | tee /dev/stderr)"
   - test -z "$(gofmt -s -l -w management | tee /dev/stderr)"
   - test -z "$(gofmt -s -l -w storage | tee /dev/stderr)"
@@ -31,4 +32,3 @@ script:
   - go vet ./management/...
   - test -z "$(golint ./Gododir/... | tee /dev/stderr)"
   - go vet ./Gododir/...
-  - set -e; for v in ./arm/... ./datalake-store/... ./Gododir/... ./management/... ./storage/...; do (errcheck -ignoretests "$v" | grep -v 'Close()' | tee /dev/stderr); done

storage/blob.go

@@ -1475,10 +1475,7 @@ func (b BlobStorageClient) GetBlobSASURIWithSignedIPAndProtocol(container, name
 		return "", err
 	}
 
-	sig, err := b.client.computeHmac256(stringToSign)
-	if err != nil {
-		return "", err
-	}
+	sig := b.client.computeHmac256(stringToSign)
 	sasParams := url.Values{
 		"sv":  {b.client.apiVersion},
 		"se":  {signedExpiry},

storage/client.go

@@ -234,12 +234,9 @@ func (c Client) GetFileService() FileServiceClient {
 	return FileServiceClient{c}
 }
 
-func (c Client) createAuthorizationHeader(canonicalizedString string) (string, error) {
-	signature, err := c.computeHmac256(canonicalizedString)
-	if err != nil {
-		return "", err
-	}
-	return fmt.Sprintf("%s %s:%s", "SharedKey", c.getCanonicalizedAccountName(), signature), nil
+func (c Client) createAuthorizationHeader(canonicalizedString string) string {
+	signature := c.computeHmac256(canonicalizedString)
+	return fmt.Sprintf("%s %s:%s", "SharedKey", c.getCanonicalizedAccountName(), signature)
 }
 
 func (c Client) getAuthorizationHeader(verb, url string, headers map[string]string) (string, error) {
@@ -249,7 +246,7 @@ func (c Client) getAuthorizationHeader(verb, url string, headers map[string]stri
 	}
 
 	canonicalizedString := c.buildCanonicalizedString(verb, headers, canonicalizedResource)
-	return c.createAuthorizationHeader(canonicalizedString)
+	return c.createAuthorizationHeader(canonicalizedString), nil
 }
 
 func (c Client) getStandardHeaders() map[string]string {
@@ -503,10 +500,7 @@ func (c Client) createSharedKeyLite(url string, headers map[string]string) (stri
 	}
 	strToSign := headers["x-ms-date"] + "\n" + can
 
-	hmac, err := c.computeHmac256(strToSign)
-	if err != nil {
-		return "", err
-	}
+	hmac := c.computeHmac256(strToSign)
 	return fmt.Sprintf("SharedKeyLite %s:%s", c.accountName, hmac), nil
 }
 

storage/client_test.go

@@ -244,7 +244,5 @@ func (s *StorageClientSuite) Test_createAuthorizationHeader(c *chk.C) {
 
 	canonicalizedString := `foobarzoo`
 	expected := `SharedKey foo:h5U0ATVX6SpbFX1H6GNuxIMeXXCILLoIvhflPtuQZ30=`
-	ah, err := cli.createAuthorizationHeader(canonicalizedString)
-	c.Assert(err, chk.IsNil)
-	c.Assert(ah, chk.Equals, expected)
+	c.Assert(cli.createAuthorizationHeader(canonicalizedString), chk.Equals, expected)
 }

storage/file.go

@@ -321,7 +321,7 @@ func (f FileServiceClient) listContent(path string, params url.Values, extraHead
 	}
 
 	if err = checkRespCode(resp.statusCode, []int{http.StatusOK}); err != nil {
-		_ = resp.body.Close()
+		resp.body.Close()
 		return nil, err
 	}
 
@@ -420,7 +420,7 @@ func (f FileServiceClient) GetFile(path string, fileRange *FileRange) (*FileStre
 	}
 
 	if err = checkRespCode(resp.statusCode, []int{http.StatusOK, http.StatusPartialContent}); err != nil {
-		defer resp.body.Close()
+		resp.body.Close()
 		return nil, err
 	}
 

storage/queue.go

@@ -319,7 +319,7 @@ func (c QueueServiceClient) DeleteMessage(queue, messageID, popReceipt string) e
 	if err != nil {
 		return err
 	}
-	deferresp.body.Close()
+	defer resp.body.Close()
 	return checkRespCode(resp.statusCode, []int{http.StatusNoContent})
 }
 

storage/util.go

@@ -15,12 +15,10 @@ import (
 	"time"
 )
 
-func (c Client) computeHmac256(message string) (string, error) {
+func (c Client) computeHmac256(message string) string {
 	h := hmac.New(sha256.New, c.accountKey)
-	if _, err := h.Write([]byte(message)); err != nil {
-		return "", fmt.Errorf("Failed computing to hmac256 : %v", err)
-	}
-	return base64.StdEncoding.EncodeToString(h.Sum(nil)), nil
+	h.Write([]byte(message))
+	return base64.StdEncoding.EncodeToString(h.Sum(nil))
 }
 
 func currentTimeRfc1123Formatted() string {