Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge community contribution in changelog #4656

Merged
merged 4 commits into from
May 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .vscode/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"azuresdkforcpp",
"centralus",
"centraluseuap",
"Chukwu",
"cmake",
"CMOCKA",
"Cobertura",
Expand Down Expand Up @@ -89,6 +90,7 @@
"iusg",
"jepio",
"Jeremi",
"jnyfah",
antkmsft marked this conversation as resolved.
Show resolved Hide resolved
"Kirilov",
"lcov",
"LIBCMTD",
Expand Down
8 changes: 8 additions & 0 deletions sdk/core/azure-core/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@

### Other Changes

- [[#3964]](https://github.com/Azure/azure-sdk-for-cpp/issues/3964) Ensuring some Azure SDK types have the expected default operations. (A community contribution, courtesy of _[jnyfah](https://github.com/jnyfah)_)

### Acknowledgments

Thank you to our developer community members who helped to make Azure Core better with their contributions to this release:

- Jennifer Chukwu _([GitHub](https://github.com/jnyfah))_

## 1.10.0-beta.1 (2023-05-04)

### Features Added
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/azure-core/test/ut/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ endif()

add_executable (
azure-core-test
test_traits.hpp
authorization_challenge_parser_test.cpp
azure_core_test.cpp
base64_test.cpp
Expand Down Expand Up @@ -84,6 +83,7 @@ add_executable (
simplified_header_test.cpp
string_test.cpp
telemetry_policy_test.cpp
test_traits.hpp
transport_adapter_base_test.cpp
transport_adapter_base_test.hpp
transport_adapter_implementation_test.cpp
Expand Down
4 changes: 3 additions & 1 deletion sdk/core/azure-core/test/ut/etag_test.cpp
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// SPDX-License-Identifier: MIT

#include "test_traits.hpp"
#include <gtest/gtest.h>

#include <azure/core/etag.hpp>

#include <gtest/gtest.h>

#include <limits>

using namespace Azure;
Expand Down
5 changes: 4 additions & 1 deletion sdk/core/azure-core/test/ut/test_traits.hpp
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// SPDX-License-Identifier: MIT

#include <type_traits>

template <typename T, typename... Args> struct ClassTraits
Expand Down Expand Up @@ -129,4 +132,4 @@ template <typename T, typename... Args> struct ClassTraits

// Check if T has virtual destructor
static constexpr bool has_virtual_destructor() { return std::has_virtual_destructor<T>::value; }
};
};