Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage/High throughput append blob #4586

Merged
merged 5 commits into from
May 3, 2023
Merged

Storage/High throughput append blob #4586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d1a72a
High Throughput Append Blob
microzchang Apr 27, 2023
a385882
disable test
microzchang Apr 27, 2023
1d13748
update test record for blobservicetest.setProperties
microzchang Apr 27, 2023
ff21d57
fix clang format
microzchang Apr 27, 2023
d81dc76
update test to both LIVEONLY and DISABLED
microzchang Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/storage/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "cpp",
"TagPrefix": "cpp/storage",
"Tag": "cpp/storage_497b3668b6"
"Tag": "cpp/storage_8f2bd0dbe5"
}
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/rest_client.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ namespace Azure { namespace Storage { namespace Blobs {
/**
* The version used for the operations to Azure storage services.
*/
constexpr static const char* ApiVersion = "2021-12-02";
constexpr static const char* ApiVersion = "2022-11-02";
} // namespace _detail
namespace Models {
/**
Expand Down
140 changes: 70 additions & 70 deletions sdk/storage/azure-storage-blobs/src/rest_client.cpp
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion sdk/storage/azure-storage-blobs/swagger/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,13 @@ directive:
"name": "ApiVersion",
"modelAsString": false
},
"enum": ["2021-12-02"],
"enum": ["2022-11-02"],
"description": "The version used for the operations to Azure storage services."
};
- from: swagger-document
where: $.parameters
transform: >
$.ApiVersionParameter.enum[0] = "2022-11-02";
```

### Rename Operations
Expand Down
11 changes: 11 additions & 0 deletions sdk/storage/azure-storage-blobs/test/ut/append_blob_client_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,4 +338,15 @@ namespace Azure { namespace Storage { namespace Test {
appendBlobClient2.AppendBlockFromUri(appendBlobClient.GetUrl() + GetSas(), options2));
}

TEST_F(AppendBlobClientTest, DISABLED_LIVEONLY_HighThroughputAppendBlob)
{
auto appendBlobClient = m_blobContainerClient->GetAppendBlobClient(RandomString());
microzchang marked this conversation as resolved.
Show resolved Hide resolved
appendBlobClient.Create();
auto blockContent = RandomBuffer(static_cast<size_t>(5_MB));
microzchang marked this conversation as resolved.
Show resolved Hide resolved
auto blockStream = Azure::Core::IO::MemoryBodyStream(blockContent.data(), blockContent.size());
appendBlobClient.AppendBlock(blockStream);

EXPECT_EQ(ReadBodyStream(appendBlobClient.Download().Value.BodyStream), blockContent);
}

}}} // namespace Azure::Storage::Test
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_responses.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
/**
* Access rights of the handle.
*/
Azure::Nullable<ShareFileHandleAccessRights> accessRights;
Azure::Nullable<ShareFileHandleAccessRights> AccessRights;
};
} // namespace Models

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-files-shares/src/share_directory_client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
accessRights |= Models::ShareFileHandleAccessRights::Delete;
}
}
directoryHandle.accessRights = std::move(accessRights);
directoryHandle.AccessRights = std::move(accessRights);
}

pagedResponse.DirectoryHandles.push_back(std::move(directoryHandle));
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-files-shares/src/share_file_client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
accessRights |= Models::ShareFileHandleAccessRights::Delete;
}
}
fileHandle.accessRights = std::move(accessRights);
fileHandle.AccessRights = std::move(accessRights);
}

pagedResponse.FileHandles.push_back(std::move(fileHandle));
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/azure-storage-files-shares/test/ut/share_directory_client_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,7 @@ namespace Azure { namespace Storage { namespace Test {
| Files::Shares::Models::ShareFileHandleAccessRights::Write
| Files::Shares::Models::ShareFileHandleAccessRights::Delete;
EXPECT_EQ(directoryHandles.size(), 1L);
EXPECT_TRUE(directoryHandles[0].accessRights.HasValue());
EXPECT_EQ(allAccessRights, directoryHandles[0].accessRights.Value());
EXPECT_TRUE(directoryHandles[0].AccessRights.HasValue());
EXPECT_EQ(allAccessRights, directoryHandles[0].AccessRights.Value());
}
}}} // namespace Azure::Storage::Test
4 changes: 2 additions & 2 deletions sdk/storage/azure-storage-files-shares/test/ut/share_file_client_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1429,7 +1429,7 @@ namespace Azure { namespace Storage { namespace Test {
| Files::Shares::Models::ShareFileHandleAccessRights::Write
| Files::Shares::Models::ShareFileHandleAccessRights::Delete;
EXPECT_EQ(fileHandles.size(), 1L);
EXPECT_TRUE(fileHandles[0].accessRights.HasValue());
EXPECT_EQ(allAccessRights, fileHandles[0].accessRights.Value());
EXPECT_TRUE(fileHandles[0].AccessRights.HasValue());
EXPECT_EQ(allAccessRights, fileHandles[0].AccessRights.Value());
}
}}} // namespace Azure::Storage::Test