Sync eng/common directory with azure-sdk-tools for PR 5608 (#4411) #4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ongoing * Move get-codeowners scripts and tests to their own dirs * address PR remarks * Fix CodeOwnerFileLocation path, fix casing, and dedup param defaults * fix param names * add todos on needed changes in cpp repo * Add CodeownersFileLocation to Get-Codeowners and use $null for default param values * move get-codeowners back to scripts/ and rename -functions to .lib * fix: use empty string as defaults instead of $nulls, to fix invocation * fix bug with invocation of Get-Codeowners + add support for passing IncludeNonUserAliases as switch * fix path iin Metadata-Helpers.ps1 * fix typo * Update archetype-cpp-release.yml --------- Co-authored-by: Konrad Jamrozik <[email protected]>
LarryOsterman
requested review from
danieljurek,
weshaggard and
benbp
as code owners
* First attempt at fixing nlohmann doctest compilation error * fixed compilation issue * Fixed ApiView generation for azure core
LarryOsterman
requested review from
RickWinter,
ahsonkhan,
antkmsft,
vhvb1989 and
gearama
as code owners
danieljurek
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
This PR merges all of main into the feature/amqp branch. I'm fine with it as is, but to prevent duplicate merging work we should wait until #4442 is merged.
benbp
pushed a commit
that referenced
this pull request
Apr 6, 2023
…4500) * ongoing * Move get-codeowners scripts and tests to their own dirs * address PR remarks * Fix CodeOwnerFileLocation path, fix casing, and dedup param defaults * fix param names * add todos on needed changes in cpp repo * Add CodeownersFileLocation to Get-Codeowners and use $null for default param values * move get-codeowners back to scripts/ and rename -functions to .lib * fix: use empty string as defaults instead of $nulls, to fix invocation * fix bug with invocation of Get-Codeowners + add support for passing IncludeNonUserAliases as switch * fix path iin Metadata-Helpers.ps1 * fix typo * Update archetype-cpp-release.yml --------- Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Konrad Jamrozik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ongoing
Move get-codeowners scripts and tests to their own dirs
address PR remarks
Fix CodeOwnerFileLocation path, fix casing, and dedup param defaults
fix param names
add todos on needed changes in cpp repo
Add CodeownersFileLocation to Get-Codeowners and use $null for default param values
move get-codeowners back to scripts/ and rename -functions to .lib
fix: use empty string as defaults instead of $nulls, to fix invocation
fix bug with invocation of Get-Codeowners + add support for passing IncludeNonUserAliases as switch
fix path iin Metadata-Helpers.ps1
fix typo
Update archetype-cpp-release.yml
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.