Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cspell for readme.ms in libcurl sterss test #4441

Merged
merged 4 commits into from
Mar 16, 2023
Merged

fix cspell for readme.ms in libcurl sterss test #4441

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c29529
fix cspell
gearama Mar 13, 2023
018855c
capitalize Valgrind and ubuntu
gearama Mar 13, 2023
0e98dab
sdada
gearama Mar 13, 2023
1a0e69b
fix2
gearama Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .vscode/cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"*.a",
"*.lib",
"*.yaml",
"**/libcurl-stress-test/README.md",
".github/CODEOWNERS",
".gitignore",
".vscode/cspell.json",
Expand Down Expand Up @@ -139,6 +138,8 @@
"stoll",
"stoull",
"STREQ",
"stresstesttbiruti6oi24k",
gearama marked this conversation as resolved.
Show resolved Hide resolved
"stresspgs",
"uaenorth",
"uksouth",
"undeleted",
Expand Down
10 changes: 5 additions & 5 deletions sdk/core/azure-core/test/libcurl-stress-test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@ This is work in progress. It's a prototype of how a stress test would look. This
The cpp file represents the code for the test, it will generate a number of invalid URLs and then issue CURL send commands. The requests are expected to fail. The point was that it exposes memory leaks in handling the error cases, which we fixed since.

### Dockerfile (https://www.docker.com/)
Represents the build file for the container in which the test runs, it is based on ubuntu 22.04 , from mcr.
The main change from default ubuntu is making sure we have the valgrind tool installed. Valgrind is a heap monitoring tool that helps identify potential stack traces that might leak memory. While not 100% effective is is great at reducing the surface are for investigations.
Represents the build file for the container in which the test runs, it is based on Ubuntu 22.04 , from MCR.
The main change from default Ubuntu is making sure we have the Valgrind tool installed. Valgrind is a heap monitoring tool that helps identify potential stack traces that might leak memory. While not 100% effective is great at reducing the surface are for investigations.

### Helm chart (https://helm.sh/)
Chart.yaml together with the bicep file(https://docs.microsoft.com/azure/azure-resource-manager/bicep/overview?tabs=bicep) and the deploy job file , represent the helm chart needed to deploy to the docker image built from the dockerfile to the stress cluster and execute the stress test.

The helm chart creates a pod with a container based on the docker image, and executes the test under valgrind.
The helm chart creates a pod with a container based on the docker image, and executes the test under Valgrind.

To deploy the chart you will need to run "azure-sdk-for-cpp\eng\common\scripts\stress-testing> .\deploy-stress-tests.ps1 -Namespace azuresdkforcpp -SearchDirectory E:\src\azure-sdk-for-cpp\sdk\core\azure-core\test -PushImage"

Where namaspace will be created if missing , search directory can be any folder where it will search for charts in it and all it's sub dirs, push image will call it to build the docker image.
gearama marked this conversation as resolved.
Show resolved Hide resolved
Where name space will be created if missing , search directory can be any folder where it will search for charts in it and all it's sub dirs, push image will call it to build the docker image.
gearama marked this conversation as resolved.
Show resolved Hide resolved

ATM the docker image is build by hand and harcoded in the chart to simplify matters.
gearama marked this conversation as resolved.
Show resolved Hide resolved
ATM the docker image is build by hand and hard coded in the chart to simplify matters.
gearama marked this conversation as resolved.
Show resolved Hide resolved

To build the image run "docker build -t stresstesttbiruti6oi24k.acr.io/azuresdkforcpp/curlstress:v8 --build-arg targetTest=azure-core-libcurl-stress-test --build-arg build=on ."

Expand Down