exclude template from test proxy #4189
Conversation
gearama
requested review from
danieljurek,
weshaggard and
benbp
as code owners
|
/azp run cpp - template |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run cpp - template |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -152,15 +152,15 @@ jobs: | |||
| runProxy: true | |||
| rootFolder: '$(Build.SourcesDirectory)/sdk/${{parameters.ServiceDirectory}}' | |||
| templateFolder: '$(Build.SourcesDirectory)/sdk/${{parameters.ServiceDirectory}}' | |||
| condition: and(succeeded(), contains(variables.CmakeArgs, 'BUILD_TESTING=ON')) | |||
| condition: and(succeeded(), contains(variables.CmakeArgs, 'BUILD_TESTING=ON'),ne('${{parameters.ServiceDirectory}}', 'template')) | |||
There was a problem hiding this comment.
I would prefer to have someone from EngSys look at this change, before merging.
There was a problem hiding this comment.
Why do we need to exclude the template package from test proxy? And if we really need to, is this the cleanest way to do it?
We are adding exception in multiple places, which seems a bit fragile. Are these the only places that need to opt-out?
cc @danieljurek
There was a problem hiding this comment.
@gearama @ahsonkhan we also depend on the template pipeline to validate engsys changes, often ones we make that affect all repos. I would prefer not to special case template so that we can catch any possible common proxy setup issues that might affect c++.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.