Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct invalid UTF-8 in comment in share_options.hpp #4130

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

Ariellink
Copy link
Member

/storage/files/shares/share_options.hpp

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

图片
图片

/storage/files/shares/share_options.hpp
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 27, 2022
@ghost
Copy link

ghost commented Nov 27, 2022

Thank you for your contribution Ariellink! We will review the pull request and get back to you soon.

Correct invalid UTF-8 in comment in line 291 share_options.hpp
@Jinming-Hu
Copy link
Member

/azp run cpp - storage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Was this the only instance you found?

@ahsonkhan
Copy link
Contributor

The CI leg failures here are unrelated and will be fixed once this is merged: #4132

Copy link
Member

@LarryOsterman LarryOsterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks quite reasonable. Smart quotes are ... challenging.

Copy link
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LibcurlTransportAdapter.md also contains this character multiple times. Makes sense to fix as well?

Edit: LibcurlTransportAdapter.md will be fixed by #4134.

@antkmsft
Copy link
Member

Thank you @Ariellink!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants