-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct invalid UTF-8 in comment in share_options.hpp #4130
Conversation
/storage/files/shares/share_options.hpp
Thank you for your contribution Ariellink! We will review the pull request and get back to you soon. |
Correct invalid UTF-8 in comment in line 291 share_options.hpp
/azp run cpp - storage |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Was this the only instance you found?
The CI leg failures here are unrelated and will be fixed once this is merged: #4132 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks quite reasonable. Smart quotes are ... challenging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LibcurlTransportAdapter.md
also contains this character multiple times. Makes sense to fix as well?
Edit: LibcurlTransportAdapter.md
will be fixed by #4134.
Thank you @Ariellink! |
/storage/files/shares/share_options.hpp
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.