Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify files by adding an extra space to trigger spell check on all files and fix any remaining issues to get the repo green #4115

Merged
merged 12 commits into from
Feb 6, 2023

Conversation

ahsonkhan
Copy link
Member

@ahsonkhan ahsonkhan commented Nov 14, 2022

Validate that the source (*.cpp/*.hpp) and markdown (*.md) files within the repo have spell check run on it and are all passing.

@ahsonkhan ahsonkhan added EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative. labels Nov 14, 2022
@ahsonkhan ahsonkhan added this to the 2022-12 milestone Nov 14, 2022
@ahsonkhan ahsonkhan self-assigned this Nov 14, 2022
@RickWinter
Copy link
Member

@ahsonkhan Is this draft still in progress or can this be closed?

@ahsonkhan
Copy link
Member Author

I wanted to see how many and what kind of spelling errors/warnings we have. Let me follow-up on next steps for this PR.

@antkmsft
Copy link
Member

@ahsonkhan, did we get what we wanted from this PR? Can it be closed?

@RickWinter
Copy link
Member

@ahsonkhan Can this draft be closed?

@ahsonkhan
Copy link
Member Author

It discovered some issues that were fixed in #4296

And issues like:
#4292

There are a couple other updates needed which I'll update this PR to tackle so we can merge it and get to a complete green state (and we need to figure out why the template CI is intermittently failing).

@ahsonkhan ahsonkhan changed the title Modify files by adding an extra space to trigger spell check on all. Modify files by adding an extra space to trigger spell check on all files and fix any remaining issues to get the repo green Feb 2, 2023
@ahsonkhan ahsonkhan marked this pull request as ready for review February 2, 2023 02:12
Copy link
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you commit, if you go with the PR title as commit message, it probably will be hard to correlate the title with the actual change, so I suggest to commit as something like "Fix typo"

@ahsonkhan ahsonkhan merged commit 1abebf9 into Azure:main Feb 6, 2023
@ahsonkhan ahsonkhan deleted the SpellCheckTest branch February 6, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants