Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test for Files Invalid XML #4113

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Unit Test for Files Invalid XML #4113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
177 changes: 177 additions & 0 deletions ...hares/test/ut/recordings/FileShareDirectoryClientTest.ListFilesAndDirectoriesEncoded.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,177 @@
{
"networkCallRecords": [
{
"Headers": {
"user-agent": "azsdk-cpp-storage-files-shares/12.4.0-beta.1 (Windows 10 Enterprise 6.3 22621 22621.1.amd64fre.ni_release.220506-1250)",
"x-ms-client-request-id": "7cb4510f-b458-4ca4-528c-38b0a2be4a90",
"x-ms-version": "2021-12-02"
},
"Method": "PUT",
"Response": {
"BODY": "",
"REASON_PHRASE": "Created",
"STATUS_CODE": "201",
"content-length": "0",
"date": "Mon, 14 Nov 2022 07:29:40 GMT",
"etag": "\"0x8DAC611FE63197B\"",
"last-modified": "Mon, 14 Nov 2022 07:29:41 GMT",
"server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
"x-ms-client-request-id": "7cb4510f-b458-4ca4-528c-38b0a2be4a90",
"x-ms-request-id": "fc75c97a-801a-000d-40fa-f7a672000000",
"x-ms-version": "2021-12-02"
},
"Url": "https://REDACTED.file.core.windows.net/filesharedirectoryclienttestlistfilesanddirectoriesencoded?restype=share"
},
{
"Headers": {
"user-agent": "azsdk-cpp-storage-files-shares/12.4.0-beta.1 (Windows 10 Enterprise 6.3 22621 22621.1.amd64fre.ni_release.220506-1250)",
"x-ms-client-request-id": "94b0a468-f21b-4512-7e88-908b26e913e5",
"x-ms-version": "2021-12-02"
},
"Method": "PUT",
"Response": {
"BODY": "",
"REASON_PHRASE": "Created",
"STATUS_CODE": "201",
"content-length": "0",
"date": "Mon, 14 Nov 2022 07:29:40 GMT",
"etag": "\"0x8DAC611FE930CF9\"",
"last-modified": "Mon, 14 Nov 2022 07:29:41 GMT",
"server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
"x-ms-client-request-id": "94b0a468-f21b-4512-7e88-908b26e913e5",
"x-ms-file-attributes": "Directory",
"x-ms-file-change-time": "2022-11-14T07:29:41.4140153Z",
"x-ms-file-creation-time": "2022-11-14T07:29:41.4140153Z",
"x-ms-file-id": "13835128424026341376",
"x-ms-file-last-write-time": "2022-11-14T07:29:41.4140153Z",
"x-ms-file-parent-id": "0",
"x-ms-file-permission-key": "13199961128260716138*16137673612980802019",
"x-ms-request-id": "fc75c97d-801a-000d-41fa-f7a672000000",
"x-ms-request-server-encrypted": "true",
"x-ms-version": "2021-12-02"
},
"Url": "https://REDACTED.file.core.windows.net/filesharedirectoryclienttestlistfilesanddirectoriesencoded/ListFilesAndDirectoriesEncodedbase?restype=directory"
},
{
"Headers": {
"user-agent": "azsdk-cpp-storage-files-shares/12.4.0-beta.1 (Windows 10 Enterprise 6.3 22621 22621.1.amd64fre.ni_release.220506-1250)",
"x-ms-client-request-id": "0b810656-6d00-4ca5-4e89-78058a6462fc",
"x-ms-version": "2021-12-02"
},
"Method": "PUT",
"Response": {
"BODY": "",
"REASON_PHRASE": "Created",
"STATUS_CODE": "201",
"content-length": "0",
"date": "Mon, 14 Nov 2022 07:29:40 GMT",
"etag": "\"0x8DAC611FEC057C5\"",
"last-modified": "Mon, 14 Nov 2022 07:29:41 GMT",
"server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
"x-ms-client-request-id": "0b810656-6d00-4ca5-4e89-78058a6462fc",
"x-ms-file-attributes": "Archive",
"x-ms-file-change-time": "2022-11-14T07:29:41.7108421Z",
"x-ms-file-creation-time": "2022-11-14T07:29:41.7108421Z",
"x-ms-file-id": "11529285414812647424",
"x-ms-file-last-write-time": "2022-11-14T07:29:41.7108421Z",
"x-ms-file-parent-id": "13835128424026341376",
"x-ms-file-permission-key": "8598604137816897901*16137673612980802019",
"x-ms-request-id": "fc75c97e-801a-000d-42fa-f7a672000000",
"x-ms-request-server-encrypted": "true",
"x-ms-version": "2021-12-02"
},
"Url": "https://REDACTED.file.core.windows.net/filesharedirectoryclienttestlistfilesanddirectoriesencoded/ListFilesAndDirectoriesEncodedbase/prefix%EF%BF%BFfile"
},
{
"Headers": {
"user-agent": "azsdk-cpp-storage-files-shares/12.4.0-beta.1 (Windows 10 Enterprise 6.3 22621 22621.1.amd64fre.ni_release.220506-1250)",
"x-ms-client-request-id": "b9c7c95d-dc94-4012-4822-daf8e54986b5",
"x-ms-version": "2021-12-02"
},
"Method": "PUT",
"Response": {
"BODY": "",
"REASON_PHRASE": "Created",
"STATUS_CODE": "201",
"content-length": "0",
"date": "Mon, 14 Nov 2022 07:29:41 GMT",
"etag": "\"0x8DAC611FEEDA296\"",
"last-modified": "Mon, 14 Nov 2022 07:29:42 GMT",
"server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
"x-ms-client-request-id": "b9c7c95d-dc94-4012-4822-daf8e54986b5",
"x-ms-file-attributes": "Directory",
"x-ms-file-change-time": "2022-11-14T07:29:42.0076694Z",
"x-ms-file-creation-time": "2022-11-14T07:29:42.0076694Z",
"x-ms-file-id": "16140971433240035328",
"x-ms-file-last-write-time": "2022-11-14T07:29:42.0076694Z",
"x-ms-file-parent-id": "13835128424026341376",
"x-ms-file-permission-key": "13199961128260716138*16137673612980802019",
"x-ms-request-id": "fc75c982-801a-000d-44fa-f7a672000000",
"x-ms-request-server-encrypted": "true",
"x-ms-version": "2021-12-02"
},
"Url": "https://REDACTED.file.core.windows.net/filesharedirectoryclienttestlistfilesanddirectoriesencoded/ListFilesAndDirectoriesEncodedbase/prefix%EF%BF%BFdirectory?restype=directory"
},
{
"Headers": {
"user-agent": "azsdk-cpp-storage-files-shares/12.4.0-beta.1 (Windows 10 Enterprise 6.3 22621 22621.1.amd64fre.ni_release.220506-1250)",
"x-ms-client-request-id": "0123cdef-b0ad-4149-641c-595075178130",
"x-ms-version": "2021-12-02"
},
"Method": "GET",
"Response": {
"BODY": "<?xml version=\"1.0\" encoding=\"utf-8\"?><EnumerationResults ServiceEndpoint=\"https://zchang.file.core.windows.net/\" ShareName=\"filesharedirectoryclienttestlistfilesanddirectoriesencoded\" DirectoryPath=\"ListFilesAndDirectoriesEncodedbase\"><Prefix Encoded=\"true\">prefix%EF%BF%BF</Prefix><DirectoryId>13835128424026341376</DirectoryId><Entries><Directory><Name Encoded=\"true\">prefix%EF%BF%BFdirectory</Name><FileId>16140971433240035328</FileId><Properties /></Directory><File><Name Encoded=\"true\">prefix%EF%BF%BFfile</Name><FileId>11529285414812647424</FileId><Properties><Content-Length>1024</Content-Length></Properties></File></Entries><NextMarker /></EnumerationResults>",
"REASON_PHRASE": "OK",
"STATUS_CODE": "200",
"content-type": "application/xml",
"date": "Mon, 14 Nov 2022 07:29:41 GMT",
"server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
"transfer-encoding": "chunked",
"x-ms-client-request-id": "0123cdef-b0ad-4149-641c-595075178130",
"x-ms-request-id": "fc75c983-801a-000d-45fa-f7a672000000",
"x-ms-version": "2021-12-02"
},
"Url": "https://REDACTED.file.core.windows.net/filesharedirectoryclienttestlistfilesanddirectoriesencoded/ListFilesAndDirectoriesEncodedbase?comp=list&prefix=prefix%EF%BF%BF&restype=directory"
},
{
"Headers": {
"user-agent": "azsdk-cpp-storage-files-shares/12.4.0-beta.1 (Windows 10 Enterprise 6.3 22621 22621.1.amd64fre.ni_release.220506-1250)",
"x-ms-client-request-id": "c20b5203-8134-4b62-4fee-254686cbea18",
"x-ms-version": "2021-12-02"
},
"Method": "DELETE",
"Response": {
"BODY": "",
"REASON_PHRASE": "Accepted",
"STATUS_CODE": "202",
"content-length": "0",
"date": "Mon, 14 Nov 2022 07:29:41 GMT",
"server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
"x-ms-client-request-id": "c20b5203-8134-4b62-4fee-254686cbea18",
"x-ms-request-id": "fc75c984-801a-000d-46fa-f7a672000000",
"x-ms-version": "2021-12-02"
},
"Url": "https://REDACTED.file.core.windows.net/filesharedirectoryclienttestlistfilesanddirectoriesencoded?restype=share"
},
{
"Headers": {
"user-agent": "azsdk-cpp-storage-files-shares/12.4.0-beta.1 (Windows 10 Enterprise 6.3 22621 22621.1.amd64fre.ni_release.220506-1250)",
"x-ms-client-request-id": "7f89277a-e9cf-4e3e-70f2-cc78530cb3f1",
"x-ms-version": "2021-12-02"
},
"Method": "DELETE",
"Response": {
"BODY": "",
"REASON_PHRASE": "Accepted",
"STATUS_CODE": "202",
"content-length": "0",
"date": "Mon, 14 Nov 2022 07:29:42 GMT",
"server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
"x-ms-client-request-id": "7f89277a-e9cf-4e3e-70f2-cc78530cb3f1",
"x-ms-request-id": "fc75c989-801a-000d-4afa-f7a672000000",
"x-ms-version": "2021-12-02"
},
"Url": "https://REDACTED.file.core.windows.net/filesharedirectoryclienttestlistfilesanddirectoriesencoded?restype=share"
}
]
}
28 changes: 28 additions & 0 deletions sdk/storage/azure-storage-files-shares/test/ut/share_directory_client_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,6 +820,34 @@ namespace Azure { namespace Storage { namespace Test {
}
}

TEST_F(FileShareDirectoryClientTest, ListFilesAndDirectoriesEncoded)
microzchang marked this conversation as resolved.
Show resolved Hide resolved
{
const std::string prefix = "prefix\xEF\xBF\xBF";
const std::string specialFileName = prefix + "file";
const std::string specialDirectoryName = prefix + "directory";
auto fileClient = m_fileShareDirectoryClient->GetFileClient(specialFileName);
auto directoryClient = m_fileShareDirectoryClient->GetSubdirectoryClient(specialDirectoryName);
fileClient.Create(1024);
directoryClient.Create();
auto fileUrl = fileClient.GetUrl();
EXPECT_EQ(
fileUrl,
m_fileShareDirectoryClient->GetUrl() + "/" + _internal::UrlEncodePath(specialFileName));
auto directoryUrl = directoryClient.GetUrl();
EXPECT_EQ(
directoryUrl,
m_fileShareDirectoryClient->GetUrl() + "/"
+ _internal::UrlEncodePath(specialDirectoryName));
Files::Shares::ListFilesAndDirectoriesOptions options;
options.Prefix = prefix;
auto response = m_fileShareDirectoryClient->ListFilesAndDirectories(options);
EXPECT_EQ(response.Prefix, prefix);
EXPECT_EQ(response.Directories.size(), 1L);
EXPECT_EQ(response.Directories[0].Name, specialDirectoryName);
EXPECT_EQ(response.Files.size(), 1L);
EXPECT_EQ(response.Files[0].Name, specialFileName);
}

TEST_F(FileShareDirectoryClientTest, HandlesFunctionalityWorks)
{
auto result = m_fileShareDirectoryClient->ListHandles();
Expand Down