Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identicalize the comments type #4063

Merged
merged 1 commit into from
Oct 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,27 @@
namespace Azure { namespace Core { namespace OpenTelemetry { namespace _detail {
/**
* @brief Provides version information.
*
*/
class PackageVersion final {
public:
/// Major numeric identifier.
/**
* @brief Major numeric identifier.
*/
static constexpr int32_t Major = AZURE_CORE_OPENTELEMETRY_VERSION_MAJOR;

/// Minor numeric identifier.
/**
* @brief Minor numeric identifier.
*/
static constexpr int32_t Minor = AZURE_CORE_OPENTELEMETRY_VERSION_MINOR;

/// Patch numeric identifier.
/**
* @brief Patch numeric identifier.
*/
static constexpr int32_t Patch = AZURE_CORE_OPENTELEMETRY_VERSION_PATCH;

/// Indicates whether the SDK is in a pre-release state.
/**
* @brief Indicates whether the SDK is in a pre-release state.
*/
static constexpr bool IsPreRelease
= sizeof(AZURE_CORE_OPENTELEMETRY_VERSION_PRERELEASE) != sizeof("");

Expand Down
17 changes: 12 additions & 5 deletions sdk/core/azure-core/src/private/package_version.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,27 @@
namespace Azure { namespace Core { namespace _detail {
/**
* @brief Provides version information.
*
*/
class PackageVersion final {
public:
/// Major numeric identifier.
/**
* @brief Major numeric identifier.
*/
static constexpr int32_t Major = AZURE_CORE_VERSION_MAJOR;

/// Minor numeric identifier.
/**
* @brief Minor numeric identifier.
*/
static constexpr int32_t Minor = AZURE_CORE_VERSION_MINOR;

/// Patch numeric identifier.
/**
* @brief Patch numeric identifier.
*/
static constexpr int32_t Patch = AZURE_CORE_VERSION_PATCH;

/// Indicates whether the SDK is in a pre-release state.
/**
* @brief Indicates whether the SDK is in a pre-release state.
*/
static constexpr bool IsPreRelease = sizeof(AZURE_CORE_VERSION_PRERELEASE) != sizeof("");

/**
Expand Down
14 changes: 12 additions & 2 deletions sdk/identity/azure-identity/src/private/package_version.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,30 @@
namespace Azure { namespace Identity { namespace _detail {
/**
* @brief Provides version information.
*
*/
class PackageVersion final {
public:
/**
* @brief Major numeric identifier.
*/
/// Major numeric identifier.
static constexpr int32_t Major = AZURE_IDENTITY_VERSION_MAJOR;

/**
* @brief Minor numeric identifier.
*/
/// Minor numeric identifier.
static constexpr int32_t Minor = AZURE_IDENTITY_VERSION_MINOR;

/**
* @brief Patch numeric identifier.
*/
/// Patch numeric identifier.
static constexpr int32_t Patch = AZURE_IDENTITY_VERSION_PATCH;

/// Indicates whether the SDK is in a pre-release state.
/**
* @brief Indicates whether the SDK is in a pre-release state.
*/
static constexpr bool IsPreRelease = sizeof(AZURE_IDENTITY_VERSION_PRERELEASE) != sizeof("");

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,27 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Certificat
namespace _detail {
/**
* @brief Provides version information.
*
*/
class PackageVersion final {
public:
/// Major numeric identifier.
/**
* @brief Major numeric identifier.
*/
static constexpr int32_t Major = AZURE_SECURITY_KEYVAULT_CERTIFICATES_VERSION_MAJOR;

/// Minor numeric identifier.
/**
* @brief Minor numeric identifier.
*/
static constexpr int32_t Minor = AZURE_SECURITY_KEYVAULT_CERTIFICATES_VERSION_MINOR;

/// Patch numeric identifier.
/**
* @brief Patch numeric identifier.
*/
static constexpr int32_t Patch = AZURE_SECURITY_KEYVAULT_CERTIFICATES_VERSION_PATCH;

/// Indicates whether the SDK is in a pre-release state.
/**
* @brief Indicates whether the SDK is in a pre-release state.
*/
static constexpr bool IsPreRelease
= sizeof(AZURE_SECURITY_KEYVAULT_CERTIFICATES_VERSION_PRERELEASE) != sizeof("");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,27 @@
namespace Azure { namespace Security { namespace KeyVault { namespace Keys { namespace _detail {
/**
* @brief Provides version information.
*
*/
class PackageVersion final {
public:
/// Major numeric identifier.
/**
* @brief Major numeric identifier.
*/
static constexpr int32_t Major = AZURE_SECURITY_KEYVAULT_KEYS_VERSION_MAJOR;

/// Minor numeric identifier.
/**
* @brief Minor numeric identifier.
*/
static constexpr int32_t Minor = AZURE_SECURITY_KEYVAULT_KEYS_VERSION_MINOR;

/// Patch numeric identifier.
/**
* @brief Patch numeric identifier.
*/
static constexpr int32_t Patch = AZURE_SECURITY_KEYVAULT_KEYS_VERSION_PATCH;

/// Indicates whether the SDK is in a pre-release state.
/**
* @brief Indicates whether the SDK is in a pre-release state.
*/
static constexpr bool IsPreRelease
= sizeof(AZURE_SECURITY_KEYVAULT_KEYS_VERSION_PRERELEASE) != sizeof("");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,27 @@
namespace Azure { namespace Security { namespace KeyVault { namespace Secrets { namespace _detail {
/**
* @brief Provides version information.
*
*/
class PackageVersion final {
public:
/// Major numeric identifier.
/**
* @brief Major numeric identifier.
*/
static constexpr int32_t Major = AZURE_SECURITY_KEYVAULT_SECRETS_VERSION_MAJOR;

/// Minor numeric identifier.
/**
* @brief Minor numeric identifier.
*/
static constexpr int32_t Minor = AZURE_SECURITY_KEYVAULT_SECRETS_VERSION_MINOR;

/// Patch numeric identifier.
/**
* @brief Patch numeric identifier.
*/
static constexpr int32_t Patch = AZURE_SECURITY_KEYVAULT_SECRETS_VERSION_PATCH;

/// Indicates whether the SDK is in a pre-release state.
/**
* @brief Indicates whether the SDK is in a pre-release state.
*/
static constexpr bool IsPreRelease
= sizeof(AZURE_SECURITY_KEYVAULT_SECRETS_VERSION_PRERELEASE) != sizeof("");

Expand Down
16 changes: 12 additions & 4 deletions sdk/storage/azure-storage-blobs/src/private/package_version.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,24 @@ namespace Azure { namespace Storage { namespace Blobs { namespace _detail {
*/
class PackageVersion final {
public:
/// Major numeric identifier.
/**
* @brief Major numeric identifier.
*/
static constexpr int32_t Major = AZURE_STORAGE_BLOBS_VERSION_MAJOR;

/// Minor numeric identifier.
/**
* @brief Minor numeric identifier.
*/
static constexpr int32_t Minor = AZURE_STORAGE_BLOBS_VERSION_MINOR;

/// Patch numeric identifier.
/**
* @brief Patch numeric identifier.
*/
static constexpr int32_t Patch = AZURE_STORAGE_BLOBS_VERSION_PATCH;

/// Indicates whether the SDK is in a pre-release state.
/**
* @brief Indicates whether the SDK is in a pre-release state.
*/
static constexpr bool IsPreRelease
= sizeof(AZURE_STORAGE_BLOBS_VERSION_PRERELEASE) != sizeof("");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,24 @@ namespace Azure { namespace Storage { namespace Common { namespace _detail {
*/
class PackageVersion final {
public:
/// Major numeric identifier.
/**
* @brief Major numeric identifier.
*/
static constexpr int Major = AZURE_STORAGE_COMMON_VERSION_MAJOR;

/// Minor numeric identifier.
/**
* @brief Minor numeric identifier.
*/
static constexpr int Minor = AZURE_STORAGE_COMMON_VERSION_MINOR;

/// Patch numeric identifier.
/**
* @brief Patch numeric identifier.
*/
static constexpr int Patch = AZURE_STORAGE_COMMON_VERSION_PATCH;

/// Indicates whether the SDK is in a pre-release state.
/**
* @brief Indicates whether the SDK is in a pre-release state.
*/
static constexpr bool IsPreRelease
= sizeof(AZURE_STORAGE_COMMON_VERSION_PRERELEASE) != sizeof("");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,24 @@ namespace Azure { namespace Storage { namespace Files { namespace DataLake { nam
*/
class PackageVersion final {
public:
/// Major numeric identifier.
/**
* @brief Major numeric identifier.
*/
static constexpr int32_t Major = AZURE_STORAGE_FILES_DATALAKE_VERSION_MAJOR;

/// Minor numeric identifier.
/**
* @brief Minor numeric identifier.
*/
static constexpr int32_t Minor = AZURE_STORAGE_FILES_DATALAKE_VERSION_MINOR;

/// Patch numeric identifier.
/**
* @brief Patch numeric identifier.
*/
static constexpr int32_t Patch = AZURE_STORAGE_FILES_DATALAKE_VERSION_PATCH;

/// Indicates whether the SDK is in a pre-release state.
/**
* @brief Indicates whether the SDK is in a pre-release state.
*/
static constexpr bool IsPreRelease
= sizeof(AZURE_STORAGE_FILES_DATALAKE_VERSION_PRERELEASE) != sizeof("");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,24 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares { names
*/
class PackageVersion final {
public:
/// Major numeric identifier.
/**
* @brief Major numeric identifier.
*/
static constexpr int32_t Major = AZURE_STORAGE_FILES_SHARES_VERSION_MAJOR;

/// Minor numeric identifier.
/**
* @brief Minor numeric identifier.
*/
static constexpr int32_t Minor = AZURE_STORAGE_FILES_SHARES_VERSION_MINOR;

/// Patch numeric identifier.
/**
* @brief Patch numeric identifier.
*/
static constexpr int32_t Patch = AZURE_STORAGE_FILES_SHARES_VERSION_PATCH;

/// Indicates whether the SDK is in a pre-release state.
/**
* @brief Indicates whether the SDK is in a pre-release state.
*/
static constexpr bool IsPreRelease
= sizeof(AZURE_STORAGE_FILES_SHARES_VERSION_PRERELEASE) != sizeof("");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,24 @@ namespace Azure { namespace Storage { namespace Queues { namespace _detail {
*/
class PackageVersion final {
public:
/// Major numeric identifier.
/**
* @brief Major numeric identifier.
*/
static constexpr int32_t Major = AZURE_STORAGE_QUEUES_VERSION_MAJOR;

/// Minor numeric identifier.
/**
* @brief Minor numeric identifier.
*/
static constexpr int32_t Minor = AZURE_STORAGE_QUEUES_VERSION_MINOR;

/// Patch numeric identifier.
/**
* @brief Patch numeric identifier.
*/
static constexpr int32_t Patch = AZURE_STORAGE_QUEUES_VERSION_PATCH;

/// Indicates whether the SDK is in a pre-release state.
/**
* @brief Indicates whether the SDK is in a pre-release state.
*/
static constexpr bool IsPreRelease
= sizeof(AZURE_STORAGE_QUEUES_VERSION_PRERELEASE) != sizeof("");

Expand Down
16 changes: 12 additions & 4 deletions sdk/template/azure-template/src/private/package_version.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,24 @@ namespace Azure { namespace Template { namespace _detail {
*/
class PackageVersion final {
public:
/// Major numeric identifier.
/**
* @brief Major numeric identifier.
*/
static constexpr int Major = AZURE_TEMPLATE_VERSION_MAJOR;

/// Minor numeric identifier.
/**
* @brief Minor numeric identifier.
*/
static constexpr int Minor = AZURE_TEMPLATE_VERSION_MINOR;

/// Patch numeric identifier.
/**
* @brief Patch numeric identifier.
*/
static constexpr int Patch = AZURE_TEMPLATE_VERSION_PATCH;

/// Indicates whether the SDK is in a pre-release state.
/**
* @brief Indicates whether the SDK is in a pre-release state.
*/
static constexpr bool IsPreRelease = sizeof(AZURE_TEMPLATE_VERSION_PRERELEASE) != sizeof("");

/**
Expand Down