merge main becasue of conflict #3972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jamie Magee <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
…3931) Co-authored-by: scbedd <[email protected]>
…enEnclave` and `AttestSgxmEnclave` (Azure#3928) * Fix broken link and typo in contributing.md * Use vector<uint8_t> for attest instead of strings * remove options * fix comments * update release version * remove versionig * revert changelog * add the change * update comment * Update sdk/attestation/azure-security-attestation/CHANGELOG.md Co-authored-by: Larry Osterman <[email protected]> * fix formatting * address pr comment * fix formating * update a comment * remove the attest tpm comment Co-authored-by: Peng Li <[email protected]> Co-authored-by: Larry Osterman <[email protected]>
* Set VCPKG_ROOT * Update eng/pipelines/templates/steps/vcpkg-clone.yml Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]>
…zure#3949) This should fix Azure/azure-sdk-tools#3538 as it will now upgrade the devops extension to the latest version which has the auth fix needed. Co-authored-by: Wes Haggard <[email protected]>
* pin newest version of proxy Co-authored-by: scbedd <[email protected]>
* version including lock fixes * target the correct proxy version Co-authored-by: scbedd <[email protected]>
* test1 * glob * quick cleanup * ddasda * ddsa * envs * dsds * Revert "ddsa" This reverts commit 6d9e385. * wq * comment out issues * valid test * maybe * qwewqewq * lang steps * Vcpkg pre-steps in the place Daniel should've recommend they go * RepoOwner * Correct repo owner name * Remove vcpkg.yml (we don't need to write) * PR trigger * small change * Update eng/pipelines/templates/jobs/perf.yml Co-authored-by: Mike Harder <[email protected]> * Update eng/pipelines/templates/jobs/perf.yml Co-authored-by: Mike Harder <[email protected]> * Update sdk/core/perf.yml Co-authored-by: Mike Harder <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: Mike Harder <[email protected]>
* use version of docker with CLI present * target repaired executable Co-authored-by: scbedd <[email protected]>
This reverts commit 14e4f52.
microzchang
requested review from
danieljurek,
weshaggard,
benbp,
RickWinter,
ahsonkhan,
antkmsft,
vhvb1989,
gearama and
LarryOsterman
as code owners
EmmaZhu
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.