Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull all Websockets changes to main. #3954

Merged
Merged
Show file tree
Hide file tree
Changes from 68 commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
5cff286
Initial WebSockets implementation. (#3823)
LarryOsterman Jul 27, 2022
94055dd
Merge main with WebSockets. (#3856)
LarryOsterman Jul 28, 2022
b12942e
Add support for Proxy Server to WinHTTP and CURL transports. (#3885)
LarryOsterman Aug 19, 2022
2e88a6e
Sync WebSockets branch with Main. (#3895)
LarryOsterman Aug 22, 2022
40cf560
Moved winhttp tests to WS2022 for WSL support (#3898)
LarryOsterman Aug 24, 2022
bcf83a4
Update the feature/websockets branch with changes from main (#3903)
LarryOsterman Aug 29, 2022
ceca1cf
Added functionality to enable CRL checking for CURL on linux; added t…
LarryOsterman Sep 19, 2022
557d836
Synced websockets feature branch with main. (#3945)
LarryOsterman Sep 19, 2022
99208c2
Removed websocket in preparation for main commit
LarryOsterman Sep 20, 2022
c5847e4
Skip proxy tests if proxy isn't running
LarryOsterman Sep 20, 2022
20f3abd
don't include winhttp if it's not wanted
LarryOsterman Sep 20, 2022
73260ff
Merge branch 'main' into larryo/websocketswithoutsockets
LarryOsterman Sep 20, 2022
5fa8a4d
Noise reduction
LarryOsterman Sep 20, 2022
3b46e08
Noise reduction; copied changelog entries over
LarryOsterman Sep 20, 2022
c159fd5
Improved code coverage numbers
LarryOsterman Sep 21, 2022
a2dcaa1
Exclude crypto internal errors to improve code coverage
LarryOsterman Sep 21, 2022
4b113f1
Cleaned up a few issues in the live platform matrix
LarryOsterman Sep 21, 2022
1c300e8
Force CI pipeline to run proxy tests
LarryOsterman Sep 21, 2022
7f50b91
Test proxy URLs are configurable
LarryOsterman Sep 21, 2022
7ec476e
Use System.TeamProjectId to be in sync with the new-testresources pow…
LarryOsterman Sep 21, 2022
898dacc
cspell fixes
LarryOsterman Sep 21, 2022
66d9782
Removed explicit default copy cor and explicit assignment
LarryOsterman Sep 21, 2022
d224125
Pull request feedback
LarryOsterman Sep 26, 2022
c825dea
Update sdk/core/azure-core/CHANGELOG.md
LarryOsterman Sep 28, 2022
6325b51
Update sdk/core/azure-core/inc/azure/core/http/curl_transport.hpp
LarryOsterman Sep 28, 2022
86db930
Update sdk/core/azure-core/inc/azure/core/http/curl_transport.hpp
LarryOsterman Sep 28, 2022
1eee5e1
Update sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp
LarryOsterman Sep 28, 2022
fea87e6
Update sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp
LarryOsterman Sep 28, 2022
ab1037f
Update sdk/core/azure-core/test/ut/CMakeLists.txt
LarryOsterman Sep 28, 2022
9744b32
Update sdk/core/azure-core/test/ut/CMakeLists.txt
LarryOsterman Sep 28, 2022
bbbc18e
Update sdk/core/azure-core/test/ut/CMakeLists.txt
LarryOsterman Sep 28, 2022
84c412e
PR feedback
LarryOsterman Sep 28, 2022
be8102b
clang-format
LarryOsterman Sep 28, 2022
7d8333b
Changed condition for testProxy
LarryOsterman Sep 28, 2022
5d3aaee
Update sdk/core/azure-core/CHANGELOG.md
LarryOsterman Sep 28, 2022
324358a
Update sdk/core/azure-core/inc/azure/core/http/curl_transport.hpp
LarryOsterman Sep 28, 2022
a2e799f
Update sdk/core/azure-core/inc/azure/core/http/curl_transport.hpp
LarryOsterman Sep 28, 2022
d273b00
Update sdk/core/azure-core/CMakeLists.txt
LarryOsterman Sep 28, 2022
7da862f
Update sdk/core/azure-core/inc/azure/core/http/curl_transport.hpp
LarryOsterman Sep 28, 2022
b233fbf
Code Review feedback
LarryOsterman Sep 29, 2022
aa84320
Merge branch 'larryo/websocketswithoutsockets' of https://github.com/…
LarryOsterman Sep 29, 2022
3e464f7
Update sdk/core/azure-core/CHANGELOG.md
LarryOsterman Sep 29, 2022
3645662
Renamed _detail::unique_xxx to _detail::Uniquexxx
LarryOsterman Sep 29, 2022
8fe482a
Build fix
LarryOsterman Sep 29, 2022
f807518
Update sdk/core/azure-core/inc/azure/core/http/win_http_transport.hpp
LarryOsterman Sep 30, 2022
dcbfad2
More code review feedback; Added UniqueHandle to simplify RAII wrappe…
LarryOsterman Sep 30, 2022
336b903
Merge branch 'larryo/websocketswithoutsockets' of https://github.com/…
LarryOsterman Sep 30, 2022
9c154c4
Wil is windows-only
LarryOsterman Sep 30, 2022
901f2a4
clang-format
LarryOsterman Sep 30, 2022
2aec13e
CI fixes; changed retry max delay
LarryOsterman Sep 30, 2022
531371b
Set VCPKG_ROOT to empty string
danieljurek Sep 30, 2022
acb16a7
Increased code coverage
LarryOsterman Sep 30, 2022
1c990c6
Allow VCPKG_ROOT to be empty
LarryOsterman Sep 30, 2022
479d400
Allow VCPKG_ROOT to be empty, take 2
LarryOsterman Sep 30, 2022
39c3d00
Allow VCPKG_ROOT to be empty, take 3
LarryOsterman Sep 30, 2022
79d8457
Allow VCPKG_ROOT to be empty, take 4
LarryOsterman Sep 30, 2022
ce55a22
Allow VCPKG_ROOT to be empty, take 5
LarryOsterman Sep 30, 2022
ad6c747
Try to see what cmake is thinking
LarryOsterman Sep 30, 2022
b70420f
Try to see what cmake is thinking
LarryOsterman Sep 30, 2022
a52ff2f
Corrected printfs
LarryOsterman Sep 30, 2022
d25d852
backed out earlier changes
LarryOsterman Sep 30, 2022
32baac1
backed out vcpkg changes
LarryOsterman Sep 30, 2022
da30a11
BUild fix
LarryOsterman Sep 30, 2022
2f5fd06
Enabled transport options for all scenarios that aren't BUILD_TRANSPO…
LarryOsterman Sep 30, 2022
17b674c
Noise reduction
LarryOsterman Sep 30, 2022
d41c088
More noise reduction
LarryOsterman Sep 30, 2022
dd8de4a
Added constructor to HTTP transports which takes a Azure::Core::Http:…
LarryOsterman Oct 3, 2022
53afb38
Make Proxy UserName be Azure::Nullable
LarryOsterman Oct 4, 2022
b808998
Update sdk/core/azure-core/inc/azure/core/http/curl_transport.hpp
LarryOsterman Oct 4, 2022
ceda7e8
Alphabetize vcpkg.json; added explicit wil dependencies
LarryOsterman Oct 4, 2022
8d1d63a
Merge branch 'larryo/websocketswithoutsockets' of https://github.com/…
LarryOsterman Oct 4, 2022
4ffa915
Cleaned up find_package conditional
LarryOsterman Oct 4, 2022
69b8525
Two bugs introduced by making username nullable
LarryOsterman Oct 4, 2022
c231c4a
clang-format
LarryOsterman Oct 4, 2022
baf15d6
Update sdk/core/azure-core/cgmanifest.json
LarryOsterman Oct 4, 2022
ea40d1a
Added wil to vcpkg/vcpkg.json
LarryOsterman Oct 4, 2022
31b805f
More code coverage fixes
LarryOsterman Oct 4, 2022
296322a
Backed out change accidentally added; clang-format
LarryOsterman Oct 4, 2022
f2ceeeb
flagged retry policy changes in changelog
LarryOsterman Oct 4, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions .vscode/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,13 @@
"*.exe",
"*.a",
"*.lib",
"*.yaml",
"**/libcurl-stress-test/README.md",
"*.yaml",
"**/libcurl-stress-test/README.md",
".github/CODEOWNERS",
".gitignore",
".vscode/cspell.json",
"ci.yml",
"squid.conf*",
"eng/common/**/*",
"json.hpp",
"Dockerfile",
Expand All @@ -34,6 +36,8 @@
"Aloctl",
"azcore",
"azsdk",
"azsdkengsys",
"azurecr",
"azuresdk",
"azuresdkforcpp",
"centralus",
Expand Down Expand Up @@ -80,27 +84,31 @@
"Lohmann",
"LPBYTE",
"LPSTR",
"LPWSTR",
"MHSM",
"moxygen",
"MSRC",
"ncus",
"Niels",
"nlohmann",
"nostd",
"noclean",
"NOCLOSE",
"NOCRLF",
"nohup",
"NOLINT",
"NOMINMAX",
"northcentralus",
"nostd",
"NTSTATUS",
"okhttp",
"opentelemetry",
"otel",
"PBYTE",
"pdbs",
"Piotrowski",
"pscredential",
"PUCHAR",
"PVOID",
"pwsh",
"Ragrs",
"Ragzrs",
Expand All @@ -121,22 +129,22 @@
"stoll",
"stoull",
"STREQ",
"uaenorth",
"uksouth",
"undeleted",
"unscoped",
"unskipped",
"UPNs",
"uaenorth",
"usgov",
"usgoviowa",
"usgovvirginia",
"westcentralus",
"vcpkg",
"Viet",
"Viktor",
"vusg",
"Wdocumentation",
"Werror",
"westcentralus",
"westus",
"Wextra",
"Wgnu",
Expand Down Expand Up @@ -178,6 +186,12 @@
"SECP"
]
},
{
"filename": "**/sdk/core/azure-core/**",
"words": [
"TEAMPROJECTID"
]
},
{
"filename": "**/sdk/core/azure-core/README.md",
"words": [
Expand Down Expand Up @@ -227,10 +241,10 @@
]
},
{
"filename": "**/sdk/storage/azure-storage-files-shares/**/*",
"words": [
"mibps"
]
"filename": "**/sdk/storage/azure-storage-files-shares/**/*",
"words": [
"mibps"
]
},
{
"filename": "**/cmake-modules/**/*",
Expand Down
53 changes: 53 additions & 0 deletions CMakeSettings.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,65 @@
"buildCommandArgs": "",
"ctestCommandArgs": "",
"inheritEnvironments": [ "msvc_x86" ],
"variables": [
{
"name": "BUILD_TESTING",
"value": "True",
"type": "BOOL"
},
{
"name": "VCPKG_TARGET_TRIPLET",
"value": "x86-windows-static",
"type": "STRING"
},
{
"name": "MSVC_USE_STATIC_CRT",
"value": "True",
"type": "BOOL"
}
]
},
{
"name": "x86-Release-static_curl",
"generator": "Ninja",
"configurationType": "MinSizeRel",
"buildRoot": "${projectDir}\\out\\build\\${name}",
"installRoot": "${projectDir}\\out\\install\\${name}",
"cmakeCommandArgs": "",
"buildCommandArgs": "",
"ctestCommandArgs": "",
"inheritEnvironments": [ "msvc_x86" ],
"variables": [
{
"name": "VCPKG_TARGET_TRIPLET",
"value": "x86-windows-static",
"type": "STRING"
},
{
"name": "BUILD_TESTING",
"value": "True",
"type": "BOOL"
},
{
"name": "DISABLE_PROXY_TESTS",
"value": "True",
"type": "BOOL"
},
{
"name": "BUILD_PERFORMANCE_TESTS",
"value": "True",
"type": "BOOL"
},
{
"name": "RUN_LONG_UNIT_TESTS",
"value": "True",
"type": "BOOL"
},
{
"name": "BUILD_TRANSPORT_CURL",
"value": "True",
"type": "BOOL"
},
{
"name": "MSVC_USE_STATIC_CRT",
"value": "True",
Expand Down
8 changes: 8 additions & 0 deletions eng/pipelines/templates/jobs/archetype-sdk-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ parameters:
- name: TestEnv
type: object
default: []
- name: PreTestSteps
type: stepList
default: []
- name: PostTestSteps
type: stepList
default: []

jobs:
- template: /eng/common/pipelines/templates/jobs/archetype-sdk-tests-generate.yml
Expand All @@ -53,6 +59,8 @@ jobs:
LineCoverageTarget: ${{ parameters.LineCoverageTarget }}
BranchCoverageTarget: ${{ parameters.BranchCoverageTarget }}
TestEnv: ${{ parameters.TestEnv }}
PreTestSteps: ${{ parameters.PreTestSteps }}
PostTestSteps: ${{ parameters.PostTestSteps }}

# Disable build for cpp - client
- ${{ if ne(parameters.ServiceDirectory, 'not-specified' )}}:
Expand Down
11 changes: 11 additions & 0 deletions eng/pipelines/templates/jobs/ci.tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ parameters:
- name: UsePlatformContainer
type: boolean
default: false
- name: PreTestSteps
type: stepList
default: []
- name: PostTestSteps
type: stepList
default: []


jobs:
- job:
Expand Down Expand Up @@ -137,6 +144,8 @@ jobs:
BuildArgs: "$(BuildArgs)"
Env: "$(CmakeEnvArg)"

- ${{ parameters.PreTestSteps }}

- pwsh: |
ctest `
-C Debug `
Expand All @@ -147,6 +156,8 @@ jobs:
-T Test
workingDirectory: build
displayName: Test

- ${{ parameters.PostTestSteps }}

- task: PublishTestResults@2
inputs:
Expand Down
10 changes: 10 additions & 0 deletions eng/pipelines/templates/jobs/live.tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ parameters:
- name: UsePlatformContainer
type: boolean
default: false
- name: PreTestSteps
type: stepList
default: []
- name: PostTestSteps
type: stepList
default: []

jobs:
- job: ValidateLive
Expand Down Expand Up @@ -126,6 +132,8 @@ jobs:
Location: ${{ coalesce(parameters.Location, parameters.CloudConfig.Location) }}
SubscriptionConfiguration: ${{ parameters.CloudConfig.SubscriptionConfiguration }}

- ${{ parameters.PreTestSteps }}

# For non multi-config generator use the same build configuration to run tests
# We don't need to set it to invoke ctest
# Visual Studio generator used in CI is a multi-config generator.
Expand All @@ -141,6 +149,8 @@ jobs:
succeeded(),
ne(variables['RunSamples'], '1'))

- ${{ parameters.PostTestSteps }}

- task: PublishTestResults@2
inputs:
testResultsFormat: cTest
Expand Down
10 changes: 10 additions & 0 deletions eng/pipelines/templates/stages/archetype-sdk-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ parameters:
- name: UnsupportedClouds
type: string
default: ''
- name: PreTestSteps
type: stepList
default: []
- name: PostTestSteps
type: stepList
default: []


stages:
Expand Down Expand Up @@ -96,6 +102,8 @@ stages:
${{ if eq(parameters.ServiceDirectory, 'template') }}:
TestPipeline: true
TestEnv: ${{ parameters.TestEnv }}
PreTestSteps: ${{ parameters.PreTestSteps }}
PostTestSteps: ${{ parameters.PostTestSteps }}

- ${{ if and(eq(variables['System.TeamProject'], 'internal'), ne(parameters.LiveTestCtestRegex, '')) }}:
- template: /eng/pipelines/templates/stages/archetype-sdk-tests.yml
Expand All @@ -110,6 +118,8 @@ stages:
Clouds: ${{ parameters.Clouds }}
SupportedClouds: ${{ parameters.SupportedClouds }}
UnsupportedClouds: ${{ parameters.UnsupportedClouds }}
PreTestSteps: ${{ parameters.PreTestSteps }}
PostTestSteps: ${{ parameters.PostTestSteps }}

- ${{ if and(eq(variables['System.TeamProject'], 'internal'), not(endsWith(variables['Build.DefinitionName'], ' - tests'))) }}:
- template: archetype-cpp-release.yml
Expand Down
8 changes: 8 additions & 0 deletions eng/pipelines/templates/stages/archetype-sdk-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ parameters:
- name: UnsupportedClouds
type: string
default: ''
- name: PreTestSteps
type: stepList
default: []
- name: PostTestSteps
type: stepList
default: []

stages:
- ${{ each cloud in parameters.CloudConfig }}:
Expand Down Expand Up @@ -57,3 +63,5 @@ stages:
Coverage: ${{ parameters.Coverage}}
CoverageReportPath: ${{ parameters.CoverageReportPath}}
TimeoutInMinutes: ${{ parameters.TimeoutInMinutes}}
PreTestSteps: ${{ parameters.PreTestSteps }}
PostTestSteps: ${{ parameters.PostTestSteps }}
Loading