Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol layer for data lake STG82 #3927

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

microzchang
Copy link
Member

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

@microzchang microzchang changed the base branch from main to feature/datalakestg82 September 9, 2022 06:32
Copy link
Member

@Jinming-Hu Jinming-Hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider if it's feasible to move those functions making requests to .blob. endpoints into blob package.

@Jinming-Hu
Copy link
Member

It turned out ListDeletedBlobs doesn't exist in blob package swagger file. I'm afraid we have to use the one in datalake swagger. Now we need to check if any structs are defined in both packages. If so, how to deduplicate.

@microzchang microzchang merged commit d3c5dd4 into Azure:feature/datalakestg82 Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants