-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality to enable CRL checking for CURL on linux; added tests for this new functionality. #3923
Merged
LarryOsterman
merged 61 commits into
Azure:feature/websockets
from
LarryOsterman:larryo/tlsrootcertificateoverride
Sep 19, 2022
Merged
Added functionality to enable CRL checking for CURL on linux; added tests for this new functionality. #3923
LarryOsterman
merged 61 commits into
Azure:feature/websockets
from
LarryOsterman:larryo/tlsrootcertificateoverride
Sep 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if creating the transport throws.
LarryOsterman
requested review from
RickWinter,
ahsonkhan,
antkmsft,
vhvb1989 and
gearama
as code owners
September 7, 2022 00:16
…m/LarryOsterman/azure-sdk-for-cpp into larryo/tlsrootcertificateoverride
Ping :). |
vhvb1989
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a long time, I was worried about this moment. The moment when our libcurl implementation would require orchestrating things beyond libcurl (like openssl, windows api, etc).
The long night has arrived!!! hahaha So glad we have Larry for this :)
benbp
reviewed
Sep 14, 2022
RickWinter
reviewed
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to enable CRL checking for CURL on linux.
This one is somewhat unpleasant and much larger than expected.
This pull request enables two pieces of functionality:
Enabling CRL validation ended up pulling in a significant chunk of code from azure-c-shared-util which handled retrieving CRLs (I was unable to find code in libCURL to do this). Native LibCURL support for CRL validation is limited to the schannel SSL backend (Windows Only).
This change also adds logic to the CURL transport to enable the ability to ignore CRL retrieval errors (there doesn't seem to be a comparable way of doing this for WinHTTP so it is a CURL transport only option).
To verify the root certificate logic, an extremely simple client for the SDK Test Proxy was written and is used to "record" a request to the C++ SDK HTTP server.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.