New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial WebSockets implementation. #3823

Merged

LarryOsterman merged 160 commits into Azure:feature/websockets from LarryOsterman:larryo/createwebsockets

Jul 27, 2022

Member

LarryOsterman commented Jul 13, 2022 •

edited

Loading

Create a WebSockets transport implementation for Azure Core.

The Cognitive Services team requires support for WebSockets to complete their move to Azure Core.

This pull request has two sets of changes

A complete implementation of the WebSockets protocol
A set of changes required to pass the CI gates with the WebSockets protocol changes.

The WebSocket protocol is implemented in the Azure::Core::Http::WebSockets::_internal::WebSocket class. It depends on a WebSocketTransport class and the existing HttpTransport class and uses our existing Http Pipeline technology for the initial WebSocket protocol exchange.

Note that this PR is going into feature/websockets and NOT into main. As a consequence, it is extremely hard for parts of this PR to be extracted and submitted separately.

LarryOsterman added 30 commits

June 17, 2022 16:56


          Initial WebSocket implementation

a73b00d


          Checkpoint

ae9de9e


          Support multiple frame sizes; preliminary doxygen

3d505a0


          Multi-threaded stress test

7e0e9fc


          Merge branch 'main' into larryo/createwebsockets

98d9913


          Starting implementation of WinHTTP websocket transport

97e6360


          Merge branch 'main' into larryo/createwebsockets

fdad3f3


          Completed implementation of HTTP websockets

1372b0a


          Merge branch 'main' into larryo/createwebsockets

daa1163


          CI fixes

8cd1e7c


          cspell

4ff6584


          cspell

0f509cc


          detail->details

20fdade


          C++15 fixes

f709bc4


          CI fixes

0b4b752


          CI changes

b475efa


          CI fixes

d29fc89


          clang-format

791550b


          ci fixes

89cf5f6


          dead code handling?

7e43022


          clang_format

9c69110


          clang-format

95d28b1


          Trial: Added pip install websockets

59da14b


          First try at websocket server

d7da11c


          corrected condition for websocket

a997d8d


          Merge branch 'main' into larryo/createwebsockets

76ec50c


          Checkpoint with traces

5d17885


          Try again with conditional

ad82111


          updated working directory

9b684a3


          Try updating Python version

b85c763

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Outdated Show resolved Hide resolved

LarryOsterman and others added 2 commits

July 26, 2022 16:18


          Simplified expression

755fc80


          Update sdk/core/azure-core/src/http/websockets/websockets_impl.cpp

1072f76

Co-authored-by: Rick Winter <[email protected]>

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Outdated Show resolved Hide resolved

gearama requested changes

View reviewed changes

Member

gearama left a comment

a few comments

sdk/core/azure-core/inc/azure/core/base64.hpp Outdated Show resolved Hide resolved

sdk/core/azure-core/inc/azure/core/http/websockets/curl_websockets_transport.hpp Show resolved Hide resolved

sdk/core/azure-core/inc/azure/core/http/websockets/websockets.hpp Show resolved Hide resolved

sdk/core/azure-core/inc/azure/core/http/websockets/websockets.hpp Show resolved Hide resolved

sdk/core/azure-core/inc/azure/core/http/websockets/websockets.hpp Show resolved Hide resolved

sdk/core/azure-core/src/cryptography/sha_hash.cpp Show resolved Hide resolved

sdk/core/azure-core/src/http/curl/curl.cpp Outdated Show resolved Hide resolved

sdk/core/azure-core/src/http/curl/curl_connection_private.hpp Show resolved Hide resolved

sdk/core/azure-core/src/http/websockets/websockets_impl.hpp Show resolved Hide resolved

sdk/core/azure-core/src/http/websockets/websockets_impl.hpp Show resolved Hide resolved

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Show resolved Hide resolved

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Show resolved Hide resolved

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Outdated Show resolved Hide resolved

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Outdated Show resolved Hide resolved

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Show resolved Hide resolved

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Outdated Show resolved Hide resolved

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Show resolved Hide resolved

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Outdated Show resolved Hide resolved

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Show resolved Hide resolved

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Show resolved Hide resolved


          Code review feedback

fa8f236

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Outdated Show resolved Hide resolved

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Outdated Show resolved Hide resolved

RickWinter reviewed

View reviewed changes

sdk/core/azure-core/src/http/websockets/websockets_impl.cpp Outdated Show resolved Hide resolved

RickWinter approved these changes

View reviewed changes

Member

RickWinter left a comment

Done :)

LarryOsterman and others added 5 commits

July 26, 2022 17:28


          Update sdk/core/azure-core/src/http/websockets/websockets_impl.cpp

868e68f

Co-authored-by: Rick Winter <[email protected]>


          Pull request feedback

74f40c0


          Merge branch 'larryo/createwebsockets' of https://github.com/LarryOst…

cfe8fae

…erman/azure-sdk-for-cpp into larryo/createwebsockets


          Code Review feedback


          clang-format

965538e

LarryOsterman requested review from gearama and ahsonkhan

July 27, 2022 17:03

gearama approved these changes

View reviewed changes

LarryOsterman merged commit 5cff286 into Azure:feature/websockets

LarryOsterman deleted the larryo/createwebsockets branch

July 27, 2022 18:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benbp benbp left review comments

danieljurek danieljurek approved these changes

RickWinter RickWinter approved these changes

gearama gearama approved these changes

weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

antkmsft Awaiting requested review from antkmsft antkmsft is a code owner

vhvb1989 Awaiting requested review from vhvb1989 vhvb1989 is a code owner

ahsonkhan Awaiting requested review from ahsonkhan

Labels

None yet