restructure storage samples #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinming-Hu
added
Client
Jinming-Hu
requested review from
antkmsft,
gearama,
katmsft,
RickWinter,
vhvb1989 and
vinjiang
as code owners
Jinming-Hu
commented
Nov 17, 2021
Jinming-Hu
commented
Nov 17, 2021
Jinming-Hu
commented
Nov 17, 2021
sdk/storage/azure-storage-files-datalake/samples/CMakeLists.txt
Outdated
Show resolved
Hide resolved
|
/azp run cpp - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vhvb1989
reviewed
Nov 17, 2021
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| cmake_minimum_required (VERSION 3.13) |
There was a problem hiding this comment.
nit. Ideally, we might want to have one folder for each sample. Each folder would contain a CMakeList and the source code.
In the future, we want to make then entire folder a copy/paste project with no dependency to the repo.
This works for now and is better than previous approach.
sdk/storage/azure-storage-blobs/samples/blob_getting_started.cpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-files-datalake/samples/CMakeLists.txt
Outdated
Show resolved
Hide resolved
Jinming-Hu
commented
Nov 18, 2021
Jinming-Hu
commented
Nov 18, 2021
antkmsft
approved these changes
Nov 18, 2021
Co-authored-by: Victor Vazquez <[email protected]>
|
/azp run cpp - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run cpp - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@vhvb1989 I just added support for reading from env var. It all looks good to me now. Feel free to hit the merge button to unblock youself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.