-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce incidence of build storms #3079
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…don't trigger builds for every checkin if there are other builds running, expand core to test everything in CI
weshaggard
approved these changes
Nov 8, 2021
weshaggard
reviewed
Nov 8, 2021
gearama
approved these changes
Nov 8, 2021
ahsonkhan
reviewed
Nov 9, 2021
ahsonkhan
reviewed
Nov 9, 2021
@@ -1,5 +1,6 @@ | |||
# NOTE: Please refer to https://aka.ms/azsdk/engsys/ci-yaml before editing this file. | |||
trigger: | |||
batch: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything in particular that motivated us to start using batch
now? I think this change generally makes sense to be more efficient, but I am assuming, it could make finding the exact commit which caused a build failure to be a bit difficult. Do I understand it correctly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main
don't trigger builds for every checkin if there are other builds running docs