Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync eng/common directory with azure-sdk-tools for PR 1902 #2747

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1902 See eng/common workflow

- Fix rg.Name to rg.ResourceGroupName
- Add more verbose logging for better debugging
- Handle deleted resource groups when gathering puragable resource
- Remove coerce now that we are collecting in functions
@azure-sdk azure-sdk requested review from danieljurek and a team as code owners August 13, 2021 21:09
@azure-sdk azure-sdk requested review from weshaggard and removed request for a team August 13, 2021 21:09
@azure-sdk azure-sdk added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Aug 13, 2021
@azure-sdk azure-sdk merged commit 45e48d3 into main Aug 13, 2021
@azure-sdk azure-sdk deleted the sync-eng/common-FixResourceCleanup-1902 branch August 13, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants