Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vcpkg comment tag failed #3061

Closed
RickWinter opened this issue Nov 5, 2021 · 3 comments
Closed

Vcpkg comment tag failed #3061

RickWinter opened this issue Nov 5, 2021 · 3 comments
Assignees
@danieljurek
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Milestone
[2021] December

Comments

@RickWinter
Copy link
Member

The VCPKG comment tag failed.

  • $prOwners = D:\a_work\1\s/eng/common/scripts/get-codeowners.ps1 `
  • CategoryInfo : ObjectNotFound: (D:\a_work\1\s/eng/…/get-codeowners.ps1:String) [], ParentContainsErrorRecordException
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 5, 2021
@RickWinter RickWinter added bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Nov 5, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 5, 2021
@danieljurek
Copy link
Member

get-codeowners.ps1 has been removed.

Change: 24b3487

Failure: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1179876&view=logs&j=6d63b2a5-a608-50ae-6bee-c0a1cf664e1f&t=063b5c9b-1ec2-58d9-0ee8-2771d0581a79

Looks like the way to go forward is to use identity-resolver or /eng/common/pipelines/templates/steps/get-pr-owners.yml

@danieljurek danieljurek mentioned this issue Nov 5, 2021
Closed
@RickWinter RickWinter added this to the [2021] December milestone Nov 8, 2021
@ahsonkhan ahsonkhan mentioned this issue Nov 8, 2021
Closed
@danieljurek danieljurek mentioned this issue Nov 8, 2021
Merged
@kurtzeborn
Copy link
Member

kurtzeborn commented Nov 15, 2021 •
edited
Loading

This was initially blocked because of the lost script @weshaggard mentioned above. That script has been restored, so this is unblocked. @sima-zhu is also working on improvements and consolidation related to what this script does, so it will be important that she validate this scenario is not broken when she is completing that work.

This is @sima-zhu's PR working in this area: Azure/azure-sdk-tools#2245

@kurtzeborn kurtzeborn mentioned this issue Nov 15, 2021
Merged
@weshaggard
Copy link
Member

This should be fully fixed now with #3130

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danieljurek danieljurek

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
[2021] December
Development

No branches or pull requests
4 participants
@danieljurek @RickWinter @weshaggard @kurtzeborn