Skip to content

Commit

Permalink
fix cspell for readme.ms in libcurl sterss test (#4441)
Browse files Browse the repository at this point in the history
* fix cspell

* capitalize Valgrind and ubuntu

* sdada

* fix2
  • Loading branch information
gearama authored and antkmsft committed Apr 5, 2023
1 parent a1c7530 commit fcecd68
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
1 change: 0 additions & 1 deletion .vscode/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"*.a",
"*.lib",
"*.yaml",
"**/libcurl-stress-test/README.md",
".github/CODEOWNERS",
".gitignore",
".vscode/cspell.json",
Expand Down
16 changes: 8 additions & 8 deletions sdk/core/azure-core/test/libcurl-stress-test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,24 @@ This is work in progress. It's a prototype of how a stress test would look. This
The cpp file represents the code for the test, it will generate a number of invalid URLs and then issue CURL send commands. The requests are expected to fail. The point was that it exposes memory leaks in handling the error cases, which we fixed since.

### Dockerfile (https://www.docker.com/)
Represents the build file for the container in which the test runs, it is based on ubuntu 22.04 , from mcr.
The main change from default ubuntu is making sure we have the valgrind tool installed. Valgrind is a heap monitoring tool that helps identify potential stack traces that might leak memory. While not 100% effective is is great at reducing the surface are for investigations.
Represents the build file for the container in which the test runs, it is based on Ubuntu 22.04 , from MCR.
The main change from default Ubuntu is making sure we have the Valgrind tool installed. Valgrind is a heap monitoring tool that helps identify potential stack traces that might leak memory. While not 100% effective is great at reducing the surface are for investigations.

### Helm chart (https://helm.sh/)
Chart.yaml together with the bicep file(https://docs.microsoft.com/azure/azure-resource-manager/bicep/overview?tabs=bicep) and the deploy job file , represent the helm chart needed to deploy to the docker image built from the dockerfile to the stress cluster and execute the stress test.

The helm chart creates a pod with a container based on the docker image, and executes the test under valgrind.
The helm chart creates a pod with a container based on the docker image, and executes the test under Valgrind.

To deploy the chart you will need to run "azure-sdk-for-cpp\eng\common\scripts\stress-testing> .\deploy-stress-tests.ps1 -Namespace azuresdkforcpp -SearchDirectory E:\src\azure-sdk-for-cpp\sdk\core\azure-core\test -PushImage"

Where namaspace will be created if missing , search directory can be any folder where it will search for charts in it and all it's sub dirs, push image will call it to build the docker image.
Where namespace will be created if missing , search directory can be any folder where it will search for charts in it and all it's sub dirs, push image will call it to build the docker image.

ATM the docker image is build by hand and harcoded in the chart to simplify matters.
ATM the docker image is build by hand and hard-coded in the chart to simplify matters.

To build the image run "docker build -t stresstesttbiruti6oi24k.acr.io/azuresdkforcpp/curlstress:v8 --build-arg targetTest=azure-core-libcurl-stress-test --build-arg build=on ."
To build the image run "docker build -t <acr>/azuresdkforcpp/curlstress:v8 --build-arg targetTest=azure-core-libcurl-stress-test --build-arg build=on ."

To push to mcr : "docker push stresstesttbiruti6oi24k.acr.io/azuresdkforcpp/curlstress:v8"
Obviously after logging in to the acr "az acr login -n stresspgs7b6dif73rup6.azurecr.io"
To push to mcr : "docker push <acr>/azuresdkforcpp/curlstress:v8"
Obviously after logging in to the acr "az acr login -n <acr>"

To use another image you will need to go to line 12 in deploy job and update with your new file.

Expand Down

0 comments on commit fcecd68

Please sign in to comment.