enable true version override so that other tools also have a shot at …

…picking up the replaced version (#4440)

Co-authored-by: scbedd <[email protected]>

eng/common/testproxy/override-proxy-version.ps1

@@ -0,0 +1,25 @@
+<#
+.SYNOPSIS
+Replaces target test-proxy version present in target_version.txt.
+
+.PARAMETER TargetVersion
+The replacement version. Used in its entirety, so don't exclude parts of the version definition.
+#>
+[cmdletbinding(SupportsShouldProcess=$True)]
+param(
+   [Parameter(mandatory=$true)] [string] $TargetVersion
+)
+
+$versionFile = Join-Path $PSScriptRoot "target_version.txt"
+$existingVersionText = Get-Content -Raw -Path $versionFile
+$existingVersion = $existingVersionText.Trim()
+
+if ($PSCmdLet.ShouldProcess($versionFile)){
+   Write-Host "Replacing version `"$existingVersion`" with version `"$TargetVersion`" in $versionFile."
+   Set-Content -Path $versionFile -Value "$TargetVersion`n"   
+}
+else {
+   Write-Host "Would replace version `"$existingVersion`" with version `"$TargetVersion`" in $versionFile."
+}
+
+

eng/common/testproxy/test-proxy-docker.yml

@@ -10,6 +10,15 @@ steps:
     displayName: 'Language Specific Certificate Trust'
     condition: and(succeeded(), ${{ parameters.condition }})
 
+  - task: PowerShell@2
+    displayName: 'Override proxy version if necessary'
+    condition: and(succeeded(), ${{ parameters.condition }}, ne('${{ parameters.targetVersion }}', ''))
+    inputs:
+      targetType: filePath
+      filePath: '${{ parameters.templateRoot }}/eng/common/testproxy/override-proxy-version.ps1'
+      arguments: '-TargetVersion "${{ parameters.targetVersion }}"'
+      pwsh: true
+
   - pwsh: |
       docker info
     displayName: 'Dump active docker information'

eng/common/testproxy/test-proxy-tool.yml

@@ -11,14 +11,17 @@ steps:
     displayName: 'Language Specific Certificate Trust'
     condition: and(succeeded(), ${{ parameters.condition }})
 
+  - task: PowerShell@2
+    displayName: 'Override proxy version if necessary'
+    condition: and(succeeded(), ${{ parameters.condition }}, ne('${{ parameters.targetVersion }}', ''))
+    inputs:
+      targetType: filePath
+      filePath: '${{ parameters.templateRoot }}/eng/common/testproxy/override-proxy-version.ps1'
+      arguments: '-TargetVersion "${{ parameters.targetVersion }}"'
+      pwsh: true
+
   - pwsh: |
       $version = $(Get-Content "${{ parameters.templateRoot }}/eng/common/testproxy/target_version.txt" -Raw).Trim()
-      $overrideVersion = "${{ parameters.targetVersion }}"
-
-      if($overrideVersion) {
-        Write-Host "Overriding default target proxy version of '$version' with override $overrideVersion."
-        $version = $overrideVersion
-      }
 
       dotnet tool install azure.sdk.tools.testproxy `
         --tool-path $(Build.BinariesDirectory)/test-proxy `