Skip to content

Commit

Permalink
Update CODEOWNERS paths: fix invalid paths
Browse files Browse the repository at this point in the history
As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240
  • Loading branch information
Konrad Jamrozik authored Feb 10, 2023
1 parent 5ac3f00 commit 9b265f3
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
# Instructions for CODEOWNERS file format and automatic build failure notifications:
# https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners

################
# Automation
################

# Git Hub integration and bot rules
/.github/ @jsquire @rickwinter @ronniegeraghty

###########
# SDK
###########

# Catch all for non-code project files and unowned files | folders
* @rickwinter @ahsonkhan @antkmsft @vhvb1989 @gearama @LarryOsterman
/** @rickwinter @ahsonkhan @antkmsft @vhvb1989 @gearama @LarryOsterman
/sdk/ @rickwinter @ahsonkhan @antkmsft @vhvb1989 @gearama @LarryOsterman

# Samples
Expand Down Expand Up @@ -41,9 +34,14 @@
# PRLabel: %EngSys
/sdk/template/ @danieljurek @weshaggard

################
# Automation
################

# Git Hub integration and bot rules
/.github/ @jsquire @rickwinter @ronniegeraghty

###########
# Eng Sys
###########
/eng/ @danieljurek @weshaggard @benbp
/**/ci.yml @danieljurek
/**/tests.yml @danieljurek

0 comments on commit 9b265f3

Please sign in to comment.