Fixed memory leak in curl (#3995)

* Fixed memory leak in curl * fixed documentation in unique_handle.hpp
Azure · Oct 5, 2022 · 895a1f9 · 895a1f9
1 parent dd2d050
commit 895a1f9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/sdk/core/azure-core/inc/azure/core/internal/unique_handle.hpp b/sdk/core/azure-core/inc/azure/core/internal/unique_handle.hpp
@@ -15,7 +15,7 @@ namespace Azure { namespace Core { namespace _internal {
    *
    *  template <> struct UniqueHandleHelper<CURL>
    *  {
-   *    using type = BasicUniqueHandle<CURL, curl_free>;
+   *    using type = BasicUniqueHandle<CURL, curl_easy_cleanup>;
    *  };
    *
    * Note that for some types (HINTERNET for example), the helper needs to be a bit more

diff --git a/sdk/core/azure-core/src/http/curl/curl_connection_private.hpp b/sdk/core/azure-core/src/http/curl/curl_connection_private.hpp
@@ -40,9 +40,7 @@ namespace Azure { namespace Core {
      */
     template <> struct UniqueHandleHelper<CURL>
     {
-      static void FreeHandle(CURL* obj) { curl_free(obj); }
-
-      using type = BasicUniqueHandle<CURL, FreeHandle>;
+      using type = BasicUniqueHandle<CURL, curl_easy_cleanup>;
     };
   } // namespace _internal
 

diff --git a/sdk/core/ci.yml b/sdk/core/ci.yml
@@ -41,7 +41,7 @@ stages:
       LiveTestCtestRegex: azure-core.|json-test
       LiveTestTimeoutInMinutes: 90 # default is 60 min. We need a little longer on worst case for Win+jsonTests
       LineCoverageTarget: 93
-      BranchCoverageTarget: 55
+      BranchCoverageTarget: 50
       PreTestSteps:
         - pwsh: |
             docker build -t squid-local $(Build.SourcesDirectory)/sdk/core/azure-core/test/ut/proxy_tests/localproxy