Skip to content

Commit

Permalink
Added vcpkg args to handle openssl variants
Browse files Browse the repository at this point in the history
  • Loading branch information
LarryOsterman committed Oct 24, 2022
1 parent b2e60c3 commit 81f074e
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 3 deletions.
4 changes: 4 additions & 0 deletions eng/pipelines/templates/jobs/ci.tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ jobs:
value: ""
- name: CmakeArgs
value: ""
- name: VcpkgArgs
value: ""
# Apply to all services running public pipeline
- name: AZURE_TEST_MODE
value: "PLAYBACK"
Expand Down Expand Up @@ -142,6 +144,7 @@ jobs:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
GenerateArgs: "$(CmakeArgs)"
BuildArgs: "$(BuildArgs)"
VcpkgArgs: "$(VcpkgArgs)"
Env: "$(CmakeEnvArg)"

- ${{ parameters.PreTestSteps }}
Expand Down Expand Up @@ -223,6 +226,7 @@ jobs:
-OsVMImage '$(OSVmImage)'
-CmakeEnvArg '$(CmakeEnvArg)'
-BuildArgs '$(BuildArgs)'
-VcpkgArgs '$(VcpkgArgs)'
-Job '$(Agent.JobName)'
-BuildReason '$(Build.Reason)'
-SourceBranch '$(Build.SourceBranch)'
Expand Down
2 changes: 2 additions & 0 deletions eng/pipelines/templates/jobs/live.tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ jobs:
CMOCKA_MESSAGE_OUTPUT: "xml"
AZURE_ENABLE_STATIC_ANALYSIS: 1
BuildArgs: ""
VcpkgArgs: ""
WindowsCtestConfig: ""
CmakeEnvArg: ""
CmakeArgs: ""
Expand Down Expand Up @@ -119,6 +120,7 @@ jobs:
parameters:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
GenerateArgs: $(CmakeArgs)
VcpkgArgs: "$(VcpkgArgs)"
BuildArgs: "$(BuildArgs)"
Env: "$(CmakeEnvArg)"

Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/templates/stages/platform-matrix.json
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
},
"openssl_111n": {
"CMAKE_BUILD_TYPE": "Release",
"BuildArgs": " -DVCPKG_MANIFEST_MODE=ON -DVCPKG_OVERLAY_PORTS=$(Build.SourcesDirectory)/vcpkg-custom-ports -DVCPKG_MANIFEST_DIR=$(Build.SourcesDirectory)"
"VcpkgArgs": " -DVCPKG_MANIFEST_MODE=ON -DVCPKG_OVERLAY_PORTS=$(Build.SourcesDirectory)/vcpkg-custom-ports -DVCPKG_MANIFEST_DIR=$(Build.SourcesDirectory)"
}
}
}
Expand Down
5 changes: 3 additions & 2 deletions eng/pipelines/templates/steps/cmake-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ parameters:
GenerateArgs: ''
Build: true
BuildArgs: ''
VcpkgArgs: ''
ServiceDirectory: ''


Expand All @@ -23,13 +24,13 @@ steps:
# Core should build all cmake tagets
- ${{ if and(eq(parameters.Build, true), eq(parameters.ServiceDirectory, 'core')) }}:
- script: cmake --build . ${{ parameters.BuildArgs }}
- script: cmake --build . ${{ parameters.VcpkgArgs }} ${{ parameters.BuildArgs }}
workingDirectory: build
displayName: cmake build All

# Non-core services define the list of targets to build
- ${{ if and(eq(parameters.Build, true) , ne(parameters.ServiceDirectory, 'core')) }}:
- pwsh: cmake --build . ${{ parameters.BuildArgs }} --target (Get-Content ${{ parameters.ServiceDirectory }}-targets-build.txt)
- pwsh: cmake --build . ${{ parameters.VcpkgArgs }} ${{ parameters.BuildArgs }} --target (Get-Content ${{ parameters.ServiceDirectory }}-targets-build.txt)
workingDirectory: build
displayName: cmake build Targets

3 changes: 3 additions & 0 deletions eng/scripts/Get-BinarySizes.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ param(
[Parameter()]
[string] $BuildArgs,

[Parameter()]
[string] $VcpkgArgs

[Parameter()]
[string] $Job,

Expand Down

0 comments on commit 81f074e

Please sign in to comment.