Options Http Enum add to Core (#5246)

* Options Http Enum add * spaces
Azure · Jan 10, 2024 · 7eeb609 · 7eeb609
1 parent 1a6b614
commit 7eeb609
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 1 deletion.
diff --git a/sdk/core/azure-core/CHANGELOG.md b/sdk/core/azure-core/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## 1.11.0-beta.3 (Unreleased)
 
+- Added 'OPTIONS' HTTP method to `Azure::Core::Http::HttpMethod` enum.
+
 ### Features Added
 
 ### Breaking Changes

diff --git a/sdk/core/azure-core/inc/azure/core/http/http.hpp b/sdk/core/azure-core/inc/azure/core/http/http.hpp
@@ -159,6 +159,12 @@ namespace Azure { namespace Core { namespace Http {
      */
     AZ_CORE_DLLEXPORT const static HttpMethod Patch;
 
+    /**
+     * @brief The representation of an `OPTIONS` HTTP method based on [RFC 2616]
+     * (https://datatracker.ietf.org/doc/html/rfc2616).
+     */
+    AZ_CORE_DLLEXPORT const static HttpMethod Options;
+
   private:
     std::string m_value;
   }; // extensible enum HttpMethod

diff --git a/sdk/core/azure-core/src/http/http.cpp b/sdk/core/azure-core/src/http/http.cpp
@@ -26,6 +26,7 @@ const HttpMethod HttpMethod::Post("POST");
 const HttpMethod HttpMethod::Put("PUT");
 const HttpMethod HttpMethod::Delete("DELETE");
 const HttpMethod HttpMethod::Patch("PATCH");
+const HttpMethod HttpMethod::Options("OPTIONS");
 
 namespace {
 bool IsInvalidHeaderNameChar(char c)

diff --git a/sdk/core/azure-core/test/libcurl-stress-test/README.md b/sdk/core/azure-core/test/libcurl-stress-test/README.md
@@ -19,7 +19,7 @@ Where namespace will be created if missing , search directory can be any folder
 
 ATM the docker image is build by hand and hard-coded in the chart to simplify matters.  
 
-To build the image run "docker build -t <acr>/azuresdkforcpp/curlstress:v8  --build-arg targetTest=azure-core-libcurl-stress-test --build-arg build=on  ."
+To build the image run "docker build -t <acr>/azuresdkforcpp/curlstress:v8  --build-arg targetTest=azure-core-libcurl-stress-test --build-arg build=on  -f .\Dockerfile .\..\..\..\..\..\"
 
 To push to mcr : "docker push <acr>/azuresdkforcpp/curlstress:v8"
 Obviously after logging in to the acr "az acr login -n <acr>"