Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format #2504

Merged
merged 5 commits into from
Feb 17, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Feb 15, 2023

Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format.

This discussion explains why we chose given vmImage format:

Mike Harder: 1ES Hosted Pool image name changes
posted in Azure SDK / Engineering System 🛠️ at Wednesday, February 15, 2023 12:10 PM

For further context, please see:

WARNING

The code is still using non-compliant azsdk-pool-mms-win-2019-general pool (and also here) which cannot be updated at this time. As a consequence, the build may fail once the images will be force-migrated to compliant ones on March 1st.

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Feb 15, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Feb 15, 2023
eng/common/pipelines/templates/jobs/perf.yml Outdated Show resolved Hide resolved
@konrad-jamrozik konrad-jamrozik force-pushed the users/kojamroz/update_pools_to_compliant branch from 5f2c3c8 to 38d4cf1 Compare February 17, 2023 00:49
@konrad-jamrozik konrad-jamrozik changed the title Update images MMS2019 and MMS2022 to their compliant equivalents Migrate Windows pools and images to compliant 2022 Feb 17, 2023
@konrad-jamrozik konrad-jamrozik changed the title Migrate Windows pools and images to compliant 2022 Where applicable, migrate pools to azsdk-pool-mms-win-2022-general pool and rename images to the windows-2019 and windows-2022 format. Feb 17, 2023
@konrad-jamrozik konrad-jamrozik changed the title Where applicable, migrate pools to azsdk-pool-mms-win-2022-general pool and rename images to the windows-2019 and windows-2022 format. Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general pool and rename vmImage to the windows-2019 and windows-2022 format. Feb 17, 2023
@konrad-jamrozik konrad-jamrozik changed the title Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general pool and rename vmImage to the windows-2019 and windows-2022 format. Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-2019 and windows-2022 format. Feb 17, 2023
@konrad-jamrozik konrad-jamrozik changed the title Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-2019 and windows-2022 format. Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-2019 and windows-2022 format Feb 17, 2023
@konrad-jamrozik konrad-jamrozik changed the title Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-2019 and windows-2022 format Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format. Feb 17, 2023
@konrad-jamrozik konrad-jamrozik changed the title Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format. Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format Feb 17, 2023
@konrad-jamrozik konrad-jamrozik merged commit 437038d into main Feb 17, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/update_pools_to_compliant branch February 17, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants