Address right hand const on API source files #1516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danewalton
requested review from
antkmsft,
CIPop,
ericwolz,
ewertons,
hihigupt,
jspaith,
momuno,
RickWinter and
vhvb1989
as code owners
antkmsft
approved these changes
Nov 13, 2020
sdk/src/azure/core/az_context.c
Outdated
| az_context const* const parent, | ||
| void const* const key, | ||
| void const* const value) | ||
| az_context const* parent, |
There was a problem hiding this comment.
I think you need to reformat the code (Ctrl+K+D in VS) - this specific instance will likely become single-line.
|
Did you try a clean revert of #1261? If that works, can we do that instead? git revert 57236783862b85660559478c37a7ac92a6b97472This change looks identical to that one, so should be simple. |
|
@ahsonkhan #1517 |
|
Closed in favor of #1517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1512