Updates for cmake modules #1267
Conversation
| find_package(cmocka CONFIG REQUIRED) | ||
|
|
||
| enable_testing() | ||
| include(CTest) | ||
|
|
||
| if (CMAKE_CROSSCOMPILING) |
There was a problem hiding this comment.
not dead, but not really used by us.
This code is to use wine emulator on Windows for CYGIN or MINGW.
We don't have any documentation about how work with any of these (not even know if someone has tried).
Sp far, for Windows, we only use MSVC
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # SPDX-License-Identifier: MIT |
There was a problem hiding this comment.
Nice catch. Any other files in the repo that might be missing this license header?
There was a problem hiding this comment.
There is a cmake module in the form of a txt file inside eng/ folder.
This was created before using cmake modules. It can be updated later to be another cmake module.
Maybe yml files from eng/ should contain license as well
| @@ -1,39 +1,15 @@ | |||
| # | |||
| # Copyright (c) 2007 Daniel Gollub <[email protected]> | |||
There was a problem hiding this comment.
Has CMocka been entered into the component governance site. Is this copyright usage approved?
There was a problem hiding this comment.
will add the Notice and cgmanifest on #1213
This PR is just to update the licenses in cmake modules. Once this is merged, I will update the other PR to have all the Notices
cmake-modules/CodeCoverage.cmake
Outdated
| @@ -124,6 +125,22 @@ if(NOT GCOV_PATH) | |||
| message(FATAL_ERROR "gcov not found! Aborting...") | |||
| endif() # NOT GCOV_PATH | |||
|
|
|||
| ####### C++ specific. Commenting from original or it fails for our gcc build for C99 | |||
There was a problem hiding this comment.
I recommended keeping it because it makes seeing the diff between our version and the source, easier, which helps validate and keep things in sync. Currently, we have no other difference other than this.
Up to you.
See the diff now: https://www.diffchecker.com/qrXQRqf5
There was a problem hiding this comment.
Avoiding commented out code is ideal. Commented code tends to bit rot quickly.
As for the diff, Either way it shows up as diff. In one view all the lines are removed and in the other they are all commented.
Co-authored-by: Ahson Khan <[email protected]>
| # Modifed version from https://github.com/xbmc/libssh/blob/667fb5f9a9c96f210583dbfb11755c43250c5e55/cmake/Modules/AddCMockaTest.cmake | ||
| #.rst: | ||
| # AddTestCMocka |
There was a problem hiding this comment.
Why did we rename the file originally? Keep it matching the source:
Rename the file:
AddTestCMocka.cmake -> AddCMockaTest.cmake
There was a problem hiding this comment.
there's no difference. Can we keep this name so we don't make more changes to more files importing this module?
We are already mentioning this is a modified version and nothing stop us from using a different name. Isn't this a nit?
Co-authored-by: Ahson Khan <[email protected]>
…e-sdk-for-c into sync-code-cov-cmake-module
Note: Notice and cgmanifest file to be updated in #1213