-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync eng/common directory with azure-sdk-tools for PR 870 #301
Merged
sima-zhu
merged 3 commits into
Azure:master
from
azure-sdk:sync-eng-common-pr_temp_link-870
Aug 20, 2020
Merged
Sync eng/common directory with azure-sdk-tools for PR 870 #301
sima-zhu
merged 3 commits into
Azure:master
from
azure-sdk:sync-eng-common-pr_temp_link-870
Aug 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
force-pushed
the
sync-eng-common-pr_temp_link-870
branch
from
August 19, 2020 16:42
57cbb81
to
4e79032
Compare
azure-sdk
force-pushed
the
sync-eng-common-pr_temp_link-870
branch
from
August 19, 2020 16:59
4e79032
to
cfd2e0c
Compare
sima-zhu
approved these changes
Aug 19, 2020
weshaggard
reviewed
Aug 20, 2020
@@ -10,14 +10,3 @@ Any updates to files in the `eng/common` directory should be made in the [azure- | |||
All changes made will cause a PR to created in all subscribed azure-sdk language repos which will blindly replace all contents of | |||
the `eng/common` directory in that repo. For that reason do **NOT** make changes to files in this directory in the individual azure-sdk | |||
languages repos as they will be overwritten the next time an update is taken from the common azure-sdk-tools repo. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chidozieononiwu @sima-zhu this looks like a case were we have undone some changes that we shouldn't have undone.
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-android
that referenced
this pull request
Sep 16, 2020
* move headers to inc/_internal * moving headers to internal * moving az_span_is_valid to internal api * moving az_mut_span_is_valid to internal api * moving az_base64 to core private * fix include guards * use flat structure on src for private * use flat struct for internal and interface for it * use install interface to include az and az_internal Co-Authored-By: Charlie Barto <[email protected]> * fix including directories for az_core_internal * sort includes * remove action and contract * update headers * fix previous merge Co-authored-by: Charlie Barto <[email protected]>
azure-sdk
pushed a commit
that referenced
this pull request
Sep 26, 2020
anuchandy
pushed a commit
to anuchandy/azure-sdk-for-android-1
that referenced
this pull request
Mar 26, 2021
…Azure/azure-sdk-tools#870 (Azure#301) Co-authored-by: Sima Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR 870