Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSI/ClientCert support in SignalR service #9987

Merged
merged 3 commits into from
Jul 8, 2020

Conversation

juniwang
Copy link
Contributor

  • Adding MSI support in SignalR Service
  • Allow customer to enable client certificate for SignalR data plane auth.
  • Adding new api-version 2020-07-01-preview

More comments and context can be found at #9908.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 29, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 29, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 29, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 29, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from ce9cff5 with merge commit 06ce742. SDK Automation 13.0.17.20200619.4
  • ⚠️sdk/signalr/mgmt-v2018_03_01_preview [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_03_01_preview/src/main/java/com/microsoft/azure/management/signalr/v2018_03_01_preview/implementation/SignalRManager.java:[82,50] incompatible types: com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRServiceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_03_01_preview/src/main/java/com/microsoft/azure/management/signalr/v2018_03_01_preview/implementation/SignalRManager.java:[92,46] incompatible types: com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRServiceManager
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-signalrservice: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_03_01_preview/src/main/java/com/microsoft/azure/management/signalr/v2018_03_01_preview/implementation/SignalRManager.java:[82,50] incompatible types: com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRServiceManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_03_01_preview/src/main/java/com/microsoft/azure/management/signalr/v2018_03_01_preview/implementation/SignalRManager.java:[92,46] incompatible types: com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_03_01_preview.implementation.SignalRServiceManager
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ⚠️sdk/signalr/mgmt-v2018_10_01 [View full logs]  [Release SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/signalr/v2018_10_01/implementation/SignalRManager.java:[84,50] incompatible types: com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRServiceManager
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/signalr/v2018_10_01/implementation/SignalRManager.java:[94,46] incompatible types: com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRServiceManager
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/signalr/v2018_10_01/implementation/SignalRManager.java:[104,42] incompatible types: com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRServiceManager
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-signalrservice: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/signalr/v2018_10_01/implementation/SignalRManager.java:[84,50] incompatible types: com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRServiceManager
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/signalr/v2018_10_01/implementation/SignalRManager.java:[94,46] incompatible types: com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRServiceManager
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/signalr/v2018_10_01/implementation/SignalRManager.java:[104,42] incompatible types: com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2018_10_01.implementation.SignalRServiceManager
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      • ⚠️sdk/signalr/mgmt-v2020_05_01 [View full logs]  [Release SDK Changes]
          [mvn] [ERROR] COMPILATION ERROR : 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/signalr/v2020_05_01/implementation/SignalRManager.java:[88,50] incompatible types: com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRServiceManager
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/signalr/v2020_05_01/implementation/SignalRManager.java:[98,46] incompatible types: com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRServiceManager
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/signalr/v2020_05_01/implementation/SignalRManager.java:[108,96] incompatible types: com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRServiceManager
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/signalr/v2020_05_01/implementation/SignalRManager.java:[118,84] incompatible types: com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRServiceManager
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/signalr/v2020_05_01/implementation/SignalRManager.java:[128,42] incompatible types: com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRServiceManager
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-signalrservice: Compilation failure: Compilation failure: 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/signalr/v2020_05_01/implementation/SignalRManager.java:[88,50] incompatible types: com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRServiceManager
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/signalr/v2020_05_01/implementation/SignalRManager.java:[98,46] incompatible types: com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRServiceManager
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/signalr/v2020_05_01/implementation/SignalRManager.java:[108,96] incompatible types: com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRServiceManager
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/signalr/v2020_05_01/implementation/SignalRManager.java:[118,84] incompatible types: com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRServiceManager
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/signalr/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/signalr/v2020_05_01/implementation/SignalRManager.java:[128,42] incompatible types: com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRManager cannot be converted to com.microsoft.azure.management.signalr.v2020_05_01.implementation.SignalRServiceManager
          [mvn] [ERROR] -> [Help 1]
          [mvn] [ERROR] 
          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [mvn] [ERROR] 
          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
        • ️✔️sdk/signalr/mgmt-v2020_07_01_preview [View full logs]  [Release SDK Changes]

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jun 29, 2020

        azure-sdk-for-python - Release

        - Breaking Change detected in SDK

        ⚠️ warning [Logs] [Expand Details]
        • ⚠️ Generate from ce9cff5 with merge commit 06ce742. SDK Automation 13.0.17.20200619.4
        • ⚠️azure-mgmt-signalr [View full logs]  [Release SDK Changes] Breaking Change Detected
          [build_conf] INFO:packaging_tools:Building template azure-mgmt-signalr
          [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
          [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
          [build_conf] INFO:packaging_tools:Template done azure-mgmt-signalr
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)
          [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
          [ChangeLog] Size of delta 10.759% size of original (original: 23014 chars, delta: 2476 chars)
          [ChangeLog] **Features**
          [ChangeLog] 
          [ChangeLog]   - Model UpstreamTemplate has a new parameter auth
          [ChangeLog]   - Model SignalRResource has a new parameter identity
          [ChangeLog]   - Model SignalRResource has a new parameter tls
          [ChangeLog] 
          [ChangeLog] **Breaking changes**
          [ChangeLog] 
          [ChangeLog]   - Model SignalRCreateOrUpdateProperties no longer has parameter host_name_prefix
          [ChangeLog]   - Model SignalRResource no longer has parameter host_name_prefix

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jun 29, 2020

        azure-sdk-for-net - Release

        failed [Logs] [Expand Details]
        • Generate from ce9cff5 with merge commit 06ce742. SDK Automation 13.0.17.20200619.4
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
          [AutoRest] realpath(): Permission denied
        • Microsoft.Azure.Management.SignalR [View full logs]  [Release SDK Changes]
            Failed to create the package Microsoft.Azure.Management.SignalR.
            Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=signalr /v:n /p:SkipTests=true , {} 

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jun 29, 2020

          Trenton Generation - Release

          No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jun 29, 2020

          azure-sdk-for-js - Release

          ️✔️ succeeded [Logs] [Expand Details]
          • ️✔️ Generate from ce9cff5 with merge commit 06ce742. SDK Automation 13.0.17.20200619.4
          • ️✔️@azure/arm-signalr [View full logs]  [Release SDK Changes]
            Only show 100 items here, please refer to log for details.
            [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
            [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
            [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
            [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
            [npmPack] loaded rollup.config.js with warnings
            [npmPack] (!) Unused external imports
            [npmPack] default imported from external module 'rollup' but never used
            [npmPack] 
            [npmPack] ./esm/signalRManagementClient.js → ./dist/arm-signalr.js...
            [npmPack] created ./dist/arm-signalr.js in 353ms
            [npmPack] npm notice 
            [npmPack] npm notice package: @azure/[email protected]
            [npmPack] npm notice === Tarball Contents === 
            [npmPack] npm notice 90.9kB  dist/arm-signalr.js                                         
            [npmPack] npm notice 30.3kB  dist/arm-signalr.min.js                                     
            [npmPack] npm notice 345B    esm/models/index.js                                         
            [npmPack] npm notice 534B    esm/operations/index.js                                     
            [npmPack] npm notice 34.8kB  esm/models/mappers.js                                       
            [npmPack] npm notice 2.2kB   esm/operations/operations.js                                
            [npmPack] npm notice 564B    esm/models/operationsMappers.js                             
            [npmPack] npm notice 2.1kB   esm/models/parameters.js                                    
            [npmPack] npm notice 983B    rollup.config.js                                            
            [npmPack] npm notice 17.9kB  esm/operations/signalR.js                                   
            [npmPack] npm notice 2.0kB   esm/signalRManagementClient.js                              
            [npmPack] npm notice 2.7kB   esm/signalRManagementClientContext.js                       
            [npmPack] npm notice 964B    esm/models/signalRMappers.js                                
            [npmPack] npm notice 6.4kB   esm/operations/signalRPrivateEndpointConnections.js         
            [npmPack] npm notice 885B    esm/models/signalRPrivateEndpointConnectionsMappers.js      
            [npmPack] npm notice 2.8kB   esm/operations/signalRPrivateLinkResources.js               
            [npmPack] npm notice 904B    esm/models/signalRPrivateLinkResourcesMappers.js            
            [npmPack] npm notice 2.4kB   esm/operations/usages.js                                    
            [npmPack] npm notice 473B    esm/models/usagesMappers.js                                 
            [npmPack] npm notice 1.6kB   package.json                                                
            [npmPack] npm notice 457B    tsconfig.json                                               
            [npmPack] npm notice 181.6kB dist/arm-signalr.js.map                                     
            [npmPack] npm notice 26.1kB  dist/arm-signalr.min.js.map                                 
            [npmPack] npm notice 13.0kB  esm/models/index.d.ts.map                                   
            [npmPack] npm notice 225B    esm/operations/index.d.ts.map                               
            [npmPack] npm notice 126B    esm/models/index.js.map                                     
            [npmPack] npm notice 240B    esm/operations/index.js.map                                 
            [npmPack] npm notice 2.2kB   esm/models/mappers.d.ts.map                                 
            [npmPack] npm notice 19.7kB  esm/models/mappers.js.map                                   
            [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                          
            [npmPack] npm notice 1.4kB   esm/operations/operations.js.map                            
            [npmPack] npm notice 287B    esm/models/operationsMappers.d.ts.map                       
            [npmPack] npm notice 300B    esm/models/operationsMappers.js.map                         
            [npmPack] npm notice 541B    esm/models/parameters.d.ts.map                              
            [npmPack] npm notice 1.5kB   esm/models/parameters.js.map                                
            [npmPack] npm notice 4.5kB   esm/operations/signalR.d.ts.map                             
            [npmPack] npm notice 8.7kB   esm/operations/signalR.js.map                               
            [npmPack] npm notice 773B    esm/signalRManagementClient.d.ts.map                        
            [npmPack] npm notice 957B    esm/signalRManagementClient.js.map                          
            [npmPack] npm notice 513B    esm/signalRManagementClientContext.d.ts.map                 
            [npmPack] npm notice 1.4kB   esm/signalRManagementClientContext.js.map                   
            [npmPack] npm notice 504B    esm/models/signalRMappers.d.ts.map                          
            [npmPack] npm notice 517B    esm/models/signalRMappers.js.map                            
            [npmPack] npm notice 1.8kB   esm/operations/signalRPrivateEndpointConnections.d.ts.map   
            [npmPack] npm notice 2.8kB   esm/operations/signalRPrivateEndpointConnections.js.map     
            [npmPack] npm notice 494B    esm/models/signalRPrivateEndpointConnectionsMappers.d.ts.map
            [npmPack] npm notice 507B    esm/models/signalRPrivateEndpointConnectionsMappers.js.map  
            [npmPack] npm notice 1.2kB   esm/operations/signalRPrivateLinkResources.d.ts.map         
            [npmPack] npm notice 1.6kB   esm/operations/signalRPrivateLinkResources.js.map           
            [npmPack] npm notice 495B    esm/models/signalRPrivateLinkResourcesMappers.d.ts.map      
            [npmPack] npm notice 508B    esm/models/signalRPrivateLinkResourcesMappers.js.map        
            [npmPack] npm notice 1.1kB   esm/operations/usages.d.ts.map                              
            [npmPack] npm notice 1.5kB   esm/operations/usages.js.map                                
            [npmPack] npm notice 220B    esm/models/usagesMappers.d.ts.map                           
            [npmPack] npm notice 233B    esm/models/usagesMappers.js.map                             
            [npmPack] npm notice 3.1kB   README.md                                                   
            [npmPack] npm notice 38.5kB  esm/models/index.d.ts                                       
            [npmPack] npm notice 218B    esm/operations/index.d.ts                                   
            [npmPack] npm notice 36.9kB  src/models/index.ts                                         
            [npmPack] npm notice 502B    src/operations/index.ts                                     
            [npmPack] npm notice 2.8kB   esm/models/mappers.d.ts                                     
            [npmPack] npm notice 27.8kB  src/models/mappers.ts                                       
            [npmPack] npm notice 2.1kB   esm/operations/operations.d.ts                              
            [npmPack] npm notice 4.1kB   src/operations/operations.ts                                
            [npmPack] npm notice 254B    esm/models/operationsMappers.d.ts                           
            [npmPack] npm notice 540B    src/models/operationsMappers.ts                             
            [npmPack] npm notice 624B    esm/models/parameters.d.ts                                  
            [npmPack] npm notice 2.1kB   src/models/parameters.ts                                    
            [npmPack] npm notice 14.1kB  esm/operations/signalR.d.ts                                 
            [npmPack] npm notice 26.3kB  src/operations/signalR.ts                                   
            [npmPack] npm notice 1.4kB   esm/signalRManagementClient.d.ts                            
            [npmPack] npm notice 2.0kB   src/signalRManagementClient.ts                              
            [npmPack] npm notice 927B    esm/signalRManagementClientContext.d.ts                     
            [npmPack] npm notice 2.4kB   src/signalRManagementClientContext.ts                       
            [npmPack] npm notice 654B    esm/models/signalRMappers.d.ts                              
            [npmPack] npm notice 981B    src/models/signalRMappers.ts                                
            [npmPack] npm notice 6.4kB   esm/operations/signalRPrivateEndpointConnections.d.ts       
            [npmPack] npm notice 10.6kB  src/operations/signalRPrivateEndpointConnections.ts         
            [npmPack] npm notice 575B    esm/models/signalRPrivateEndpointConnectionsMappers.d.ts    
            [npmPack] npm notice 866B    src/models/signalRPrivateEndpointConnectionsMappers.ts      
            [npmPack] npm notice 3.1kB   esm/operations/signalRPrivateLinkResources.d.ts             
            [npmPack] npm notice 5.6kB   src/operations/signalRPrivateLinkResources.ts               
            [npmPack] npm notice 594B    esm/models/signalRPrivateLinkResourcesMappers.d.ts          
            [npmPack] npm notice 893B    src/models/signalRPrivateLinkResourcesMappers.ts            
            [npmPack] npm notice 2.2kB   esm/operations/usages.d.ts                                  
            [npmPack] npm notice 4.4kB   src/operations/usages.ts                                    
            [npmPack] npm notice 163B    esm/models/usagesMappers.d.ts                               

          @yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 2, 2020
          @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 8, 2020
          Copy link
          Member

          @majastrz majastrz left a comment

          Choose a reason for hiding this comment

          The reason will be displayed to describe this comment to others. Learn more.

          Signed off from ARM side.

          @yungezz
          Copy link
          Member

          yungezz commented Jul 8, 2020

          hi @juniwang, could you pls help to fix CI failure? then the PR is ready to go

          @juniwang
          Copy link
          Contributor Author

          juniwang commented Jul 8, 2020

          I believe the failure was due to the github outage last week, excerpt logs:

            '##[error]2020-06-29T10:14:33.094Z: [Azure/azure-sdk-for-net]SDK Repository Error: {',
            '##[error]2020-06-29T10:14:33.094Z: [Azure/azure-sdk-for-net]  "name": "HttpError",',
            '##[error]2020-06-29T10:14:33.094Z: [Azure/azure-sdk-for-net]  "status": 502,',
          

          I tried a few times to send out PR because of the outage. Could you plz re-run the pipeline?

          @yungezz
          Copy link
          Member

          yungezz commented Jul 8, 2020

          /azp run sdk automation

          @azure-pipelines
          Copy link

          No pipelines are associated with this pull request.

          @yungezz yungezz closed this Jul 8, 2020
          @yungezz yungezz reopened this Jul 8, 2020
          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @juniwang
          Copy link
          Contributor Author

          juniwang commented Jul 8, 2020

          The failure about .Net SDK is related to unit tests which failes because of a deleted property. Will fix the UT later while release .Net SDK

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jul 8, 2020

          azure-sdk-for-python-track2 - Release

          No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

          @yungezz yungezz merged commit 06ce742 into Azure:master Jul 8, 2020
          00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
          Labels
          ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
          Projects
          None yet
          Development

          Successfully merging this pull request may close these issues.

          3 participants