[AzureSearch] remove skillset count entirely for now #9968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadrefke
requested review from
arv100kri,
bleroy and
brjohnstmsft
as code owners
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
|
The new version is missing a property found in the old version. Was 'skillsetCount' renamed or removed? New: Azure.Search/preview/2020-06-30/searchservice.json#L8461:7 Old: Azure.Search/preview/2020-06-30/searchservice.json#L8461:7 |
|
The new version is missing a property found in the old version. Was 'skillsetCount' renamed or removed? New: Azure.Search/preview/2020-06-30/searchservice.json#L8461:7 Old: Azure.Search/preview/2020-06-30/searchservice.json#L8461:7 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can one of the admins verify this patch? |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
brjohnstmsft
approved these changes
Jun 25, 2020
heaths
approved these changes
Jun 25, 2020
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
heaths
added a commit
to heaths/azure-sdk-for-net
that referenced
this pull request
Jun 26, 2020
Required change after Azure/azure-rest-api-specs#9968. The live test was failing because we *sometimes* exhausted our free allocation of text translations.
heaths
added a commit
to Azure/azure-sdk-for-net
that referenced
this pull request
Jun 26, 2020
* Change Search version to use 2020-06-30 Fixes #10873 to use a fixed version of the latest swaggers for Search. * Update models and fix live tests Required change after Azure/azure-rest-api-specs#9968. The live test was failing because we *sometimes* exhausted our free allocation of text translations.
prmathur-microsoft
pushed a commit
to Azure/azure-sdk-for-net
that referenced
this pull request
Jul 8, 2020
* Change Search version to use 2020-06-30 Fixes #10873 to use a fixed version of the latest swaggers for Search. * Update models and fix live tests Required change after Azure/azure-rest-api-specs#9968. The live test was failing because we *sometimes* exhausted our free allocation of text translations.
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…e#9968) Co-authored-by: Austin Drefke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.