Frontdoor RP v05-01 to use WAF from RP 04-01 #9964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-js - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
|
|
Can one of the admins verify this patch? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
eschwabe
reviewed
Jun 25, 2020
MoustafaEid
requested review from
MikhailTryakhov,
anton-evseev and
v-shhatt
as code owners
|
Azure Pipelines successfully started running 1 pipeline(s). |
MoustafaEid
force-pushed
the
remove-waf-05-01
branch
from
82f7992 to
3efb454
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 25, 2020
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This change removes the support to link WAF policy. This feature isn't currently used, and we found that the NRP manifest hasn't been updated in production which hinders the generation for the SDK. We'll introduce this functionality again in the future once all the parts are ready. |
|
JAVA SDk check keeps timing out -- this is a known issue. |
|
If these APIs were never in your manifest then there is nothing to review from ARM side here. If they were please ensure you are following the deprecation process: https://armwiki.azurewebsites.net/api_contracts/APIDeprecationPolicy.html |
|
@pilor Thanks for looking into this. The manifest did not have the related parts -- does this mean we just need the SDK's team approval? |
Correct |
2 tasks
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* revert WAF to use 04-01 * remove json file from md * remove WAF files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.