-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #9958
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #9958
Conversation
[Staging] Swagger Validation Report
❌ |
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
Can one of the admins verify this patch? |
The breaking changes represent a mistake in existing documentation, these properties were always required. |
@zachraMSFT pls fix PrettierCheck error. Here's how: https://aka.ms/ci-fix |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
@leni-msft Updated to resolve the issue |
@zachraMSFT Per newest process, since there is breaking change to stable version, please follow Azure Breaking changes approval request form as defined at Breaking Change Process |
There is no breaking change. The API has not changed, the documentation was incorrect, and following the old version exactly would always give an error. |
@zachraMSFT please clarify the impact to customers if not modifying the swagger. And have you released any sdk for this version? |
The impact to customers is that if they submit a request without these required parameters today, they will get a 400 response because the swagger was not properly generated for this documentation. No, we have not released an sdk. There is no sdk support for the cost management/consumption apis |
…on stable/2019-10-01 (Azure#9958) * RI documentation updates * Parameter location * Missed a parameter * Fix enum formatting * remove new params to get healthy version * Add basic parameters * fix parameter format * Update examples * Fix trailing comma * Only simple parameters * Fix parameter declaration * Fix casing * trailing comma * Use parameters correctly * Fix input parameter * Update examples for fixed format * Remove unused definition * Fix parameter naming * Fix path template * Fix descriptions * Test resorting * Remove 5 year * Prettier fixes
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on PR review process.