Fixing migrate swagger issues #9949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't have permission to trigger SDK Automation. |
[Staging] Swagger Validation Report
❌ |
|
Can one of the admins verify this patch? |
Fixing prettier.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
fengzhou-msft
added
the
WaitForARMFeedback
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Fixing some more things.
pilor
suggested changes
Jul 2, 2020
| @@ -2209,9 +2202,6 @@ | |||
| } | |||
| } | |||
| }, | |||
| "x-ms-pageable": { | |||
There was a problem hiding this comment.
this API is pageable. ARM will return a nextLink if one of your regional endpoints doesn't respond in time or has a retryable error.
There was a problem hiding this comment.
applies to any collection GETs on tracked reosurces
There was a problem hiding this comment.
nextLinkName should be specified (and equal "nextLink") and the response in the subscription and resource group level collection GETs should return a nextLink property (the definition does not contain it right now). Your RP doesn't control whether ARM returns a nextLink here or not and the SDK should be set up to follow it if it is returned.
| @@ -2580,9 +2546,6 @@ | |||
| } | |||
| } | |||
| }, | |||
| "x-ms-pageable": { | |||
There was a problem hiding this comment.
why are you removing x-ms-pageable from your proxy resource collection GETs? You can keep this even if you never return a nextLink value. If your definition doesn't have a "nextLink" property "nextLinkName" can be null. https://github.com/Azure/autorest/blob/master/docs/extensions/readme.md#x-ms-pageable
pilor
added
ARMChangesRequested
Taking commenst.
pilor
suggested changes
Jul 9, 2020
| @@ -2209,9 +2202,6 @@ | |||
| } | |||
| } | |||
| }, | |||
| "x-ms-pageable": { | |||
There was a problem hiding this comment.
nextLinkName should be specified (and equal "nextLink") and the response in the subscription and resource group level collection GETs should return a nextLink property (the definition does not contain it right now). Your RP doesn't control whether ARM returns a nextLink here or not and the SDK should be set up to follow it if it is returned.
Taking comments
pilor
approved these changes
Jul 16, 2020
pilor
added
ARMSignedOff
fengzhou-msft
added
Approved-BreakingChange
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.