Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authenticate to AppInsights API #9939

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Authenticate to AppInsights API #9939

merged 2 commits into from
Jul 23, 2020

Conversation

divyajay
Copy link
Contributor

@divyajay divyajay commented Jun 23, 2020 •
edited
Loading

For just the data plane Direct path (v1 version), update the swagger definition to specify authentication against the API, instead of azure auth.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@divyajay
Authenticate to AppInsights API
d43de77 
For just the data plane Direct path (v1 version), update the swagger definition to specify authentication against the API, instead of azure auth.
@AutorestCI
Copy link

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 23, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail] 
 There are no breaking changes.
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
Posted by Swagger Pipeline | How to fix these errors?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

rloutlaw
rloutlaw approved these changes Jul 23, 2020
View reviewed changes
Copy link

@rloutlaw rloutlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed our Docs UI and REST processor code and the auth URL change should fix the Try-It issues w/ this service. I approve of this change.

@lmazuel lmazuel merged commit 2060df5 into Azure:master Jul 23, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 23, 2020 •
edited
Loading

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from f2bde03 with merge commit 2060df5. SDK Automation 13.0.17.20200619.4 
    [azure-applicationinsights-query][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-applicationinsights-query [View full logs]  [Release SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-applicationinsights-query
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-applicationinsights-query
[build_conf] INFO:packaging_tools:Template done azure-applicationinsights-query
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 23, 2020 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 23, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 23, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from f2bde03 with merge commit 2060df5. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/applicationinsights-query [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/applicationInsightsDataClient.js → ./dist/applicationinsights-query.js...
[npmPack] created ./dist/applicationinsights-query.js in 370ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 94.3kB  dist/applicationinsights-query.js                
[npmPack] npm notice 32.5kB  dist/applicationinsights-query.min.js            
[npmPack] npm notice 1.7kB   esm/applicationInsightsDataClient.js             
[npmPack] npm notice 1.8kB   esm/applicationInsightsDataClientContext.js      
[npmPack] npm notice 2.6kB   esm/operations/events.js                         
[npmPack] npm notice 1.2kB   esm/models/eventsMappers.js                      
[npmPack] npm notice 345B    esm/models/index.js                              
[npmPack] npm notice 457B    esm/operations/index.js                          
[npmPack] npm notice 56.6kB  esm/models/mappers.js                            
[npmPack] npm notice 2.0kB   esm/operations/metadata.js                       
[npmPack] npm notice 563B    esm/models/metadataMappers.js                    
[npmPack] npm notice 3.9kB   esm/operations/metrics.js                        
[npmPack] npm notice 575B    esm/models/metricsMappers.js                     
[npmPack] npm notice 4.8kB   esm/models/parameters.js                         
[npmPack] npm notice 1.7kB   esm/operations/query.js                          
[npmPack] npm notice 483B    esm/models/queryMappers.js                       
[npmPack] npm notice 1.0kB   rollup.config.js                                 
[npmPack] npm notice 1.7kB   package.json                                     
[npmPack] npm notice 457B    tsconfig.json                                    
[npmPack] npm notice 187.2kB dist/applicationinsights-query.js.map            
[npmPack] npm notice 28.2kB  dist/applicationinsights-query.min.js.map        
[npmPack] npm notice 719B    esm/applicationInsightsDataClient.d.ts.map       
[npmPack] npm notice 872B    esm/applicationInsightsDataClient.js.map         
[npmPack] npm notice 406B    esm/applicationInsightsDataClientContext.d.ts.map
[npmPack] npm notice 902B    esm/applicationInsightsDataClientContext.js.map  
[npmPack] npm notice 1.4kB   esm/operations/events.d.ts.map                   
[npmPack] npm notice 1.7kB   esm/operations/events.js.map                     
[npmPack] npm notice 628B    esm/models/eventsMappers.d.ts.map                
[npmPack] npm notice 641B    esm/models/eventsMappers.js.map                  
[npmPack] npm notice 20.4kB  esm/models/index.d.ts.map                        
[npmPack] npm notice 200B    esm/operations/index.d.ts.map                    
[npmPack] npm notice 126B    esm/models/index.js.map                          
[npmPack] npm notice 215B    esm/operations/index.js.map                      
[npmPack] npm notice 2.8kB   esm/models/mappers.d.ts.map                      
[npmPack] npm notice 31.7kB  esm/models/mappers.js.map                        
[npmPack] npm notice 1.1kB   esm/operations/metadata.d.ts.map                 
[npmPack] npm notice 1.3kB   esm/operations/metadata.js.map                   
[npmPack] npm notice 277B    esm/models/metadataMappers.d.ts.map              
[npmPack] npm notice 290B    esm/models/metadataMappers.js.map                
[npmPack] npm notice 1.7kB   esm/operations/metrics.d.ts.map                  
[npmPack] npm notice 2.4kB   esm/operations/metrics.js.map                    
[npmPack] npm notice 278B    esm/models/metricsMappers.d.ts.map               
[npmPack] npm notice 291B    esm/models/metricsMappers.js.map                 
[npmPack] npm notice 1.1kB   esm/models/parameters.d.ts.map                   
[npmPack] npm notice 3.7kB   esm/models/parameters.js.map                     
[npmPack] npm notice 814B    esm/operations/query.d.ts.map                    
[npmPack] npm notice 1.0kB   esm/operations/query.js.map                      
[npmPack] npm notice 239B    esm/models/queryMappers.d.ts.map                 
[npmPack] npm notice 252B    esm/models/queryMappers.js.map                   
[npmPack] npm notice 3.9kB   README.md                                        
[npmPack] npm notice 1.1kB   esm/applicationInsightsDataClient.d.ts           
[npmPack] npm notice 1.6kB   src/applicationInsightsDataClient.ts             
[npmPack] npm notice 649B    esm/applicationInsightsDataClientContext.d.ts    
[npmPack] npm notice 1.5kB   src/applicationInsightsDataClientContext.ts      
[npmPack] npm notice 5.7kB   esm/operations/events.d.ts                       
[npmPack] npm notice 8.0kB   src/operations/events.ts                         
[npmPack] npm notice 934B    esm/models/eventsMappers.d.ts                    
[npmPack] npm notice 1.3kB   src/models/eventsMappers.ts                      
[npmPack] npm notice 46.0kB  esm/models/index.d.ts                            
[npmPack] npm notice 141B    esm/operations/index.d.ts                        
[npmPack] npm notice 43.2kB  src/models/index.ts                              
[npmPack] npm notice 425B    src/operations/index.ts                          
[npmPack] npm notice 4.3kB   esm/models/mappers.d.ts                          
[npmPack] npm notice 44.4kB  src/models/mappers.ts                            
[npmPack] npm notice 2.7kB   esm/operations/metadata.d.ts                     
[npmPack] npm notice 4.5kB   src/operations/metadata.ts                       
[npmPack] npm notice 253B    esm/models/metadataMappers.d.ts                  
[npmPack] npm notice 541B    src/models/metadataMappers.ts                    
[npmPack] npm notice 7.5kB   esm/operations/metrics.d.ts                      
[npmPack] npm notice 10.9kB  src/operations/metrics.ts                        
[npmPack] npm notice 265B    esm/models/metricsMappers.d.ts                   
[npmPack] npm notice 554B    src/models/metricsMappers.ts                     
[npmPack] npm notice 1.3kB   esm/models/parameters.d.ts                       
[npmPack] npm notice 4.7kB   src/models/parameters.ts                         
[npmPack] npm notice 2.3kB   esm/operations/query.d.ts                        
[npmPack] npm notice 3.6kB   src/operations/query.ts                          
[npmPack] npm notice 173B    esm/models/queryMappers.d.ts                     
[npmPack] npm notice 460B    src/models/queryMappers.ts                       
[npmPack] npm notice 1.1kB   LICENSE.txt                                      
[npmPack] npm notice === Tarball Details === 
[npmPack] npm notice name:          @azure/applicationinsights-query         
[npmPack] npm notice version:       1.1.0                                    
[npmPack] npm notice filename:      azure-applicationinsights-query-1.1.0.tgz
[npmPack] npm notice package size:  82.1 kB                                  
[npmPack] npm notice unpacked size: 705.8 kB                                 
[npmPack] npm notice shasum:        10e5d1e963e8ba512c6e0c26020b01990b35256c 
[npmPack] npm notice integrity:     sha512-RJqiooJRkZoeE[...]V5ARSb2484sUQ==

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 23, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 23, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 23, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 23, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@changlong-liu changlong-liu mentioned this pull request Jul 24, 2020
Closed
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@divyajay @00Kai0
Authenticate to AppInsights API (Azure#9939)
dd46357 
* Authenticate to AppInsights API

For just the data plane Direct path (v1 version), update the swagger definition to specify authentication against the API, instead of azure auth.

* Explicitly specify 'resource' in authorizationUrl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rloutlaw rloutlaw rloutlaw approved these changes

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@divyajay @AutorestCI @azuresdkci @anuchandy @rloutlaw @lmazuel