Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #9927

Merged
merged 15 commits into from
Jul 13, 2020
Merged

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #9927

merged 15 commits into from
Jul 13, 2020

Conversation

sashahdo
Copy link
Contributor

@sashahdo sashahdo commented Jun 23, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

@sashahdo sashahdo requested a review from kjeur as a code owner June 23, 2020 06:57
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 23, 2020

[Staging] Swagger Validation Report

BreakingChange: 4 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'and' renamed or removed?
New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3894:7
Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3869:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'not' renamed or removed?
New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3894:7
Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3869:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'and' renamed or removed?
New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3894:7
Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3869:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'not' renamed or removed?
New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3894:7
Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3869:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 23, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 810b53a with merge commit ef1a9a2. SDK Automation 13.0.17.20200619.4
  • ⚠️azure-mgmt-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-consumption
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-consumption
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 63.892% size of original (original: 73119 chars, delta: 46717 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model ReservationSummary has a new parameter total_reserved_quantity
    [ChangeLog]   - Model ReservationSummary has a new parameter used_quantity
    [ChangeLog]   - Model ReservationSummary has a new parameter kind
    [ChangeLog]   - Model ReservationSummary has a new parameter purchased_quantity
    [ChangeLog]   - Model ReservationSummary has a new parameter remaining_quantity
    [ChangeLog]   - Model ReservationSummary has a new parameter utilized_percentage
    [ChangeLog]   - Model ReservationDetail has a new parameter kind
    [ChangeLog]   - Model ReservationDetail has a new parameter instance_flexibility_group
    [ChangeLog]   - Model ReservationDetail has a new parameter instance_flexibility_ratio
    [ChangeLog]   - Model Notification has a new parameter threshold_type
    [ChangeLog]   - Model Budget has a new parameter filter
    [ChangeLog]   - Added operation ReservationsDetailsOperations.list
    [ChangeLog]   - Added operation ReservationRecommendationsOperations.list
    [ChangeLog]   - Added operation ReservationsSummariesOperations.list
    [ChangeLog]   - Added operation ChargesOperations.list
    [ChangeLog]   - Added operation group ReservationRecommendationDetailsOperations
    [ChangeLog]   - Added operation group ReservationTransactionsOperations
    [ChangeLog]   - Added operation group LotsOperations
    [ChangeLog]   - Added operation group CreditsOperations
    [ChangeLog]   - Added operation group EventsOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Model Budget no longer has parameter filters
    [ChangeLog]   - Model ChargeSummary has a new signature
    [ChangeLog]   - Model UsageDetail has a new signature
    [ChangeLog]   - Model ReservationRecommendation has a new signature
    [ChangeLog]   - Removed operation UsageDetailsOperations.download
    [ChangeLog]   - Removed operation ChargesOperations.list_by_scope

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 23, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 23, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 810b53a with merge commit ef1a9a2. SDK Automation 13.0.17.20200619.4
  • ️✔️sdk/consumption/mgmt-v2017_04_24_preview [View full logs]  [Release SDK Changes]
  • ️✔️sdk/consumption/mgmt-v2017_11_30 [View full logs]  [Release SDK Changes]
  • ⚠️sdk/consumption/mgmt-v2018_01_31 [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_01_31/src/main/java/com/microsoft/azure/management/consumption/v2018_01_31/implementation/BudgetsImpl.java:[154,21] cannot find symbol
      [mvn]   symbol: variable inner
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-consumption: Compilation failure
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_01_31/src/main/java/com/microsoft/azure/management/consumption/v2018_01_31/implementation/BudgetsImpl.java:[154,21] cannot find symbol
      [mvn] [ERROR]   symbol: variable inner
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ⚠️sdk/consumption/mgmt-v2018_03_31 [View full logs]  [Release SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_03_31/src/main/java/com/microsoft/azure/management/consumption/v2018_03_31/implementation/BudgetsImpl.java:[154,21] cannot find symbol
        [mvn]   symbol: variable inner
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_03_31/src/main/java/com/microsoft/azure/management/consumption/v2018_03_31/implementation/ReservationRecommendationsImpl.java:[21,143] type argument com.microsoft.azure.management.consumption.v2018_03_31.implementation.ReservationRecommendationsModelInner is not within bounds of type-variable InnerT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_03_31/src/main/java/com/microsoft/azure/management/consumption/v2018_03_31/implementation/ReservationRecommendationsModelImpl.java:[18,110] type argument com.microsoft.azure.management.consumption.v2018_03_31.implementation.ReservationRecommendationsModelInner is not within bounds of type-variable InnerModelT
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-consumption: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_03_31/src/main/java/com/microsoft/azure/management/consumption/v2018_03_31/implementation/BudgetsImpl.java:[154,21] cannot find symbol
        [mvn] [ERROR]   symbol: variable inner
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_03_31/src/main/java/com/microsoft/azure/management/consumption/v2018_03_31/implementation/ReservationRecommendationsImpl.java:[21,143] type argument com.microsoft.azure.management.consumption.v2018_03_31.implementation.ReservationRecommendationsModelInner is not within bounds of type-variable InnerT
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_03_31/src/main/java/com/microsoft/azure/management/consumption/v2018_03_31/implementation/ReservationRecommendationsModelImpl.java:[18,110] type argument com.microsoft.azure.management.consumption.v2018_03_31.implementation.ReservationRecommendationsModelInner is not within bounds of type-variable InnerModelT
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      • ️✔️sdk/consumption/mgmt-v2018_05_31 [View full logs]  [Release SDK Changes]
      • ⚠️sdk/consumption/mgmt-v2018_06_30 [View full logs]  [Release SDK Changes]
          [mvn] [ERROR] COMPILATION ERROR : 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_06_30/src/main/java/com/microsoft/azure/management/consumption/v2018_06_30/implementation/BudgetsImpl.java:[154,21] cannot find symbol
          [mvn]   symbol: variable inner
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_06_30/src/main/java/com/microsoft/azure/management/consumption/v2018_06_30/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2018_06_30.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_06_30/src/main/java/com/microsoft/azure/management/consumption/v2018_06_30/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2018_06_30.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-consumption: Compilation failure: Compilation failure: 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_06_30/src/main/java/com/microsoft/azure/management/consumption/v2018_06_30/implementation/BudgetsImpl.java:[154,21] cannot find symbol
          [mvn] [ERROR]   symbol: variable inner
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_06_30/src/main/java/com/microsoft/azure/management/consumption/v2018_06_30/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2018_06_30.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_06_30/src/main/java/com/microsoft/azure/management/consumption/v2018_06_30/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2018_06_30.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
          [mvn] [ERROR] -> [Help 1]
          [mvn] [ERROR] 
          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [mvn] [ERROR] 
          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
        • ⚠️sdk/consumption/mgmt-v2018_08_31 [View full logs]  [Release SDK Changes]
            [mvn] [ERROR] COMPILATION ERROR : 
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_08_31/src/main/java/com/microsoft/azure/management/consumption/v2018_08_31/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2018_08_31.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_08_31/src/main/java/com/microsoft/azure/management/consumption/v2018_08_31/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2018_08_31.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_08_31/src/main/java/com/microsoft/azure/management/consumption/v2018_08_31/implementation/BudgetsImpl.java:[154,21] cannot find symbol
            [mvn]   symbol: variable inner
            [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-consumption: Compilation failure: Compilation failure: 
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_08_31/src/main/java/com/microsoft/azure/management/consumption/v2018_08_31/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2018_08_31.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_08_31/src/main/java/com/microsoft/azure/management/consumption/v2018_08_31/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2018_08_31.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_08_31/src/main/java/com/microsoft/azure/management/consumption/v2018_08_31/implementation/BudgetsImpl.java:[154,21] cannot find symbol
            [mvn] [ERROR]   symbol: variable inner
            [mvn] [ERROR] -> [Help 1]
            [mvn] [ERROR] 
            [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
            [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
            [mvn] [ERROR] 
            [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
            [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
          • ⚠️sdk/consumption/mgmt-v2018_10_01 [View full logs]  [Release SDK Changes]
              [mvn] [ERROR] COMPILATION ERROR : 
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/consumption/v2018_10_01/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2018_10_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/consumption/v2018_10_01/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2018_10_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/consumption/v2018_10_01/implementation/BudgetsImpl.java:[154,21] cannot find symbol
              [mvn]   symbol: variable inner
              [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-consumption: Compilation failure: Compilation failure: 
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/consumption/v2018_10_01/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2018_10_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/consumption/v2018_10_01/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2018_10_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2018_10_01/src/main/java/com/microsoft/azure/management/consumption/v2018_10_01/implementation/BudgetsImpl.java:[154,21] cannot find symbol
              [mvn] [ERROR]   symbol: variable inner
              [mvn] [ERROR] -> [Help 1]
              [mvn] [ERROR] 
              [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
              [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
              [mvn] [ERROR] 
              [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
              [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
            • ⚠️sdk/consumption/mgmt-v2019_01_01 [View full logs]  [Release SDK Changes]
                [mvn] [ERROR] COMPILATION ERROR : 
                [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2019_01_01/src/main/java/com/microsoft/azure/management/consumption/v2019_01_01/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2019_01_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
                [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2019_01_01/src/main/java/com/microsoft/azure/management/consumption/v2019_01_01/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2019_01_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
                [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-consumption: Compilation failure: Compilation failure: 
                [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2019_01_01/src/main/java/com/microsoft/azure/management/consumption/v2019_01_01/implementation/ReservationRecommendationsImpl.java:[21,131] type argument com.microsoft.azure.management.consumption.v2019_01_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerT
                [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/consumption/mgmt-v2019_01_01/src/main/java/com/microsoft/azure/management/consumption/v2019_01_01/implementation/ReservationRecommendationImpl.java:[18,98] type argument com.microsoft.azure.management.consumption.v2019_01_01.implementation.ReservationRecommendationInner is not within bounds of type-variable InnerModelT
                [mvn] [ERROR] -> [Help 1]
                [mvn] [ERROR] 
                [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
                [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
                [mvn] [ERROR] 
                [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
                [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Jun 23, 2020

              azure-sdk-for-js - Release

              ️✔️ succeeded [Logs] [Expand Details]
              • ️✔️ Generate from 810b53a with merge commit ef1a9a2. SDK Automation 13.0.17.20200619.4
              • ️✔️@azure/arm-consumption [View full logs]  [Release SDK Changes]
                Only show 100 items here, please refer to log for details.
                [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
                [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
                [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
                [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
                [npmPack] loaded rollup.config.js with warnings
                [npmPack] (!) Unused external imports
                [npmPack] default imported from external module 'rollup' but never used
                [npmPack] 
                [npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js...
                [npmPack] created ./dist/arm-consumption.js in 563ms
                [npmPack] npm notice 
                [npmPack] npm notice package: @azure/[email protected]
                [npmPack] npm notice === Tarball Contents === 
                [npmPack] npm notice 3.0kB   esm/operations/aggregatedCost.js                           
                [npmPack] npm notice 1.4kB   esm/models/aggregatedCostMappers.js                        
                [npmPack] npm notice 251.1kB dist/arm-consumption.js                                    
                [npmPack] npm notice 93.7kB  dist/arm-consumption.min.js                                
                [npmPack] npm notice 2.8kB   esm/operations/balances.js                                 
                [npmPack] npm notice 1.4kB   esm/models/balancesMappers.js                              
                [npmPack] npm notice 5.0kB   esm/operations/budgets.js                                  
                [npmPack] npm notice 1.5kB   esm/models/budgetsMappers.js                               
                [npmPack] npm notice 1.7kB   esm/operations/charges.js                                  
                [npmPack] npm notice 1.5kB   esm/models/chargesMappers.js                               
                [npmPack] npm notice 2.7kB   esm/consumptionManagementClient.js                         
                [npmPack] npm notice 2.6kB   esm/consumptionManagementClientContext.js                  
                [npmPack] npm notice 1.9kB   esm/operations/credits.js                                  
                [npmPack] npm notice 1.4kB   esm/models/creditsMappers.js                               
                [npmPack] npm notice 2.8kB   esm/operations/eventsOperations.js                         
                [npmPack] npm notice 1.4kB   esm/models/eventsOperationsMappers.js                      
                [npmPack] npm notice 1.7kB   esm/operations/forecasts.js                                
                [npmPack] npm notice 1.5kB   esm/models/forecastsMappers.js                             
                [npmPack] npm notice 345B    esm/models/index.js                                        
                [npmPack] npm notice 962B    esm/operations/index.js                                    
                [npmPack] npm notice 2.6kB   esm/operations/lotsOperations.js                           
                [npmPack] npm notice 1.4kB   esm/models/lotsOperationsMappers.js                        
                [npmPack] npm notice 113.3kB esm/models/mappers.js                                      
                [npmPack] npm notice 2.5kB   esm/operations/marketplaces.js                             
                [npmPack] npm notice 1.5kB   esm/models/marketplacesMappers.js                          
                [npmPack] npm notice 2.3kB   esm/operations/operations.js                               
                [npmPack] npm notice 488B    esm/models/operationsMappers.js                            
                [npmPack] npm notice 6.5kB   esm/models/parameters.js                                   
                [npmPack] npm notice 2.8kB   esm/operations/priceSheet.js                               
                [npmPack] npm notice 1.4kB   esm/models/priceSheetMappers.js                            
                [npmPack] npm notice 2.3kB   esm/operations/reservationRecommendationDetails.js         
                [npmPack] npm notice 1.5kB   esm/models/reservationRecommendationDetailsMappers.js      
                [npmPack] npm notice 2.6kB   esm/operations/reservationRecommendations.js               
                [npmPack] npm notice 606B    esm/models/reservationRecommendationsMappers.js            
                [npmPack] npm notice 6.3kB   esm/operations/reservationsDetails.js                      
                [npmPack] npm notice 1.5kB   esm/models/reservationsDetailsMappers.js                   
                [npmPack] npm notice 6.4kB   esm/operations/reservationsSummaries.js                    
                [npmPack] npm notice 1.5kB   esm/models/reservationsSummariesMappers.js                 
                [npmPack] npm notice 4.5kB   esm/operations/reservationTransactions.js                  
                [npmPack] npm notice 1.5kB   esm/models/reservationTransactionsMappers.js               
                [npmPack] npm notice 995B    rollup.config.js                                           
                [npmPack] npm notice 1.6kB   esm/operations/tags.js                                     
                [npmPack] npm notice 1.4kB   esm/models/tagsMappers.js                                  
                [npmPack] npm notice 2.5kB   esm/operations/usageDetails.js                             
                [npmPack] npm notice 1.5kB   esm/models/usageDetailsMappers.js                          
                [npmPack] npm notice 1.7kB   package.json                                               
                [npmPack] npm notice 457B    tsconfig.json                                              
                [npmPack] npm notice 1.2kB   esm/operations/aggregatedCost.d.ts.map                     
                [npmPack] npm notice 1.6kB   esm/operations/aggregatedCost.js.map                       
                [npmPack] npm notice 722B    esm/models/aggregatedCostMappers.d.ts.map                  
                [npmPack] npm notice 735B    esm/models/aggregatedCostMappers.js.map                    
                [npmPack] npm notice 526.6kB dist/arm-consumption.js.map                                
                [npmPack] npm notice 65.6kB  dist/arm-consumption.min.js.map                            
                [npmPack] npm notice 1.2kB   esm/operations/balances.d.ts.map                           
                [npmPack] npm notice 1.6kB   esm/operations/balances.js.map                             
                [npmPack] npm notice 710B    esm/models/balancesMappers.d.ts.map                        
                [npmPack] npm notice 723B    esm/models/balancesMappers.js.map                          
                [npmPack] npm notice 2.6kB   esm/operations/budgets.d.ts.map                            
                [npmPack] npm notice 3.3kB   esm/operations/budgets.js.map                              
                [npmPack] npm notice 721B    esm/models/budgetsMappers.d.ts.map                         
                [npmPack] npm notice 734B    esm/models/budgetsMappers.js.map                           
                [npmPack] npm notice 768B    esm/operations/charges.d.ts.map                            
                [npmPack] npm notice 1.1kB   esm/operations/charges.js.map                              
                [npmPack] npm notice 721B    esm/models/chargesMappers.d.ts.map                         
                [npmPack] npm notice 734B    esm/models/chargesMappers.js.map                           
                [npmPack] npm notice 1.3kB   esm/consumptionManagementClient.d.ts.map                   
                [npmPack] npm notice 1.8kB   esm/consumptionManagementClient.js.map                     
                [npmPack] npm notice 520B    esm/consumptionManagementClientContext.d.ts.map            
                [npmPack] npm notice 1.4kB   esm/consumptionManagementClientContext.js.map              
                [npmPack] npm notice 791B    esm/operations/credits.d.ts.map                            
                [npmPack] npm notice 1.0kB   esm/operations/credits.js.map                              
                [npmPack] npm notice 708B    esm/models/creditsMappers.d.ts.map                         
                [npmPack] npm notice 721B    esm/models/creditsMappers.js.map                           
                [npmPack] npm notice 1.3kB   esm/operations/eventsOperations.d.ts.map                   
                [npmPack] npm notice 1.6kB   esm/operations/eventsOperations.js.map                     
                [npmPack] npm notice 736B    esm/models/eventsOperationsMappers.d.ts.map                
                [npmPack] npm notice 749B    esm/models/eventsOperationsMappers.js.map                  
                [npmPack] npm notice 661B    esm/operations/forecasts.d.ts.map                          
                [npmPack] npm notice 968B    esm/operations/forecasts.js.map                            
                [npmPack] npm notice 725B    esm/models/forecastsMappers.d.ts.map                       
                [npmPack] npm notice 738B    esm/models/forecastsMappers.js.map                         
                [npmPack] npm notice 40.0kB  esm/models/index.d.ts.map                                  
                [npmPack] npm notice 514B    esm/operations/index.d.ts.map                              
                [npmPack] npm notice 126B    esm/models/index.js.map                                    
                [npmPack] npm notice 529B    esm/operations/index.js.map                                
                [npmPack] npm notice 1.2kB   esm/operations/lotsOperations.d.ts.map                     
                [npmPack] npm notice 1.5kB   esm/operations/lotsOperations.js.map                       

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Jun 23, 2020

              azure-sdk-for-go - Release

              ️✔️ succeeded [Logs] [Expand Details]

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Jun 23, 2020

              azure-sdk-for-net - Release

              ️✔️ succeeded [Logs] [Expand Details]

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Jun 23, 2020

              Trenton Generation - Release

              No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

              @azuresdkci
              Copy link
              Contributor

              Can one of the admins verify this patch?

              @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 23, 2020
              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Jun 23, 2020

              azure-sdk-for-python-track2 - Release

              No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @sashahdo
              Copy link
              Contributor Author

              The reason for this PR is to fix a circular dependency in the BudgetFilter definition, hence the breaking change.
              The api itself is not changed.

              @ChenTanyi
              Copy link
              Contributor

              It has no API change, so it doesn't need ARM review anymore.

              As identified in the automated checks there are breaking changes, Please follow Azure Breaking changes approval request form as defined https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37673/Retirements-and-Breaking-Changes

              @ChenTanyi ChenTanyi added Breaking Change Review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required Breaking Change Review labels Jul 1, 2020
              @akning-ms
              Copy link
              Contributor

              Yes, Looks model is same, it is not a really breaking change.

              @akning-ms akning-ms added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed BreakingChangeReviewRequired labels Jul 10, 2020
              @ChenTanyi
              Copy link
              Contributor

              /azp run

              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 3 pipeline(s).

              @akning-ms
              Copy link
              Contributor

              /openapi pipeline

              @openapi-sdkautomation
              Copy link

              /openapi pipeline

              Unrecognized OpenAPI bot command (pipeline).
              Try sdkautomation instead.

              @akning-ms akning-ms merged commit ef1a9a2 into Azure:master Jul 13, 2020
              00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
              …on stable/2019-10-01 (Azure#9927)
              
              * fixed examples and BudgetCategory as PM suggested
              
              * fixed circularly dependent BudgetFilter
              
              * Set theme jekyll-theme-hacker
              
              * fixed missing property errors
              
              * refactored with better name
              
              * added period
              
              * fixed examples and BudgetCategory as PM suggested
              
              * fixed circularly dependent BudgetFilter
              
              * fixed missing property errors
              
              * refactored with better name
              
              * added period
              
              * Revert "Set theme jekyll-theme-hacker"
              
              This reverts commit 787aea3.
              
              * fixed prettier issue
              
              * removed unnecessary object attribute
              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Labels
              Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
              Projects
              None yet
              Development

              Successfully merging this pull request may close these issues.

              4 participants