-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #9927
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #9927
Conversation
…tps://github.com/sashahdo/azure-rest-api-specs into dev-consumption-Microsoft.Consumption-2019-10-01
This reverts commit 787aea3.
[Staging] Swagger Validation Report
❌ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
The reason for this PR is to fix a circular dependency in the BudgetFilter definition, hence the breaking change. |
It has no API change, so it doesn't need ARM review anymore. As identified in the automated checks there are breaking changes, Please follow Azure Breaking changes approval request form as defined https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37673/Retirements-and-Breaking-Changes |
Yes, Looks model is same, it is not a really breaking change. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/openapi pipeline |
Unrecognized OpenAPI bot command (pipeline). |
…on stable/2019-10-01 (Azure#9927) * fixed examples and BudgetCategory as PM suggested * fixed circularly dependent BudgetFilter * Set theme jekyll-theme-hacker * fixed missing property errors * refactored with better name * added period * fixed examples and BudgetCategory as PM suggested * fixed circularly dependent BudgetFilter * fixed missing property errors * refactored with better name * added period * Revert "Set theme jekyll-theme-hacker" This reverts commit 787aea3. * fixed prettier issue * removed unnecessary object attribute
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on PR review process.