Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRP] Expose restorepolicy.minRestoreTime and depercate restorepolicy… #9907

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Conversation

xmbms
Copy link
Contributor

@xmbms xmbms commented Jun 22, 2020

….lastEnabledTime

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 22, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 22, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 22, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 398fc21 with merge commit aaf2ab4. SDK Automation 13.0.17.20200619.4
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1449: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"121","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 17 Jul 2020 05:29:26 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0400:1C5A:3C9D3B:9E4ECC:5F113736","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4517","x-ratelimit-reset":"1594965648","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-storage@9907","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.1 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1450: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"121","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 17 Jul 2020 05:29:26 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0405:1DD9:BAC027:14D513D:5F113736","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4515","x-ratelimit-reset":"1594965647","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/track2_azure-mgmt-storage@9907","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.1 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://developer.github.com/v3/git/refs/#delete-a-reference"}
    [azure-mgmt-storage][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-03-01-preview', '2018-07-01'} in label v2018_07_01
    [azure-mgmt-storage][after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
  • ️✔️azure-mgmt-storage [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-storage
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-storage
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-03-01-preview', '2018-07-01'} in label v2018_07_01
    [after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 0.196% size of original (original: 89182 chars, delta: 175 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model RestorePolicyProperties has a new parameter min_restore_time

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 22, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 22, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 22, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 22, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 398fc21 with merge commit aaf2ab4. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-storage [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/storageManagementClient.js → ./dist/arm-storage.js...
    [npmPack] created ./dist/arm-storage.js in 645ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 328.2kB dist/arm-storage.js                                           
    [npmPack] npm notice 123.7kB dist/arm-storage.min.js                                       
    [npmPack] npm notice 19.6kB  esm/operations/blobContainers.js                              
    [npmPack] npm notice 2.1kB   esm/models/blobContainersMappers.js                           
    [npmPack] npm notice 4.3kB   esm/operations/blobServices.js                                
    [npmPack] npm notice 1.8kB   esm/models/blobServicesMappers.js                             
    [npmPack] npm notice 6.6kB   esm/operations/encryptionScopes.js                            
    [npmPack] npm notice 1.8kB   esm/models/encryptionScopesMappers.js                         
    [npmPack] npm notice 4.5kB   esm/operations/fileServices.js                                
    [npmPack] npm notice 1.8kB   esm/models/fileServicesMappers.js                             
    [npmPack] npm notice 8.9kB   esm/operations/fileShares.js                                  
    [npmPack] npm notice 1.8kB   esm/models/fileSharesMappers.js                               
    [npmPack] npm notice 345B    esm/models/index.js                                           
    [npmPack] npm notice 935B    esm/operations/index.js                                       
    [npmPack] npm notice 4.4kB   esm/operations/managementPolicies.js                          
    [npmPack] npm notice 1.8kB   esm/models/managementPoliciesMappers.js                       
    [npmPack] npm notice 118.7kB esm/models/mappers.js                                         
    [npmPack] npm notice 5.9kB   esm/operations/objectReplicationPoliciesOperations.js         
    [npmPack] npm notice 1.8kB   esm/models/objectReplicationPoliciesOperationsMappers.js      
    [npmPack] npm notice 1.5kB   esm/operations/operations.js                                  
    [npmPack] npm notice 509B    esm/models/operationsMappers.js                               
    [npmPack] npm notice 8.0kB   esm/models/parameters.js                                      
    [npmPack] npm notice 5.9kB   esm/operations/privateEndpointConnections.js                  
    [npmPack] npm notice 1.8kB   esm/models/privateEndpointConnectionsMappers.js               
    [npmPack] npm notice 2.1kB   esm/operations/privateLinkResources.js                        
    [npmPack] npm notice 1.8kB   esm/models/privateLinkResourcesMappers.js                     
    [npmPack] npm notice 7.4kB   esm/operations/queue.js                                       
    [npmPack] npm notice 1.8kB   esm/models/queueMappers.js                                    
    [npmPack] npm notice 4.4kB   esm/operations/queueServices.js                               
    [npmPack] npm notice 1.8kB   esm/models/queueServicesMappers.js                            
    [npmPack] npm notice 983B    rollup.config.js                                              
    [npmPack] npm notice 1.6kB   esm/operations/skus.js                                        
    [npmPack] npm notice 465B    esm/models/skusMappers.js                                     
    [npmPack] npm notice 22.3kB  esm/operations/storageAccounts.js                             
    [npmPack] npm notice 2.1kB   esm/models/storageAccountsMappers.js                          
    [npmPack] npm notice 2.6kB   esm/storageManagementClient.js                                
    [npmPack] npm notice 2.5kB   esm/storageManagementClientContext.js                         
    [npmPack] npm notice 6.9kB   esm/operations/tableOperations.js                             
    [npmPack] npm notice 1.8kB   esm/models/tableOperationsMappers.js                          
    [npmPack] npm notice 4.4kB   esm/operations/tableServices.js                               
    [npmPack] npm notice 1.8kB   esm/models/tableServicesMappers.js                            
    [npmPack] npm notice 1.7kB   esm/operations/usages.js                                      
    [npmPack] npm notice 436B    esm/models/usagesMappers.js                                   
    [npmPack] npm notice 1.7kB   package.json                                                  
    [npmPack] npm notice 457B    tsconfig.json                                                 
    [npmPack] npm notice 726.6kB dist/arm-storage.js.map                                       
    [npmPack] npm notice 86.8kB  dist/arm-storage.min.js.map                                   
    [npmPack] npm notice 8.0kB   esm/operations/blobContainers.d.ts.map                        
    [npmPack] npm notice 10.9kB  esm/operations/blobContainers.js.map                          
    [npmPack] npm notice 1.1kB   esm/models/blobContainersMappers.d.ts.map                     
    [npmPack] npm notice 1.1kB   esm/models/blobContainersMappers.js.map                       
    [npmPack] npm notice 1.8kB   esm/operations/blobServices.d.ts.map                          
    [npmPack] npm notice 2.4kB   esm/operations/blobServices.js.map                            
    [npmPack] npm notice 992B    esm/models/blobServicesMappers.d.ts.map                       
    [npmPack] npm notice 1.0kB   esm/models/blobServicesMappers.js.map                         
    [npmPack] npm notice 3.0kB   esm/operations/encryptionScopes.d.ts.map                      
    [npmPack] npm notice 3.8kB   esm/operations/encryptionScopes.js.map                        
    [npmPack] npm notice 1.0kB   esm/models/encryptionScopesMappers.d.ts.map                   
    [npmPack] npm notice 1.0kB   esm/models/encryptionScopesMappers.js.map                     
    [npmPack] npm notice 1.7kB   esm/operations/fileServices.d.ts.map                          
    [npmPack] npm notice 2.5kB   esm/operations/fileServices.js.map                            
    [npmPack] npm notice 992B    esm/models/fileServicesMappers.d.ts.map                       
    [npmPack] npm notice 1.0kB   esm/models/fileServicesMappers.js.map                         
    [npmPack] npm notice 4.0kB   esm/operations/fileShares.d.ts.map                            
    [npmPack] npm notice 5.3kB   esm/operations/fileShares.js.map                              
    [npmPack] npm notice 995B    esm/models/fileSharesMappers.d.ts.map                         
    [npmPack] npm notice 1.0kB   esm/models/fileSharesMappers.js.map                           
    [npmPack] npm notice 43.1kB  esm/models/index.d.ts.map                                     
    [npmPack] npm notice 497B    esm/operations/index.d.ts.map                                 
    [npmPack] npm notice 126B    esm/models/index.js.map                                       
    [npmPack] npm notice 512B    esm/operations/index.js.map                                   
    [npmPack] npm notice 1.8kB   esm/operations/managementPolicies.d.ts.map                    
    [npmPack] npm notice 2.5kB   esm/operations/managementPolicies.js.map                      
    [npmPack] npm notice 991B    esm/models/managementPoliciesMappers.d.ts.map                 
    [npmPack] npm notice 1.0kB   esm/models/managementPoliciesMappers.js.map                   
    [npmPack] npm notice 5.7kB   esm/models/mappers.d.ts.map                                   
    [npmPack] npm notice 65.6kB  esm/models/mappers.js.map                                     
    [npmPack] npm notice 2.5kB   esm/operations/objectReplicationPoliciesOperations.d.ts.map   
    [npmPack] npm notice 3.1kB   esm/operations/objectReplicationPoliciesOperations.js.map     
    [npmPack] npm notice 1.0kB   esm/models/objectReplicationPoliciesOperationsMappers.d.ts.map
    [npmPack] npm notice 1.1kB   esm/models/objectReplicationPoliciesOperationsMappers.js.map  
    [npmPack] npm notice 663B    esm/operations/operations.d.ts.map                            
    [npmPack] npm notice 908B    esm/operations/operations.js.map                              
    [npmPack] npm notice 251B    esm/models/operationsMappers.d.ts.map                         
    [npmPack] npm notice 264B    esm/models/operationsMappers.js.map                           
    [npmPack] npm notice 1.5kB   esm/models/parameters.d.ts.map                                
    [npmPack] npm notice 6.0kB   esm/models/parameters.js.map                                  

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 22, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@@ -1260,7 +1260,13 @@
"type": "string",
"format": "date-time",
"readOnly": true,
"description": "Returns the date and time the restore policy was last enabled."
"description": "Deprecated in favor of minRestoreTime property."
Copy link
Member

@blueww blueww Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Update Example for the change.

@qianwens
Copy link
Member

qianwens commented Jul 6, 2020

@xmbms could you please help update the example for the change and let me know when it is ready to merge.

@qianwens
Copy link
Member

/openapi pipeline

@openapi-sdkautomation
Copy link

/openapi pipeline

Unrecognized OpenAPI bot command (pipeline).
Try sdkautomation instead.

@blueww
Copy link
Member

blueww commented Jul 15, 2020

I am OK with it, as .net SDK pass.
Anyway, this might be breaking change as new property added.
If ARM review board approve it, I am OK for merge it.

@qianwens qianwens merged commit aaf2ab4 into Azure:master Jul 17, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants