-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.media new version 2020 05 01 #9889
Microsoft.media new version 2020 05 01 #9889
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-js - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
…ties of a PATCH request body must not be required. PATCH operation: 'LiveEvents_Update' Model Definition: 'TrackedResource' Property: 'location'"
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
…omplaining about duplicate
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -54,7 +51,7 @@ | |||
"provisioningState": "InProgress", | |||
"created": "0001-01-01T00:00:00Z", | |||
"lastModified": "0001-01-01T00:00:00Z", | |||
"vanityUrl": false, | |||
"useStaticHostname": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any particular reason to change the property name? This would cause SDK breaking change across versions.
Hi @ravbhatnagar, here is case for lint Rule 2016(patchbodyparametersschema) which new added, as @giakas changed ref TrackedResource to common types.json which 'location' is required , so it caused lint R2016 failure in patch operation. looks @giakas can not put discriminator as document guide. Do you have any suggestion for this? currently the Lint failure has been suppressed. |
* Adds base for updating Microsoft.Media from version stable/2018-07-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Updating the some swagger files to new version. * Update to latest swaggers and fix some examples. * fix prettier issue * fix some linter issues * fix spell check. * Add a supression for R2016 linter rule, which was failing for "Properties of a PATCH request body must not be required. PATCH operation: 'LiveEvents_Update' Model Definition: 'TrackedResource' Property: 'location'" * Fix a validation error * add 204 for the delete account. * Move ApiError and ODataError to a different file, as autorest v3 is complaining about duplicate
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.