Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.media new version 2020 05 01 #9889

Merged
merged 12 commits into from
Jun 24, 2020
Merged

Microsoft.media new version 2020 05 01 #9889

merged 12 commits into from
Jun 24, 2020

Conversation

giakas
Copy link
Contributor

@giakas giakas commented Jun 19, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 19, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b04ef39 with merge commit e3649e8. SDK Automation 13.0.17.20200619.4
  • ⚠️azure-mgmt-media [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-media
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-media
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 9.419% size of original (original: 112525 chars, delta: 10599 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model MediaService has a new parameter encryption
    [ChangeLog]   - Model MediaService has a new parameter storage_authentication
    [ChangeLog]   - Model MediaService has a new parameter identity
    [ChangeLog]   - Model Video has a new parameter sync_mode
    [ChangeLog]   - Model JpgImage has a new parameter sync_mode
    [ChangeLog]   - Model Image has a new parameter sync_mode
    [ChangeLog]   - Model LiveEvent has a new parameter use_static_hostname
    [ChangeLog]   - Model H264Video has a new parameter sync_mode
    [ChangeLog]   - Model ServiceSpecification has a new parameter log_specifications
    [ChangeLog]   - Model PngImage has a new parameter sync_mode
    [ChangeLog]   - Added operation group PrivateLinkResourcesOperations
    [ChangeLog]   - Added operation group PrivateEndpointConnectionsOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Parameter location of model MediaService is now required
    [ChangeLog]   - Parameter location of model LiveEvent is now required
    [ChangeLog]   - Parameter location of model StreamingEndpoint is now required
    [ChangeLog]   - Parameter location of model TrackedResource is now required
    [ChangeLog]   - Model LiveEvent no longer has parameter vanity_url

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from b04ef39 with merge commit e3649e8. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-mediaservices [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/azureMediaServices.js → ./dist/arm-mediaservices.js...
    [npmPack] created ./dist/arm-mediaservices.js in 842ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 7.4kB   esm/operations/accountFilters.js                     
    [npmPack] npm notice 3.1kB   esm/models/accountFiltersMappers.js                  
    [npmPack] npm notice 435.0kB dist/arm-mediaservices.js                            
    [npmPack] npm notice 171.2kB dist/arm-mediaservices.min.js                        
    [npmPack] npm notice 7.8kB   esm/operations/assetFilters.js                       
    [npmPack] npm notice 3.1kB   esm/models/assetFiltersMappers.js                    
    [npmPack] npm notice 10.8kB  esm/operations/assets.js                             
    [npmPack] npm notice 3.3kB   esm/models/assetsMappers.js                          
    [npmPack] npm notice 2.5kB   esm/azureMediaServices.js                            
    [npmPack] npm notice 2.5kB   esm/azureMediaServicesContext.js                     
    [npmPack] npm notice 9.0kB   esm/operations/contentKeyPolicies.js                 
    [npmPack] npm notice 3.2kB   esm/models/contentKeyPoliciesMappers.js              
    [npmPack] npm notice 345B    esm/models/index.js                                  
    [npmPack] npm notice 886B    esm/operations/index.js                              
    [npmPack] npm notice 8.7kB   esm/operations/jobs.js                               
    [npmPack] npm notice 3.1kB   esm/models/jobsMappers.js                            
    [npmPack] npm notice 17.5kB  esm/operations/liveEvents.js                         
    [npmPack] npm notice 3.2kB   esm/models/liveEventsMappers.js                      
    [npmPack] npm notice 9.2kB   esm/operations/liveOutputs.js                        
    [npmPack] npm notice 3.1kB   esm/models/liveOutputsMappers.js                     
    [npmPack] npm notice 2.0kB   esm/operations/locations.js                          
    [npmPack] npm notice 493B    esm/models/locationsMappers.js                       
    [npmPack] npm notice 152.4kB esm/models/mappers.js                                
    [npmPack] npm notice 11.5kB  esm/operations/mediaservices.js                      
    [npmPack] npm notice 3.3kB   esm/models/mediaservicesMappers.js                   
    [npmPack] npm notice 2.2kB   esm/operations/operations.js                         
    [npmPack] npm notice 571B    esm/models/operationsMappers.js                      
    [npmPack] npm notice 5.3kB   esm/models/parameters.js                             
    [npmPack] npm notice 5.5kB   esm/operations/privateEndpointConnections.js         
    [npmPack] npm notice 3.2kB   esm/models/privateEndpointConnectionsMappers.js      
    [npmPack] npm notice 3.0kB   esm/operations/privateLinkResources.js               
    [npmPack] npm notice 3.2kB   esm/models/privateLinkResourcesMappers.js            
    [npmPack] npm notice 990B    rollup.config.js                                     
    [npmPack] npm notice 18.6kB  esm/operations/streamingEndpoints.js                 
    [npmPack] npm notice 3.2kB   esm/models/streamingEndpointsMappers.js              
    [npmPack] npm notice 8.6kB   esm/operations/streamingLocators.js                  
    [npmPack] npm notice 3.2kB   esm/models/streamingLocatorsMappers.js               
    [npmPack] npm notice 6.3kB   esm/operations/streamingPolicies.js                  
    [npmPack] npm notice 3.1kB   esm/models/streamingPoliciesMappers.js               
    [npmPack] npm notice 7.4kB   esm/operations/transforms.js                         
    [npmPack] npm notice 3.1kB   esm/models/transformsMappers.js                      
    [npmPack] npm notice 1.7kB   package.json                                         
    [npmPack] npm notice 457B    tsconfig.json                                        
    [npmPack] npm notice 3.3kB   esm/operations/accountFilters.d.ts.map               
    [npmPack] npm notice 4.4kB   esm/operations/accountFilters.js.map                 
    [npmPack] npm notice 1.7kB   esm/models/accountFiltersMappers.d.ts.map            
    [npmPack] npm notice 1.7kB   esm/models/accountFiltersMappers.js.map              
    [npmPack] npm notice 807.4kB dist/arm-mediaservices.js.map                        
    [npmPack] npm notice 108.8kB dist/arm-mediaservices.min.js.map                    
    [npmPack] npm notice 3.7kB   esm/operations/assetFilters.d.ts.map                 
    [npmPack] npm notice 4.6kB   esm/operations/assetFilters.js.map                   
    [npmPack] npm notice 1.7kB   esm/models/assetFiltersMappers.d.ts.map              
    [npmPack] npm notice 1.7kB   esm/models/assetFiltersMappers.js.map                
    [npmPack] npm notice 5.0kB   esm/operations/assets.d.ts.map                       
    [npmPack] npm notice 6.5kB   esm/operations/assets.js.map                         
    [npmPack] npm notice 1.8kB   esm/models/assetsMappers.d.ts.map                    
    [npmPack] npm notice 1.8kB   esm/models/assetsMappers.js.map                      
    [npmPack] npm notice 1.2kB   esm/azureMediaServices.d.ts.map                      
    [npmPack] npm notice 1.7kB   esm/azureMediaServices.js.map                        
    [npmPack] npm notice 502B    esm/azureMediaServicesContext.d.ts.map               
    [npmPack] npm notice 1.4kB   esm/azureMediaServicesContext.js.map                 
    [npmPack] npm notice 3.9kB   esm/operations/contentKeyPolicies.d.ts.map           
    [npmPack] npm notice 5.2kB   esm/operations/contentKeyPolicies.js.map             
    [npmPack] npm notice 1.7kB   esm/models/contentKeyPoliciesMappers.d.ts.map        
    [npmPack] npm notice 1.7kB   esm/models/contentKeyPoliciesMappers.js.map          
    [npmPack] npm notice 54.6kB  esm/models/index.d.ts.map                            
    [npmPack] npm notice 470B    esm/operations/index.d.ts.map                        
    [npmPack] npm notice 126B    esm/models/index.js.map                              
    [npmPack] npm notice 485B    esm/operations/index.js.map                          
    [npmPack] npm notice 4.2kB   esm/operations/jobs.d.ts.map                         
    [npmPack] npm notice 5.3kB   esm/operations/jobs.js.map                           
    [npmPack] npm notice 1.7kB   esm/models/jobsMappers.d.ts.map                      
    [npmPack] npm notice 1.7kB   esm/models/jobsMappers.js.map                        
    [npmPack] npm notice 3.8kB   esm/operations/liveEvents.d.ts.map                   
    [npmPack] npm notice 8.0kB   esm/operations/liveEvents.js.map                     
    [npmPack] npm notice 1.7kB   esm/models/liveEventsMappers.d.ts.map                
    [npmPack] npm notice 1.7kB   esm/models/liveEventsMappers.js.map                  
    [npmPack] npm notice 2.6kB   esm/operations/liveOutputs.d.ts.map                  
    [npmPack] npm notice 4.4kB   esm/operations/liveOutputs.js.map                    
    [npmPack] npm notice 1.7kB   esm/models/liveOutputsMappers.d.ts.map               
    [npmPack] npm notice 1.7kB   esm/models/liveOutputsMappers.js.map                 
    [npmPack] npm notice 830B    esm/operations/locations.d.ts.map                    
    [npmPack] npm notice 1.1kB   esm/operations/locations.js.map                      
    [npmPack] npm notice 223B    esm/models/locationsMappers.d.ts.map                 
    [npmPack] npm notice 236B    esm/models/locationsMappers.js.map                   
    [npmPack] npm notice 8.6kB   esm/models/mappers.d.ts.map                          
    [npmPack] npm notice 85.1kB  esm/models/mappers.js.map                            

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…ties of a PATCH request body must not be required. PATCH operation: 'LiveEvents_Update' Model Definition: 'TrackedResource' Property: 'location'"
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 21, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 23, 2020
@@ -54,7 +51,7 @@
"provisioningState": "InProgress",
"created": "0001-01-01T00:00:00Z",
"lastModified": "0001-01-01T00:00:00Z",
"vanityUrl": false,
"useStaticHostname": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason to change the property name? This would cause SDK breaking change across versions.

@akning-ms
Copy link
Contributor

Hi @ravbhatnagar, here is case for lint Rule 2016(patchbodyparametersschema) which new added, as @giakas changed ref TrackedResource to common types.json which 'location' is required , so it caused lint R2016 failure in patch operation. looks @giakas can not put discriminator as document guide. Do you have any suggestion for this? currently the Lint failure has been suppressed.
Guide for Rule 2016: https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/openapi-authoring-automated-guidelines.md#r2016

@allenjzhang allenjzhang merged commit e3649e8 into Azure:master Jun 24, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
* Adds base for updating Microsoft.Media from version stable/2018-07-01 to version 2020-05-01

* Updates readme

* Updates API version in new specs and examples

* Updating the some swagger files to new version.

* Update to latest swaggers and fix some examples.

* fix prettier issue

* fix some linter issues

* fix spell check.

* Add a supression for R2016 linter rule, which was failing for "Properties of a PATCH request body must not be required. PATCH operation: 'LiveEvents_Update' Model Definition: 'TrackedResource' Property: 'location'"

* Fix a validation error

* add 204 for the delete account.

* Move ApiError and ODataError to a different file, as autorest v3 is complaining about duplicate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ReadyForSDKReview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants