[Public-Preview] Review request for Microsoft.Migrate to add version … #9883

innosam · 2020-06-18T13:15:37Z

Private-preview PR request: https://github.com/Azure/azure-rest-api-specs-pr/pull/968
Status: ARMSignedOff

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
- adding/removing APIs.
- adding/removing properties.
- adding/removing API-version.
- adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…preview/2019-10-01-preview

openapi-pipeline-app · 2020-06-18T13:15:41Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-06-18T13:15:53Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-06-18T13:16:25Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-06-18T13:17:28Z

azure-sdk-for-go - Release

❌ failed [Logs] [Expand Details]

❌ Generate from d20f294 with merge commit 0085d3c. SDK Automation 13.0.17.20200619.4

[AutoRest] FATAL: System.InvalidOperationException: namespace can only contains lower case letters, numbers and underscore
[AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 58
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: go/generate - FAILED
[AutoRest] FATAL: Error: Plugin go reported failure.
[AutoRest]   Error: Plugin go reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest [email protected]/autorest.go@~2.1.144 --go --verbose --multiapi --use-onever --preview-chk --version=previous --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/regionmove/resource-manager/readme.md FATAL: System.InvalidOperationException: namespace can only contains lower case letters, numbers and underscore
   at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 58
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
  Error: Plugin go reported failure.
, {} 
Failed to find any diff after autorest so no changed packages was found.

openapi-sdkautomation · 2020-06-18T13:17:29Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-18T13:17:30Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-18T13:17:30Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from d20f294 with merge commit 0085d3c. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-06-18T13:17:31Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from d20f294 with merge commit 0085d3c. SDK Automation 13.0.17.20200619.4

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/_region_move_service_api.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/_region_move_service_api_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_move_collection_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_move_collections_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_move_resources_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_operations_discovery_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_unresolved_dependencies_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/version.py

openapi-sdkautomation · 2020-06-18T13:17:31Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-18T13:17:34Z

azure-sdk-for-java - Release

❌ failed [Logs] [Expand Details]

❌ Generate from d20f294 with merge commit 0085d3c. SDK Automation 13.0.17.20200619.4

[AutoRest] FATAL: System.Exception: Duplicate File Generation: src/main/java//implementation/MoveCollectionsImpl.java
[AutoRest]    at AutoRest.Core.CodeGenerator.d__13.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 151
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Core.CodeGenerator.d__12.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 121
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Java.CodeGeneratorJv.d__10.MoveNext() in /home/vsts/work/1/s/src/vanilla/CodeGeneratorJv.cs:line 58
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: java/generate - FAILED
[AutoRest] FATAL: Error: Plugin java reported failure.
[AutoRest]   Error: Plugin java reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=V2 --java --verbose --multiapi [email protected]/autorest.java@preview --azure-libraries-for-java-folder=/z/work/azure-sdk-for-java /z/work/azure-rest-api-specs/specification/regionmove/resource-manager/readme.md FATAL: System.Exception: Duplicate File Generation: src/main/java//implementation/MoveCollectionsImpl.java
   at AutoRest.Core.CodeGenerator.d__13.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 151
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.d__12.MoveNext() in /home/vsts/work/1/s/autorest.common/src/CodeGenerator.cs:line 121
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.CodeGeneratorJv.d__10.MoveNext() in /home/vsts/work/1/s/src/vanilla/CodeGeneratorJv.cs:line 58
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: java/generate - FAILED
FATAL: Error: Plugin java reported failure.
  Error: Plugin java reported failure.
, {} 
Failed to find any diff after autorest so no changed packages was found.

azure-pipelines · 2020-06-26T04:49:40Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-06-26T04:51:19Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-06-26T04:58:23Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-06-26T05:08:00Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-06-26T05:40:34Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-06-26T05:45:08Z

Azure Pipelines successfully started running 1 pipeline(s).

...move/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json

lirenhe · 2020-06-28T02:21:48Z

...move/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json

+    },
+    "MoveState": {
+      "description": "Defines the MoveResource states.",
+      "enum": [


Will you consider using x-ms-enum (https://github.com/Azure/autorest/tree/master/docs/extensions#x-ms-enum) for better code generation?

Sure, i have added this. This is an additional information on the enum and as I have understood does not require any change from service.

lirenhe · 2020-06-28T02:26:43Z

specification/regionmove/resource-manager/readme.md

@@ -0,0 +1,79 @@
+# regionmove


why do you use a separate location for the readme files?

Hey, when we raised this PR earlier for private preview, these files were auto-generated by HUB.
However, what is the location preferred for readme files?

...move/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json

azure-pipelines · 2020-07-09T07:11:09Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-07-09T07:21:01Z

Azure Pipelines successfully started running 1 pipeline(s).

pilor · 2020-07-09T17:22:08Z

...move/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json

+          }
+        ],
+        "responses": {
+          "200": {


this operation is marked as long running but does not have a long running response code

removed it as the operation is not long running, thanks.

pilor · 2020-07-09T17:22:23Z

...move/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json

+          }
+        ],
+        "responses": {
+          "200": {


patch async requires 202

removed the long running from PUT/PATCH of move collection.

pilor · 2020-07-09T17:25:15Z

...move/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json

+          }
+        },
+        "x-ms-pageable": {
+          "nextLinkName": null


you don't control whether there is a nextLink on subscription and RG Level GETs for tracked resources. It must be supported because ARM may return it for you if one of your regional endpoints does not return a response in time or returns a retryable error code

Got it, i have added the "nextLink" in both RG level and subscription level GETs.

azure-pipelines · 2020-07-27T08:04:13Z

Azure Pipelines successfully started running 1 pipeline(s).

[Public-Preview] Review request for Microsoft.Migrate to add version …

260b57a

…preview/2019-10-01-preview

openapi-assignment-bot bot assigned lirenhe Jun 18, 2020

innosam changed the title ~~[Public-Preview] Review request for Microsoft.Migrate to add version …~~ [Public-Preview][Do not merge] Review request for Microsoft.Migrate to add version … Jun 18, 2020

innosam added the Do Not Merge label Jun 18, 2020

innosam changed the title ~~[Public-Preview][Do not merge] Review request for Microsoft.Migrate to add version …~~ [Public-Preview] Review request for Microsoft.Migrate to add version … Jun 18, 2020

innosam force-pushed the hsingh/regionmovepublicpreview branch from b3a19c9 to 5a6db0b Compare June 26, 2020 04:58

innosam force-pushed the hsingh/regionmovepublicpreview branch from 5a6db0b to 2b75111 Compare June 26, 2020 05:07

innosam force-pushed the hsingh/regionmovepublicpreview branch from 2b75111 to 060c79b Compare June 26, 2020 05:40

Fix the swagger lint errors.

5633341

innosam force-pushed the hsingh/regionmovepublicpreview branch from 060c79b to 5633341 Compare June 26, 2020 05:44

lirenhe reviewed Jun 28, 2020

View reviewed changes

...move/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json Show resolved Hide resolved

lirenhe reviewed Jun 28, 2020

View reviewed changes

pilor added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 1, 2020

pilor suggested changes Jul 1, 2020

View reviewed changes

innosam force-pushed the hsingh/regionmovepublicpreview branch from 5c37328 to cb04c75 Compare July 9, 2020 07:20

innosam requested review from pilor and lirenhe July 9, 2020 07:32

pilor suggested changes Jul 9, 2020

View reviewed changes

Taking comments.

d20f294

innosam force-pushed the hsingh/regionmovepublicpreview branch from cb04c75 to d20f294 Compare July 27, 2020 08:03

innosam requested a review from pilor July 27, 2020 08:03

innosam added ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jul 30, 2020

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 3, 2020

pilor approved these changes Aug 3, 2020

View reviewed changes

innosam added DoNotMerge <valid label in PR review process> use to hold merge after approval and removed DoNotMerge <valid label in PR review process> use to hold merge after approval labels Aug 4, 2020

lirenhe approved these changes Aug 5, 2020

View reviewed changes

lirenhe merged commit 0085d3c into Azure:master Aug 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Public-Preview] Review request for Microsoft.Migrate to add version … #9883

[Public-Preview] Review request for Microsoft.Migrate to add version … #9883

innosam commented Jun 18, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jun 18, 2020 •

edited

Loading

azure-pipelines bot commented Jun 18, 2020

azuresdkci commented Jun 18, 2020

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

azure-pipelines bot commented Jun 26, 2020

openapi-sdkautomation bot commented Jun 26, 2020 •

edited

Loading

azure-pipelines bot commented Jun 26, 2020

azure-pipelines bot commented Jun 26, 2020

azure-pipelines bot commented Jun 26, 2020

azure-pipelines bot commented Jun 26, 2020

lirenhe Jun 28, 2020

innosam Jul 9, 2020

lirenhe Jun 28, 2020

innosam Jul 9, 2020

azure-pipelines bot commented Jul 9, 2020

azure-pipelines bot commented Jul 9, 2020

pilor Jul 9, 2020

innosam Jul 27, 2020

pilor Jul 9, 2020

innosam Jul 27, 2020

pilor Jul 9, 2020

innosam Jul 27, 2020 •

edited

Loading

azure-pipelines bot commented Jul 27, 2020

[Public-Preview] Review request for Microsoft.Migrate to add version … #9883

[Public-Preview] Review request for Microsoft.Migrate to add version … #9883

Conversation

innosam commented Jun 18, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

openapi-pipeline-app bot commented Jun 18, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jun 18, 2020

azuresdkci commented Jun 18, 2020

openapi-sdkautomation bot commented Jun 18, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jun 18, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jun 18, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jun 18, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jun 18, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Jun 18, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Jun 18, 2020 • edited Loading

azure-sdk-for-java - Release

azure-pipelines bot commented Jun 26, 2020

openapi-sdkautomation bot commented Jun 26, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

azure-pipelines bot commented Jun 26, 2020

azure-pipelines bot commented Jun 26, 2020

azure-pipelines bot commented Jun 26, 2020

azure-pipelines bot commented Jun 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azure-pipelines bot commented Jul 9, 2020

azure-pipelines bot commented Jul 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

innosam Jul 27, 2020 • edited Loading

Choose a reason for hiding this comment

azure-pipelines bot commented Jul 27, 2020

innosam commented Jun 18, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 26, 2020 •

edited

Loading

innosam Jul 27, 2020 •

edited

Loading