-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing read only property to allow update operations as per the actual implementation #9874
Conversation
…oad operations Correcting the swagger to accept downloadToken similar to other download operations
…pis. IT is already part of the examples. Adding the missing api-version parameter for move and validate move apis. IT is already part of the examples.
Removing reonly property to allow update operations
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
@njuCZ We have just checked in the 2020-05-01 version of swagger couple of weeks back and realized that it has a mistake where we are setting the read only property for some editable fields. |
Can one of the admins verify this patch? |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@njuCZ Do we need ARM review for this change? We do not have even these APIs live yet. |
@asarkar84 yes, we still need ARM team review it |
Removing ARM Feedback label since ARM review board will not be reviewing property level changes going forward. |
@njuCZ This does not required ARM feedback as mentioned by ARM team. Can you please merge this PR. |
@njuCZ Please take a look. |
…ual implementation (Azure#9874) * Correcting the swagger to accept downloadToken similar to other download operations Correcting the swagger to accept downloadToken similar to other download operations * Adding the missing api-version parameter for move and validate move apis. IT is already part of the examples. Adding the missing api-version parameter for move and validate move apis. IT is already part of the examples. * Removing reonly property to allow update operations Removing reonly property to allow update operations Co-authored-by: Anirban Sarkar <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.