Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.IoTCentral to add version stable/2018-09-01 #9845

Conversation

r-delgadillo
Copy link
Contributor

@r-delgadillo r-delgadillo commented Jun 16, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process

This PR adds Sku property for model AppPAtch to allow our users to update the sku information for the application..

@openapi-pipeline-app
Copy link

Swagger pipeline started successfully, please wait for status update in this comment.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 731e0f1 with merge commit b118409. SDK Automation 13.0.17.20200619.4
  • ️✔️azure-mgmt-iotcentral [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-iotcentral
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-iotcentral
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 1.754% size of original (original: 7812 chars, delta: 137 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model AppPatch has a new parameter sku

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 731e0f1 with merge commit b118409. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-iotcentral [View full logs]  [Release SDK Changes]
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/iotCentralClient.js → ./dist/arm-iotcentral.js...
    [npmPack] created ./dist/arm-iotcentral.js in 219ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 15.4kB esm/operations/apps.js               
    [npmPack] npm notice 536B   esm/models/appsMappers.js            
    [npmPack] npm notice 43.5kB dist/arm-iotcentral.js               
    [npmPack] npm notice 13.8kB dist/arm-iotcentral.min.js           
    [npmPack] npm notice 345B   esm/models/index.js                  
    [npmPack] npm notice 405B   esm/operations/index.js              
    [npmPack] npm notice 1.5kB  esm/iotCentralClient.js              
    [npmPack] npm notice 2.5kB  esm/iotCentralClientContext.js       
    [npmPack] npm notice 12.4kB esm/models/mappers.js                
    [npmPack] npm notice 2.2kB  esm/operations/operations.js         
    [npmPack] npm notice 455B   esm/models/operationsMappers.js      
    [npmPack] npm notice 1.6kB  esm/models/parameters.js             
    [npmPack] npm notice 982B   rollup.config.js                     
    [npmPack] npm notice 1.6kB  package.json                         
    [npmPack] npm notice 457B   tsconfig.json                        
    [npmPack] npm notice 4.8kB  esm/operations/apps.d.ts.map         
    [npmPack] npm notice 8.1kB  esm/operations/apps.js.map           
    [npmPack] npm notice 273B   esm/models/appsMappers.d.ts.map      
    [npmPack] npm notice 286B   esm/models/appsMappers.js.map        
    [npmPack] npm notice 93.7kB dist/arm-iotcentral.js.map           
    [npmPack] npm notice 13.8kB dist/arm-iotcentral.min.js.map       
    [npmPack] npm notice 5.9kB  esm/models/index.d.ts.map            
    [npmPack] npm notice 158B   esm/operations/index.d.ts.map        
    [npmPack] npm notice 126B   esm/models/index.js.map              
    [npmPack] npm notice 173B   esm/operations/index.js.map          
    [npmPack] npm notice 642B   esm/iotCentralClient.d.ts.map        
    [npmPack] npm notice 736B   esm/iotCentralClient.js.map          
    [npmPack] npm notice 498B   esm/iotCentralClientContext.d.ts.map 
    [npmPack] npm notice 1.4kB  esm/iotCentralClientContext.js.map   
    [npmPack] npm notice 839B   esm/models/mappers.d.ts.map          
    [npmPack] npm notice 7.2kB  esm/models/mappers.js.map            
    [npmPack] npm notice 1.0kB  esm/operations/operations.d.ts.map   
    [npmPack] npm notice 1.4kB  esm/operations/operations.js.map     
    [npmPack] npm notice 215B   esm/models/operationsMappers.d.ts.map
    [npmPack] npm notice 228B   esm/models/operationsMappers.js.map  
    [npmPack] npm notice 445B   esm/models/parameters.d.ts.map       
    [npmPack] npm notice 1.2kB  esm/models/parameters.js.map         
    [npmPack] npm notice 3.4kB  README.md                            
    [npmPack] npm notice 13.6kB esm/operations/apps.d.ts             
    [npmPack] npm notice 25.4kB src/operations/apps.ts               
    [npmPack] npm notice 226B   esm/models/appsMappers.d.ts          
    [npmPack] npm notice 520B   src/models/appsMappers.ts            
    [npmPack] npm notice 15.1kB esm/models/index.d.ts                
    [npmPack] npm notice 89B    esm/operations/index.d.ts            
    [npmPack] npm notice 14.5kB src/models/index.ts                  
    [npmPack] npm notice 373B   src/operations/index.ts              
    [npmPack] npm notice 955B   esm/iotCentralClient.d.ts            
    [npmPack] npm notice 1.4kB  src/iotCentralClient.ts              
    [npmPack] npm notice 776B   esm/iotCentralClientContext.d.ts     
    [npmPack] npm notice 2.3kB  src/iotCentralClientContext.ts       
    [npmPack] npm notice 972B   esm/models/mappers.d.ts              
    [npmPack] npm notice 9.8kB  src/models/mappers.ts                
    [npmPack] npm notice 2.1kB  esm/operations/operations.d.ts       
    [npmPack] npm notice 4.1kB  src/operations/operations.ts         
    [npmPack] npm notice 145B   esm/models/operationsMappers.d.ts    
    [npmPack] npm notice 419B   src/models/operationsMappers.ts      
    [npmPack] npm notice 481B   esm/models/parameters.d.ts           
    [npmPack] npm notice 1.7kB  src/models/parameters.ts             
    [npmPack] npm notice 1.1kB  LICENSE.txt                          
    [npmPack] npm notice === Tarball Details === 
    [npmPack] npm notice name:          @azure/arm-iotcentral                   
    [npmPack] npm notice version:       3.0.0                                   
    [npmPack] npm notice filename:      azure-arm-iotcentral-3.0.0.tgz          
    [npmPack] npm notice package size:  43.7 kB                                 
    [npmPack] npm notice unpacked size: 340.1 kB                                
    [npmPack] npm notice shasum:        5c4006b7dd38fe8af8f40aa8d9e8e545dbc494b9
    [npmPack] npm notice integrity:     sha512-urifm1lMnk5+f[...]sb0EpXCDMYnvw==
    [npmPack] npm notice total files:   59                                      
    [npmPack] npm notice 

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 16, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

Copy link
Member

@poanchen poanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@r-delgadillo
Copy link
Contributor Author

@qianwens can you take a look at this PR, thanks

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 23, 2020
@qianwens qianwens merged commit b118409 into Azure:master Jun 28, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants