Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remoteBgpCommunities to VirtualNetworkPeering resource #9814

Merged

Conversation

jarango
Copy link
Member

@jarango jarango commented Jun 11, 2020

This pull request adds the remoteBgpCommunities property to the VirtualNetworkPeering resource. The value of this property is populated from the value of the bgpCommunities property of the remote VNET that is being peered to the local VNET.

This is an addition being done for important scalability reasons. ExpressRoute needs to read the BgpCommunities of all the spoke VNETs that are peered with a hub VNET. Performing GET operations on each peered VNET does not scale because the number of peered VNETs can be large.
The efficient way to obtain this information is from the VirtualNetworkPeering child resources of the hub VNET.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 11, 2020

[Staging] Swagger Validation Report

  • ️✔️~[Staging] BreakingChange [Detail]

  • Posted by Swagger Pipeline

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 11, 2020
    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 11, 2020

    azure-sdk-for-go

    ⚠️ warning [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 11, 2020

    Azure CLI Extension Generation

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 11, 2020

    azure-sdk-for-java

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from c880592 with merge commit 9dd4115c293b29bc91461b8aefffa4158fbd233b. SDK Automation 13.0.17.20200605.3
    • ⚠️sdk/network/mgmt-v2019_02_01 [View full logs
      No file is changed.
    • ⚠️sdk/network/mgmt-v2019_04_01 [View full logs
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
        [mvn]   symbol:   method serviceName()
        [mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
        [mvn]   symbol:   method serviceName()
        [mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
        [mvn]   symbol:   method availableResourceGroupPrivateEndpointTypes()
        [mvn]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeModelImpl.java:[37,28] cannot find symbol
        [mvn] [ERROR]   symbol:   method serviceName()
        [mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/LocationAvailablePrivateEndpointTypeImpl.java:[37,28] cannot find symbol
        [mvn] [ERROR]   symbol:   method serviceName()
        [mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.AvailablePrivateEndpointTypeInner
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_04_01/src/main/java/com/microsoft/azure/management/network/v2019_04_01/implementation/AvailableResourceGroupPrivateEndpointTypesImpl.java:[23,30] cannot find symbol
        [mvn] [ERROR]   symbol:   method availableResourceGroupPrivateEndpointTypes()
        [mvn] [ERROR]   location: class com.microsoft.azure.management.network.v2019_04_01.implementation.NetworkManagementClientImpl
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
        No file is changed.
      • ⚠️sdk/network/mgmt-v2019_06_01 [View full logs
        No file is changed.
      • ⚠️sdk/network/mgmt-v2019_07_01 [View full logs
        No file is changed.
      • ⚠️sdk/network/mgmt-v2019_08_01 [View full logs
        No file is changed.
      • ⚠️sdk/network/mgmt-v2019_09_01 [View full logs
          [mvn] [ERROR] COMPILATION ERROR : 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
          [mvn]   symbol:   class ResourceNavigationLinkInner
          [mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
          [mvn]   symbol:   class ServiceAssociationLinkInner
          [mvn]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[108,10] cannot find symbol
          [mvn] [ERROR]   symbol:   class ResourceNavigationLinkInner
          [mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2019_09_01/src/main/java/com/microsoft/azure/management/network/v2019_09_01/Subnet.java:[118,10] cannot find symbol
          [mvn] [ERROR]   symbol:   class ServiceAssociationLinkInner
          [mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2019_09_01.Subnet
          [mvn] [ERROR] -> [Help 1]
          [mvn] [ERROR] 
          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [mvn] [ERROR] 
          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
          No file is changed.
        • ⚠️sdk/network/mgmt-v2020_03_01 [View full logs
            [mvn] [ERROR] COMPILATION ERROR : 
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2020_03_01/src/main/java/com/microsoft/azure/management/network/v2020_03_01/Subnet.java:[113,10] cannot find symbol
            [mvn]   symbol:   class ResourceNavigationLinkInner
            [mvn]   location: interface com.microsoft.azure.management.network.v2020_03_01.Subnet
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2020_03_01/src/main/java/com/microsoft/azure/management/network/v2020_03_01/Subnet.java:[123,10] cannot find symbol
            [mvn]   symbol:   class ServiceAssociationLinkInner
            [mvn]   location: interface com.microsoft.azure.management.network.v2020_03_01.Subnet
            [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2020_03_01/src/main/java/com/microsoft/azure/management/network/v2020_03_01/Subnet.java:[113,10] cannot find symbol
            [mvn] [ERROR]   symbol:   class ResourceNavigationLinkInner
            [mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2020_03_01.Subnet
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2020_03_01/src/main/java/com/microsoft/azure/management/network/v2020_03_01/Subnet.java:[123,10] cannot find symbol
            [mvn] [ERROR]   symbol:   class ServiceAssociationLinkInner
            [mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2020_03_01.Subnet
            [mvn] [ERROR] -> [Help 1]
            [mvn] [ERROR] 
            [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
            [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
            [mvn] [ERROR] 
            [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
            [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
            No file is changed.
          • ⚠️sdk/network/mgmt-v2020_04_01 [View full logs
              [mvn] [ERROR] COMPILATION ERROR : 
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2020_04_01/src/main/java/com/microsoft/azure/management/network/v2020_04_01/Subnet.java:[113,10] cannot find symbol
              [mvn]   symbol:   class ResourceNavigationLinkInner
              [mvn]   location: interface com.microsoft.azure.management.network.v2020_04_01.Subnet
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2020_04_01/src/main/java/com/microsoft/azure/management/network/v2020_04_01/Subnet.java:[123,10] cannot find symbol
              [mvn]   symbol:   class ServiceAssociationLinkInner
              [mvn]   location: interface com.microsoft.azure.management.network.v2020_04_01.Subnet
              [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-network: Compilation failure: Compilation failure: 
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2020_04_01/src/main/java/com/microsoft/azure/management/network/v2020_04_01/Subnet.java:[113,10] cannot find symbol
              [mvn] [ERROR]   symbol:   class ResourceNavigationLinkInner
              [mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2020_04_01.Subnet
              [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/network/mgmt-v2020_04_01/src/main/java/com/microsoft/azure/management/network/v2020_04_01/Subnet.java:[123,10] cannot find symbol
              [mvn] [ERROR]   symbol:   class ServiceAssociationLinkInner
              [mvn] [ERROR]   location: interface com.microsoft.azure.management.network.v2020_04_01.Subnet
              [mvn] [ERROR] -> [Help 1]
              [mvn] [ERROR] 
              [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
              [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
              [mvn] [ERROR] 
              [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
              [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
              No file is changed.

            @openapi-sdkautomation
            Copy link

            openapi-sdkautomation bot commented Jun 11, 2020

            azure-sdk-for-js

            ️✔️ succeeded [Logs] [Expand Details]
            • ️✔️ Generate from c880592 with merge commit 9dd4115c293b29bc91461b8aefffa4158fbd233b. SDK Automation 13.0.17.20200605.3
            • ️✔️@azure/arm-network [View full logs]  [Preview SDK Changes]
              Only show 100 items here, please refer to log for details.
              [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
              [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
              [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
              [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
              [npmPack] loaded rollup.config.js with warnings
              [npmPack] (!) Unused external imports
              [npmPack] default imported from external module 'rollup' but never used
              [npmPack] 
              [npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js...
              [npmPack] created ./dist/arm-network.js in 2.6s
              [npmPack] npm notice 
              [npmPack] npm notice package: @azure/[email protected]
              [npmPack] npm notice === Tarball Contents === 
              [npmPack] npm notice 9.7kB   esm/operations/applicationGatewayPrivateEndpointConnections.js            
              [npmPack] npm notice 7.9kB   esm/models/applicationGatewayPrivateEndpointConnectionsMappers.js         
              [npmPack] npm notice 3.0kB   esm/operations/applicationGatewayPrivateLinkResources.js                  
              [npmPack] npm notice 7.8kB   esm/models/applicationGatewayPrivateLinkResourcesMappers.js               
              [npmPack] npm notice 27.0kB  esm/operations/applicationGateways.js                                     
              [npmPack] npm notice 8.2kB   esm/models/applicationGatewaysMappers.js                                  
              [npmPack] npm notice 11.2kB  esm/operations/applicationSecurityGroups.js                               
              [npmPack] npm notice 7.8kB   esm/models/applicationSecurityGroupsMappers.js                            
              [npmPack] npm notice 3.4MB   dist/arm-network.js                                                       
              [npmPack] npm notice 1.4MB   dist/arm-network.min.js                                                   
              [npmPack] npm notice 2.6kB   esm/operations/availableDelegations.js                                    
              [npmPack] npm notice 480B    esm/models/availableDelegationsMappers.js                                 
              [npmPack] npm notice 2.6kB   esm/operations/availableEndpointServices.js                               
              [npmPack] npm notice 7.8kB   esm/models/availableEndpointServicesMappers.js                            
              [npmPack] npm notice 4.5kB   esm/operations/availablePrivateEndpointTypes.js                           
              [npmPack] npm notice 507B    esm/models/availablePrivateEndpointTypesMappers.js                        
              [npmPack] npm notice 2.8kB   esm/operations/availableResourceGroupDelegations.js                       
              [npmPack] npm notice 493B    esm/models/availableResourceGroupDelegationsMappers.js                    
              [npmPack] npm notice 4.4kB   esm/operations/availableServiceAliases.js                                 
              [npmPack] npm notice 488B    esm/models/availableServiceAliasesMappers.js                              
              [npmPack] npm notice 2.5kB   esm/operations/azureFirewallFqdnTags.js                                   
              [npmPack] npm notice 7.8kB   esm/models/azureFirewallFqdnTagsMappers.js                                
              [npmPack] npm notice 11.5kB  esm/operations/azureFirewalls.js                                          
              [npmPack] npm notice 7.8kB   esm/models/azureFirewallsMappers.js                                       
              [npmPack] npm notice 9.2kB   esm/operations/bastionHosts.js                                            
              [npmPack] npm notice 7.8kB   esm/models/bastionHostsMappers.js                                         
              [npmPack] npm notice 2.5kB   esm/operations/bgpServiceCommunities.js                                   
              [npmPack] npm notice 7.8kB   esm/models/bgpServiceCommunitiesMappers.js                                
              [npmPack] npm notice 16.6kB  esm/operations/connectionMonitors.js                                      
              [npmPack] npm notice 7.9kB   esm/models/connectionMonitorsMappers.js                                   
              [npmPack] npm notice 7.5kB   esm/operations/ddosCustomPolicies.js                                      
              [npmPack] npm notice 7.8kB   esm/models/ddosCustomPoliciesMappers.js                                   
              [npmPack] npm notice 10.8kB  esm/operations/ddosProtectionPlans.js                                     
              [npmPack] npm notice 7.8kB   esm/models/ddosProtectionPlansMappers.js                                  
              [npmPack] npm notice 4.0kB   esm/operations/defaultSecurityRules.js                                    
              [npmPack] npm notice 7.8kB   esm/models/defaultSecurityRulesMappers.js                                 
              [npmPack] npm notice 9.2kB   esm/operations/expressRouteCircuitAuthorizations.js                       
              [npmPack] npm notice 7.8kB   esm/models/expressRouteCircuitAuthorizationsMappers.js                    
              [npmPack] npm notice 10.1kB  esm/operations/expressRouteCircuitConnections.js                          
              [npmPack] npm notice 7.8kB   esm/models/expressRouteCircuitConnectionsMappers.js                       
              [npmPack] npm notice 8.9kB   esm/operations/expressRouteCircuitPeerings.js                             
              [npmPack] npm notice 7.8kB   esm/models/expressRouteCircuitPeeringsMappers.js                          
              [npmPack] npm notice 20.2kB  esm/operations/expressRouteCircuits.js                                    
              [npmPack] npm notice 8.0kB   esm/models/expressRouteCircuitsMappers.js                                 
              [npmPack] npm notice 8.6kB   esm/operations/expressRouteConnections.js                                 
              [npmPack] npm notice 7.8kB   esm/models/expressRouteConnectionsMappers.js                              
              [npmPack] npm notice 9.3kB   esm/operations/expressRouteCrossConnectionPeerings.js                     
              [npmPack] npm notice 7.8kB   esm/models/expressRouteCrossConnectionPeeringsMappers.js                  
              [npmPack] npm notice 17.1kB  esm/operations/expressRouteCrossConnections.js                            
              [npmPack] npm notice 8.1kB   esm/models/expressRouteCrossConnectionsMappers.js                         
              [npmPack] npm notice 8.7kB   esm/operations/expressRouteGateways.js                                    
              [npmPack] npm notice 7.8kB   esm/models/expressRouteGatewaysMappers.js                                 
              [npmPack] npm notice 3.8kB   esm/operations/expressRouteLinks.js                                       
              [npmPack] npm notice 7.8kB   esm/models/expressRouteLinksMappers.js                                    
              [npmPack] npm notice 10.8kB  esm/operations/expressRoutePorts.js                                       
              [npmPack] npm notice 3.4kB   esm/operations/expressRoutePortsLocations.js                              
              [npmPack] npm notice 7.8kB   esm/models/expressRoutePortsLocationsMappers.js                           
              [npmPack] npm notice 7.8kB   esm/models/expressRoutePortsMappers.js                                    
              [npmPack] npm notice 2.6kB   esm/operations/expressRouteServiceProviders.js                            
              [npmPack] npm notice 7.8kB   esm/models/expressRouteServiceProvidersMappers.js                         
              [npmPack] npm notice 9.3kB   esm/operations/firewallPolicies.js                                        
              [npmPack] npm notice 7.8kB   esm/models/firewallPoliciesMappers.js                                     
              [npmPack] npm notice 9.5kB   esm/operations/firewallPolicyRuleCollectionGroups.js                      
              [npmPack] npm notice 7.8kB   esm/models/firewallPolicyRuleCollectionGroupsMappers.js                   
              [npmPack] npm notice 8.4kB   esm/operations/flowLogs.js                                                
              [npmPack] npm notice 7.8kB   esm/models/flowLogsMappers.js                                             
              [npmPack] npm notice 8.6kB   esm/operations/hubRouteTables.js                                          
              [npmPack] npm notice 7.8kB   esm/models/hubRouteTablesMappers.js                                       
              [npmPack] npm notice 9.3kB   esm/operations/hubVirtualNetworkConnections.js                            
              [npmPack] npm notice 7.8kB   esm/models/hubVirtualNetworkConnectionsMappers.js                         
              [npmPack] npm notice 8.9kB   esm/operations/inboundNatRules.js                                         
              [npmPack] npm notice 7.8kB   esm/models/inboundNatRulesMappers.js                                      
              [npmPack] npm notice 345B    esm/models/index.js                                                       
              [npmPack] npm notice 4.5kB   esm/operations/index.js                                                   
              [npmPack] npm notice 10.5kB  esm/operations/ipAllocations.js                                           
              [npmPack] npm notice 7.8kB   esm/models/ipAllocationsMappers.js                                        
              [npmPack] npm notice 10.2kB  esm/operations/ipGroups.js                                                
              [npmPack] npm notice 7.8kB   esm/models/ipGroupsMappers.js                                             
              [npmPack] npm notice 9.2kB   esm/operations/loadBalancerBackendAddressPools.js                         
              [npmPack] npm notice 7.8kB   esm/models/loadBalancerBackendAddressPoolsMappers.js                      
              [npmPack] npm notice 4.2kB   esm/operations/loadBalancerFrontendIPConfigurations.js                    
              [npmPack] npm notice 7.8kB   esm/models/loadBalancerFrontendIPConfigurationsMappers.js                 
              [npmPack] npm notice 4.0kB   esm/operations/loadBalancerLoadBalancingRules.js                          
              [npmPack] npm notice 7.8kB   esm/models/loadBalancerLoadBalancingRulesMappers.js                       
              [npmPack] npm notice 2.8kB   esm/operations/loadBalancerNetworkInterfaces.js                           
              [npmPack] npm notice 7.8kB   esm/models/loadBalancerNetworkInterfacesMappers.js                        
              [npmPack] npm notice 3.9kB   esm/operations/loadBalancerOutboundRules.js                               

            @openapi-sdkautomation
            Copy link

            openapi-sdkautomation bot commented Jun 11, 2020

            azure-sdk-for-net

            ️✔️ succeeded [Logs] [Expand Details]

            @openapi-sdkautomation
            Copy link

            openapi-sdkautomation bot commented Jun 11, 2020

            azure-sdk-for-python

            ️✔️ succeeded [Logs] [Expand Details]
            • ️✔️ Generate from c880592 with merge commit 9dd4115c293b29bc91461b8aefffa4158fbd233b. SDK Automation 13.0.17.20200605.3
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2016-12-01', '2016-09-01'} in label v2016_12_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2016-12-01 based on label v2016_12_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-03-01'} in label v2017_03_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2017-03-01 based on label v2017_03_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-06-01', '2017-03-30'} in label v2017_06_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2017-06-01 based on label v2017_06_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-08-01'} in label v2017_08_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2017-08-01 based on label v2017_08_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-09-01'} in label v2017_09_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2017-09-01 based on label v2017_09_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-10-01'} in label v2017_10_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2017-10-01 based on label v2017_10_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-11-01'} in label v2017_11_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2017-11-01 based on label v2017_11_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-01-01', '2017-03-30'} in label v2018_01_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2018-01-01 based on label v2018_01_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-02-01'} in label v2018_02_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01 based on label v2018_02_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-04-01', '2017-03-30'} in label v2018_04_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2018-04-01 based on label v2018_04_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-06-01'} in label v2018_06_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2018-06-01 based on label v2018_06_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-07-01', '2017-03-30'} in label v2018_07_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-08-01'} in label v2018_08_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2018-08-01 based on label v2018_08_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2017-03-30'} in label v2018_10_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2018-10-01 based on label v2018_10_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-11-01'} in label v2018_11_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2018-11-01 based on label v2018_11_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-12-01'} in label v2018_12_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2018-12-01 based on label v2018_12_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2019-02-01'} in label v2019_02_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2019-02-01 based on label v2019_02_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2019-04-01'} in label v2019_04_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01', '2017-03-30'} in label v2019_06_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01 based on label v2019_06_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-07-01', '2018-10-01'} in label v2019_07_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2019-07-01 based on label v2019_07_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-08-01'} in label v2019_08_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2019-08-01 based on label v2019_08_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-09-01'} in label v2019_09_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2019-09-01 based on label v2019_09_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-11-01'} in label v2019_11_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2019-11-01 based on label v2019_11_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-12-01'} in label v2019_12_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2019-12-01 based on label v2019_12_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2020-03-01', '2018-10-01'} in label v2020_03_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2020-03-01 based on label v2020_03_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2020-04-01'} in label v2020_04_01
              [azure-mgmt-network][after_scripts|python] WARNING:__main__:Guessing you want 2020-04-01 based on label v2020_04_01
            • ️✔️azure-mgmt-network [View full logs]  [Preview SDK Changes]
              [build_conf] INFO:packaging_tools:Building template azure-mgmt-network
              [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
              [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
              [build_conf] INFO:packaging_tools:Template done azure-mgmt-network
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2016-12-01', '2016-09-01'} in label v2016_12_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2016-12-01 based on label v2016_12_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-03-01'} in label v2017_03_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2017-03-01 based on label v2017_03_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-06-01', '2017-03-30'} in label v2017_06_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2017-06-01 based on label v2017_06_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-08-01'} in label v2017_08_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2017-08-01 based on label v2017_08_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-09-01'} in label v2017_09_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2017-09-01 based on label v2017_09_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-10-01'} in label v2017_10_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2017-10-01 based on label v2017_10_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2017-11-01'} in label v2017_11_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2017-11-01 based on label v2017_11_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-01-01', '2017-03-30'} in label v2018_01_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2018-01-01 based on label v2018_01_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-02-01'} in label v2018_02_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01 based on label v2018_02_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-04-01', '2017-03-30'} in label v2018_04_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2018-04-01 based on label v2018_04_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-06-01'} in label v2018_06_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2018-06-01 based on label v2018_06_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-07-01', '2017-03-30'} in label v2018_07_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-08-01'} in label v2018_08_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2018-08-01 based on label v2018_08_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2017-03-30'} in label v2018_10_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2018-10-01 based on label v2018_10_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-11-01'} in label v2018_11_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2018-11-01 based on label v2018_11_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2018-12-01'} in label v2018_12_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2018-12-01 based on label v2018_12_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2019-02-01'} in label v2019_02_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2019-02-01 based on label v2019_02_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-03-30', '2019-04-01'} in label v2019_04_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01', '2017-03-30'} in label v2019_06_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01 based on label v2019_06_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2019-07-01', '2018-10-01'} in label v2019_07_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2019-07-01 based on label v2019_07_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-08-01'} in label v2019_08_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2019-08-01 based on label v2019_08_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-09-01'} in label v2019_09_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2019-09-01 based on label v2019_09_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-11-01'} in label v2019_11_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2019-11-01 based on label v2019_11_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2019-12-01'} in label v2019_12_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2019-12-01 based on label v2019_12_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2020-03-01', '2018-10-01'} in label v2020_03_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2020-03-01 based on label v2020_03_01
              [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-10-01', '2020-04-01'} in label v2020_04_01
              [after_scripts|python] WARNING:__main__:Guessing you want 2020-04-01 based on label v2020_04_01
              [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
              [build_package]   warnings.warn(msg)
              [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
              [build_package]   warnings.warn(msg)
              [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
              [ChangeLog] Size of delta 0.060% size of original (original: 481387 chars, delta: 287 chars)
              [ChangeLog] 

            @openapi-sdkautomation
            Copy link

            openapi-sdkautomation bot commented Jun 11, 2020

            azure-sdk-for-python-track2

            ️✔️ succeeded [Logs] [Expand Details]
            • ️✔️ Generate from c880592 with merge commit 9dd4115c293b29bc91461b8aefffa4158fbd233b. SDK Automation 13.0.17.20200605.3
            • ️✔️azure-mgmt-network [View full logs]  [Preview SDK Changes]
              [build_conf] INFO:packaging_tools:Building template azure-mgmt-network
              [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
              [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
              [build_conf] INFO:packaging_tools:Template done azure-mgmt-network
              [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
              [build_package]   warnings.warn(msg)
              [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
              [build_package]   warnings.warn(msg)

            @openapi-sdkautomation
            Copy link

            openapi-sdkautomation bot commented Jun 11, 2020

            Trenton Generation

            No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

            @lirenhe
            Copy link
            Member

            lirenhe commented Jun 12, 2020

            @jarango, could you check why NetworkValidation failed?

            @anton-evseev
            Copy link
            Contributor

            @lirenhe please ignore it. Previous release cycle introduced breaking changes and powershel repo's master branch hasn't been updated yet to address that

            @jarango
            Copy link
            Member Author

            jarango commented Jun 15, 2020

            Thank you Anton for the review

            …Communities.json to a value that is within the allowed range.
            @azure-pipelines
            Copy link

            Azure Pipelines successfully started running 1 pipeline(s).

            @ravbhatnagar
            Copy link
            Contributor

            Removing ARM Feedback label since ARM review board will not be reviewing property level changes going forward.

            @anton-evseev
            Copy link
            Contributor

            In this case, @lirenhe please merge

            @jarango
            Copy link
            Member Author

            jarango commented Jun 25, 2020

            @lirenhe could you please merge

            @lirenhe lirenhe merged commit c96cf26 into Azure:network-june-release Jun 28, 2020
            akning-ms pushed a commit that referenced this pull request Aug 12, 2020
            * Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2020-06-01
            
            * Updates readme
            
            * Updates API version in new specs and examples
            
            * New vWAN resource properties (#9722)
            
            * retarget
            
            * fixed duplicate
            
            * Added code changes for generating letter of authorization (#9829)
            
            Co-authored-by: Umesh Kanodia <[email protected]>
            
            * Async PATCH operations for Virtual WAN VpnGateways and P2SVpnGateways (#9833)
            
            * Add remoteBgpCommunities to VirtualNetworkPeering resource (#9814)
            
            * Add remoteBgpCommunities to VirtualNetworkPeering resource
            
            * Change VirtualNetworkCommunity in example VirtualNetworkCreateWithBgpCommunities.json to a value that is within the allowed range.
            
            * Application Gateway Mutual Authentication Support (#9965)
            
            * Adding mutual auth api definitions.
            
            * Adding examples.
            
            * Fixing case.
            
            Co-authored-by: Hemant Imudianda <[email protected]>
            
            * Added PATCH flowLog API and example (#9960)
            
            * Added PATCH flowLog API and example
            
            * Fixed example
            
            * Added property to TCPConfiguration
            
            * Fixed prettier warning
            
            * Fixes based on CR
            
            * Add new optional param enableInternetSecurity and new Reset API for P2SVpnGateway resource (#9952)
            
            * Add new optional param enableInternetSecurity and new Reset API for P2SVpnGateway resource
            
            * Fix validation tool fixes
            
            * Remove extra spaces
            
            * Update Network's owners (#10006)
            
            * Add intrusion system configuration (#9912)
            
            * Add intrusion system configuration
            
            * Add ignored traffic configuration
            
            * Fix checkPirvateLinkServiceVisibility in 2020-06-01 (#9821)
            
            * fix checkPirvateLinkServiceVisibility in 2020-06-01
            
            * update examples
            
            * add VpnGatewaypacketCapture api  (#9832)
            
            * add VpnGatewaypacketCapture api
            
            * add custom words
            
            * add vpn connection packet capture
            
            * fix naming errors
            
            * fix error
            
            * fix word
            
            * fixing validation
            
            * fix model error
            
            * finish prettier
            
            * fix test
            
            * expressRouteProviderPort changes (#9909)
            
            * expressRouteProviderPort changes
            
            * fix ref error
            
            * suppressing name id type error
            
            * prettier fix
            
            * locationlist -> listbylocation
            
            * adding filter on location
            
            * ref listbylocation
            
            * fixing id and name
            
            * adding get and bug fixes
            
            * bug fix
            
            * bug fix
            
            * adding proxy resource ref
            
            * fixes for auto checks
            
            * adding proxyresource type to network.json
            
            * fixing description
            
            * fixing description for proxy resource
            
            * Adding swagger updates to support the new NRP resource "DSCP Configuration" (#9954)
            
            * Adding the swagger for the new resource DSCP Configuration. Also updated the Network Interface to return it with its get function
            
            * Updated the definition to the updated version in the source code
            
            * Fix some errors being thrown by the validator (regarding int/ushort typing). Updated the readme.md to include the dscpConfiguration file
            
            * Fixed the erroneous reference within the dscpConfiguration.json to the NetworkInterface definition
            
            * Removed the long running operation flag.
            Updated the examples to return two markings
            
            * Added more objets within the lists.
            
            * Removed the duplicated key
            
            * The type 'ushort ' is not accepted. Turn it into an integer. Hopefully this fixes the issue regarding the QosPortRange properties
            
            * Added the custome words dscp and qos in order to fix the error of the words being unkown. Refactor the allocatedNetworkInterfaces to associatedNetworkInterfaces to match the examples with the specification. Removed the QosTrafficProfiler from the examples as it no longer exists. Made sure the delete is using dscpName rather than nicName. Added the period at the end of the description.
            
            * One traffic profiler slipped through the cracks, removed it. Properly formatted the object for the Qos Port/IP ranges. Was placing a string rather than an integer in the get example.
            
            * Well, I was being silly here. Had a typo hahahahaha
            
            * Added the warning suppression to the readme file. Run the prettier on the specification
            
            * Thought I only had to run the prettier on the specification. Did the same for the examples and the NetworkInterfaceGet.json.
            
            * Re-run the command with the full command placed in the documentation. Hopefully this fixes the prettier errors
            
            * Corrected the typo
            
            * Added the proper formatting for the suppression.
            
            * Added the integer format
            
            * Added the api calls for list and list all.
            Made sure the name is plural
            Added the examples for the new api calls
            In Network Interface, now it is using the ID of the DSCP configuration rather than the full payload
            
            * Forgot to switch the operation id from network interface to dscp configuration
            
            * Added the missing next link for the list by resource
            
            Co-authored-by: David Velasco <[email protected]>
            Co-authored-by: MyronFanQiu <[email protected]>
            
            * Dev/dexiang/byoip (#9818)
            
            * Adds base for updating Microsoft.Network from version stable/2020-04-01 to version 2020-05-01
            
            * Updates readme
            
            * Updates API version in new specs and examples
            
            * Add VirtualHubBgpConnections, VirtualHubIpConfigurations, NetworkVirtualApplianceSites child resources (#9357)
            
            * Adds base for updating Microsoft.Network from version stable/2020-03-01 to version 2020-05-01
            
            * Updates readme
            
            * Updates API version in new specs and examples
            
            * Final changes
            
            * Fix formatting issues
            
            * Fix merge and formatting issues
            
            * Fix formatiing
            
            * Ipconfig properties
            
            * Fix build errors
            
            * Lint check
            
            * Fix semantics errors
            
            * Address review comments
            
            * Fix prettier and nextLink checks
            
            * Fix dots
            
            * Address errors
            
            * Fix Ipconfig version
            
            Co-authored-by: dexiang-ms <[email protected]>
            
            * Change NRP repo for validation scripts (#9394)
            
            * Move terminateTLS flag to ApplicationRuleCondition (#9539)
            
            * DNS Proxy support for Firewall Policy (#9461)
            
            * Adding DnsProxySettings Support in Firewall Policy
            
            dnsServers, dnsEnableProxy, dnsRequireProxyForNetworkRules are added as subproperties.
            
            * spell check
            
            * Removing DNS as prefix on sub properties.
            
            * Syntax error.
            
            * DnsProxySettings to DNSSettings
            
            * Fixing proxy settings name.
            
            Co-authored-by: Ishani Gupta <[email protected]>
            
            * fix network (#9369) (#9547)
            
            * fix network
            
            * duplicated publicipprefix
            
            * fixed example in 2018-01-01
            
            * final updates
            
            * missing examples
            
            (cherry picked from commit 42d9639)
            
            * Added new properties to ConnectivityHop (#9386)
            
            * Added new properties to ConnectivityHop
            
            * Fixed spelling
            
            * added x-ms-client-flatten to HopLink.properties.properties
            
            * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup (#9356)
            
            * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup
            
            * rebase with ti whitelist
            
            * rebase with ti whitelist
            
            * rebase with ti whitelist
            
            * prettier run
            
            * making nat rule into a collection
            
            * prettier run
            
            * Multiple Public IPs support for Azure Firewall in Virtual Hub (#9560)
            
            * multi pip for firewall in hub swagger change
            
            * resolving issues
            
            * VirtualWan: Hubvnet Connection related changes (#9536)
            
            1. Exposed direct PUT/DELETE APIs for hubvnet connections. This is the
               API expected to be used in the future by all consumers (direct rest
               api calls, powershell, portal, azure cli). This avoids needing a put
               on the virtual hub every time a hubvnet connection is to be
               added/changed.
            2. Deprecate specifying hubvnet connection in virtualHub PUT. This is to
               avoid having multiple APIs to do the same thing. Also having this API
               introduces other complexities and breaks some scenarios.
            3. Deprecate allowHubToRemoteVnetTransit and
               allowRemoteVnetToUseHubVnetGateways flags in hubvnet connection.
               These flags are maintained internally in the implementation and
               shouldn't be exposed to the user. For now, just mark it as such. Will
               be removed in later release.
            
            Co-authored-by: Shyam Dharmarajan <[email protected]>
            
            * Destination FQDNs in FirewallPolicy for network rules. (#9609)
            
            * v1
            
            * making boolean as nullable
            
            Co-authored-by: Ishani Gupta <[email protected]>
            
            * VirtualHub : Add Routing State and expose Effective Routes Api (#9385)
            
            * Add Routing State and expose Effective Routes Api
            
            * updated opId name and added examples
            
            * prettier fix done
            
            * rename variable to prevent conflict
            
            * Updating VpnGateway examples for bgpSettings (#9656)
            
            * Updating VpnGateway examples
            
            * prettier
            
            Co-authored-by: Khushboo Baheti <[email protected]>
            
            * Application Gateway Private Link Support (#9490)
            
            * Application Gateway Private Link Support
            
            * Fix comments
            
            * Fix comments for including example
            
            * add byoip resources and examples
            
            * add resources to readme and update version
            
            * fix path
            
            * fix validation errors and remove roaExpirationDate
            
            * remove swagger files to change name
            
            * add the changed file names back
            
            * remove to change name
            
            * re-add changed name
            
            * remove to change name
            
            * re-add changed name
            
            * remove swagger files to change name
            
            * re-add changed name
            
            * fix merge conflicts
            
            * more merge conflicts
            
            * move to june 2020 api version
            
            * add default response to operations
            
            * fix tab/space discrepancy
            
            * fix path names and remove the public ip address version property from mastercustomipprefix
            
            * fix camelCase in paths
            
            * add acronyms to custom words
            
            * fix another camelcase offender
            
            * validation check fixes
            
            * fix some more model validation issues
            
            * fix json formatting
            
            * remove invalid property
            
            * set readonly on etag, fix paths in examples
            
            * fix enum error
            
            * fix network validation errors
            
            * more naming naming convention changes
            
            * change mastercustomipprefix reference from string to subresource
            
            * fix spelling error
            
            * added patch api to tags update
            
            * minor fix
            
            * prettier check
            
            * minor change to force pipeline again
            
            * minor description updates
            
            * remove geography property in masterCustomIpPrefix
            
            * add customIpPrefix property to publicIpPrefix
            
            Co-authored-by: Anton Evseev <[email protected]>
            Co-authored-by: naveenchekuri <[email protected]>
            Co-authored-by: Anton Evseev <[email protected]>
            Co-authored-by: odedlaz <[email protected]>
            Co-authored-by: Ishani Gupta <[email protected]>
            Co-authored-by: Ishani Gupta <[email protected]>
            Co-authored-by: Zim Kalinowski <[email protected]>
            Co-authored-by: irrogozh <[email protected]>
            Co-authored-by: Sai Sujith Reddy Mankala <[email protected]>
            Co-authored-by: Anchal Kapoor <[email protected]>
            Co-authored-by: shyamshd <[email protected]>
            Co-authored-by: Shyam Dharmarajan <[email protected]>
            Co-authored-by: Ritvika Reddy Nagula <[email protected]>
            Co-authored-by: Khushboo Baheti <[email protected]>
            Co-authored-by: Khushboo Baheti <[email protected]>
            Co-authored-by: jaishals <[email protected]>
            
            * fix the description (#10151)
            
            * Add support for addressprefix in NVA and enableVirtualRouterRouteProp… (#10153)
            
            * Added O365Policy to VpnSite resource. (#10192)
            
            Co-authored-by: Neel Bhavsar <[email protected]>
            
            * Added new properties to connection monitor endpoint (#10197)
            
            * Added new properties to connection monitor endpoint
            
            * Updated description of endpointScopeItem
            
            * MACsec Configuration Edits (#10181)
            
            * Add xpn aes cipher values & rm dashes
            
            * Add sci mode param to macsec
            
            * remove readonly attribute from customIpPrefix commissionedState property (#10246)
            
            * fixing ids in examples (#10221)
            
            * Merge branch 'network-june-release' of https://github.com/adgrieve/azure-rest-api-specs into network-june-release (#10069)
            
            * Network june release revert - reverting changes which are not deployed from NRP side yet.  (#10325)
            
            * reverting providerport changes
            
            * fixing bug
            
            * Remove masterCustomIpPrefix resource from Network-June-Release (does not affect current master branch) (#10338)
            
            * remove masterCustomIpPrefix resource
            
            * delete the MasterCustomIpPrefix swagger examples
            
            Co-authored-by: Anton Evseev <[email protected]>
            Co-authored-by: Henry Chen <[email protected]>
            Co-authored-by: Umesh Kanodia <[email protected]>
            Co-authored-by: Umesh Kanodia <[email protected]>
            Co-authored-by: ritwikbasu <[email protected]>
            Co-authored-by: Jesus Arango <[email protected]>
            Co-authored-by: Hemant Imudianda <[email protected]>
            Co-authored-by: Hemant Imudianda <[email protected]>
            Co-authored-by: irrogozh <[email protected]>
            Co-authored-by: Nilambari <[email protected]>
            Co-authored-by: Anton Evseev <[email protected]>
            Co-authored-by: adgrieve <[email protected]>
            Co-authored-by: Kaihui (Kerwin) Sun <[email protected]>
            Co-authored-by: tyrannicrex <[email protected]>
            Co-authored-by: dagoutha <[email protected]>
            Co-authored-by: David Velasco <[email protected]>
            Co-authored-by: David Velasco <[email protected]>
            Co-authored-by: MyronFanQiu <[email protected]>
            Co-authored-by: dexiang-ms <[email protected]>
            Co-authored-by: naveenchekuri <[email protected]>
            Co-authored-by: odedlaz <[email protected]>
            Co-authored-by: Ishani Gupta <[email protected]>
            Co-authored-by: Ishani Gupta <[email protected]>
            Co-authored-by: Zim Kalinowski <[email protected]>
            Co-authored-by: Sai Sujith Reddy Mankala <[email protected]>
            Co-authored-by: Anchal Kapoor <[email protected]>
            Co-authored-by: shyamshd <[email protected]>
            Co-authored-by: Shyam Dharmarajan <[email protected]>
            Co-authored-by: Ritvika Reddy Nagula <[email protected]>
            Co-authored-by: Khushboo Baheti <[email protected]>
            Co-authored-by: Khushboo Baheti <[email protected]>
            Co-authored-by: jaishals <[email protected]>
            Co-authored-by: Anchal Kapoor <[email protected]>
            Co-authored-by: Neel <[email protected]>
            Co-authored-by: Neel Bhavsar <[email protected]>
            Co-authored-by: francescanarea <[email protected]>
            innosam pushed a commit to innosam/azure-rest-api-specs that referenced this pull request Aug 17, 2020
            * Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2020-06-01
            
            * Updates readme
            
            * Updates API version in new specs and examples
            
            * New vWAN resource properties (Azure#9722)
            
            * retarget
            
            * fixed duplicate
            
            * Added code changes for generating letter of authorization (Azure#9829)
            
            Co-authored-by: Umesh Kanodia <[email protected]>
            
            * Async PATCH operations for Virtual WAN VpnGateways and P2SVpnGateways (Azure#9833)
            
            * Add remoteBgpCommunities to VirtualNetworkPeering resource (Azure#9814)
            
            * Add remoteBgpCommunities to VirtualNetworkPeering resource
            
            * Change VirtualNetworkCommunity in example VirtualNetworkCreateWithBgpCommunities.json to a value that is within the allowed range.
            
            * Application Gateway Mutual Authentication Support (Azure#9965)
            
            * Adding mutual auth api definitions.
            
            * Adding examples.
            
            * Fixing case.
            
            Co-authored-by: Hemant Imudianda <[email protected]>
            
            * Added PATCH flowLog API and example (Azure#9960)
            
            * Added PATCH flowLog API and example
            
            * Fixed example
            
            * Added property to TCPConfiguration
            
            * Fixed prettier warning
            
            * Fixes based on CR
            
            * Add new optional param enableInternetSecurity and new Reset API for P2SVpnGateway resource (Azure#9952)
            
            * Add new optional param enableInternetSecurity and new Reset API for P2SVpnGateway resource
            
            * Fix validation tool fixes
            
            * Remove extra spaces
            
            * Update Network's owners (Azure#10006)
            
            * Add intrusion system configuration (Azure#9912)
            
            * Add intrusion system configuration
            
            * Add ignored traffic configuration
            
            * Fix checkPirvateLinkServiceVisibility in 2020-06-01 (Azure#9821)
            
            * fix checkPirvateLinkServiceVisibility in 2020-06-01
            
            * update examples
            
            * add VpnGatewaypacketCapture api  (Azure#9832)
            
            * add VpnGatewaypacketCapture api
            
            * add custom words
            
            * add vpn connection packet capture
            
            * fix naming errors
            
            * fix error
            
            * fix word
            
            * fixing validation
            
            * fix model error
            
            * finish prettier
            
            * fix test
            
            * expressRouteProviderPort changes (Azure#9909)
            
            * expressRouteProviderPort changes
            
            * fix ref error
            
            * suppressing name id type error
            
            * prettier fix
            
            * locationlist -> listbylocation
            
            * adding filter on location
            
            * ref listbylocation
            
            * fixing id and name
            
            * adding get and bug fixes
            
            * bug fix
            
            * bug fix
            
            * adding proxy resource ref
            
            * fixes for auto checks
            
            * adding proxyresource type to network.json
            
            * fixing description
            
            * fixing description for proxy resource
            
            * Adding swagger updates to support the new NRP resource "DSCP Configuration" (Azure#9954)
            
            * Adding the swagger for the new resource DSCP Configuration. Also updated the Network Interface to return it with its get function
            
            * Updated the definition to the updated version in the source code
            
            * Fix some errors being thrown by the validator (regarding int/ushort typing). Updated the readme.md to include the dscpConfiguration file
            
            * Fixed the erroneous reference within the dscpConfiguration.json to the NetworkInterface definition
            
            * Removed the long running operation flag.
            Updated the examples to return two markings
            
            * Added more objets within the lists.
            
            * Removed the duplicated key
            
            * The type 'ushort ' is not accepted. Turn it into an integer. Hopefully this fixes the issue regarding the QosPortRange properties
            
            * Added the custome words dscp and qos in order to fix the error of the words being unkown. Refactor the allocatedNetworkInterfaces to associatedNetworkInterfaces to match the examples with the specification. Removed the QosTrafficProfiler from the examples as it no longer exists. Made sure the delete is using dscpName rather than nicName. Added the period at the end of the description.
            
            * One traffic profiler slipped through the cracks, removed it. Properly formatted the object for the Qos Port/IP ranges. Was placing a string rather than an integer in the get example.
            
            * Well, I was being silly here. Had a typo hahahahaha
            
            * Added the warning suppression to the readme file. Run the prettier on the specification
            
            * Thought I only had to run the prettier on the specification. Did the same for the examples and the NetworkInterfaceGet.json.
            
            * Re-run the command with the full command placed in the documentation. Hopefully this fixes the prettier errors
            
            * Corrected the typo
            
            * Added the proper formatting for the suppression.
            
            * Added the integer format
            
            * Added the api calls for list and list all.
            Made sure the name is plural
            Added the examples for the new api calls
            In Network Interface, now it is using the ID of the DSCP configuration rather than the full payload
            
            * Forgot to switch the operation id from network interface to dscp configuration
            
            * Added the missing next link for the list by resource
            
            Co-authored-by: David Velasco <[email protected]>
            Co-authored-by: MyronFanQiu <[email protected]>
            
            * Dev/dexiang/byoip (Azure#9818)
            
            * Adds base for updating Microsoft.Network from version stable/2020-04-01 to version 2020-05-01
            
            * Updates readme
            
            * Updates API version in new specs and examples
            
            * Add VirtualHubBgpConnections, VirtualHubIpConfigurations, NetworkVirtualApplianceSites child resources (Azure#9357)
            
            * Adds base for updating Microsoft.Network from version stable/2020-03-01 to version 2020-05-01
            
            * Updates readme
            
            * Updates API version in new specs and examples
            
            * Final changes
            
            * Fix formatting issues
            
            * Fix merge and formatting issues
            
            * Fix formatiing
            
            * Ipconfig properties
            
            * Fix build errors
            
            * Lint check
            
            * Fix semantics errors
            
            * Address review comments
            
            * Fix prettier and nextLink checks
            
            * Fix dots
            
            * Address errors
            
            * Fix Ipconfig version
            
            Co-authored-by: dexiang-ms <[email protected]>
            
            * Change NRP repo for validation scripts (Azure#9394)
            
            * Move terminateTLS flag to ApplicationRuleCondition (Azure#9539)
            
            * DNS Proxy support for Firewall Policy (Azure#9461)
            
            * Adding DnsProxySettings Support in Firewall Policy
            
            dnsServers, dnsEnableProxy, dnsRequireProxyForNetworkRules are added as subproperties.
            
            * spell check
            
            * Removing DNS as prefix on sub properties.
            
            * Syntax error.
            
            * DnsProxySettings to DNSSettings
            
            * Fixing proxy settings name.
            
            Co-authored-by: Ishani Gupta <[email protected]>
            
            * fix network (Azure#9369) (Azure#9547)
            
            * fix network
            
            * duplicated publicipprefix
            
            * fixed example in 2018-01-01
            
            * final updates
            
            * missing examples
            
            (cherry picked from commit 42d9639)
            
            * Added new properties to ConnectivityHop (Azure#9386)
            
            * Added new properties to ConnectivityHop
            
            * Fixed spelling
            
            * added x-ms-client-flatten to HopLink.properties.properties
            
            * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup (Azure#9356)
            
            * Rename Firewall Policy child resource RuleGroup to RuleCollectionGroup
            
            * rebase with ti whitelist
            
            * rebase with ti whitelist
            
            * rebase with ti whitelist
            
            * prettier run
            
            * making nat rule into a collection
            
            * prettier run
            
            * Multiple Public IPs support for Azure Firewall in Virtual Hub (Azure#9560)
            
            * multi pip for firewall in hub swagger change
            
            * resolving issues
            
            * VirtualWan: Hubvnet Connection related changes (Azure#9536)
            
            1. Exposed direct PUT/DELETE APIs for hubvnet connections. This is the
               API expected to be used in the future by all consumers (direct rest
               api calls, powershell, portal, azure cli). This avoids needing a put
               on the virtual hub every time a hubvnet connection is to be
               added/changed.
            2. Deprecate specifying hubvnet connection in virtualHub PUT. This is to
               avoid having multiple APIs to do the same thing. Also having this API
               introduces other complexities and breaks some scenarios.
            3. Deprecate allowHubToRemoteVnetTransit and
               allowRemoteVnetToUseHubVnetGateways flags in hubvnet connection.
               These flags are maintained internally in the implementation and
               shouldn't be exposed to the user. For now, just mark it as such. Will
               be removed in later release.
            
            Co-authored-by: Shyam Dharmarajan <[email protected]>
            
            * Destination FQDNs in FirewallPolicy for network rules. (Azure#9609)
            
            * v1
            
            * making boolean as nullable
            
            Co-authored-by: Ishani Gupta <[email protected]>
            
            * VirtualHub : Add Routing State and expose Effective Routes Api (Azure#9385)
            
            * Add Routing State and expose Effective Routes Api
            
            * updated opId name and added examples
            
            * prettier fix done
            
            * rename variable to prevent conflict
            
            * Updating VpnGateway examples for bgpSettings (Azure#9656)
            
            * Updating VpnGateway examples
            
            * prettier
            
            Co-authored-by: Khushboo Baheti <[email protected]>
            
            * Application Gateway Private Link Support (Azure#9490)
            
            * Application Gateway Private Link Support
            
            * Fix comments
            
            * Fix comments for including example
            
            * add byoip resources and examples
            
            * add resources to readme and update version
            
            * fix path
            
            * fix validation errors and remove roaExpirationDate
            
            * remove swagger files to change name
            
            * add the changed file names back
            
            * remove to change name
            
            * re-add changed name
            
            * remove to change name
            
            * re-add changed name
            
            * remove swagger files to change name
            
            * re-add changed name
            
            * fix merge conflicts
            
            * more merge conflicts
            
            * move to june 2020 api version
            
            * add default response to operations
            
            * fix tab/space discrepancy
            
            * fix path names and remove the public ip address version property from mastercustomipprefix
            
            * fix camelCase in paths
            
            * add acronyms to custom words
            
            * fix another camelcase offender
            
            * validation check fixes
            
            * fix some more model validation issues
            
            * fix json formatting
            
            * remove invalid property
            
            * set readonly on etag, fix paths in examples
            
            * fix enum error
            
            * fix network validation errors
            
            * more naming naming convention changes
            
            * change mastercustomipprefix reference from string to subresource
            
            * fix spelling error
            
            * added patch api to tags update
            
            * minor fix
            
            * prettier check
            
            * minor change to force pipeline again
            
            * minor description updates
            
            * remove geography property in masterCustomIpPrefix
            
            * add customIpPrefix property to publicIpPrefix
            
            Co-authored-by: Anton Evseev <[email protected]>
            Co-authored-by: naveenchekuri <[email protected]>
            Co-authored-by: Anton Evseev <[email protected]>
            Co-authored-by: odedlaz <[email protected]>
            Co-authored-by: Ishani Gupta <[email protected]>
            Co-authored-by: Ishani Gupta <[email protected]>
            Co-authored-by: Zim Kalinowski <[email protected]>
            Co-authored-by: irrogozh <[email protected]>
            Co-authored-by: Sai Sujith Reddy Mankala <[email protected]>
            Co-authored-by: Anchal Kapoor <[email protected]>
            Co-authored-by: shyamshd <[email protected]>
            Co-authored-by: Shyam Dharmarajan <[email protected]>
            Co-authored-by: Ritvika Reddy Nagula <[email protected]>
            Co-authored-by: Khushboo Baheti <[email protected]>
            Co-authored-by: Khushboo Baheti <[email protected]>
            Co-authored-by: jaishals <[email protected]>
            
            * fix the description (Azure#10151)
            
            * Add support for addressprefix in NVA and enableVirtualRouterRouteProp… (Azure#10153)
            
            * Added O365Policy to VpnSite resource. (Azure#10192)
            
            Co-authored-by: Neel Bhavsar <[email protected]>
            
            * Added new properties to connection monitor endpoint (Azure#10197)
            
            * Added new properties to connection monitor endpoint
            
            * Updated description of endpointScopeItem
            
            * MACsec Configuration Edits (Azure#10181)
            
            * Add xpn aes cipher values & rm dashes
            
            * Add sci mode param to macsec
            
            * remove readonly attribute from customIpPrefix commissionedState property (Azure#10246)
            
            * fixing ids in examples (Azure#10221)
            
            * Merge branch 'network-june-release' of https://github.com/adgrieve/azure-rest-api-specs into network-june-release (Azure#10069)
            
            * Network june release revert - reverting changes which are not deployed from NRP side yet.  (Azure#10325)
            
            * reverting providerport changes
            
            * fixing bug
            
            * Remove masterCustomIpPrefix resource from Network-June-Release (does not affect current master branch) (Azure#10338)
            
            * remove masterCustomIpPrefix resource
            
            * delete the MasterCustomIpPrefix swagger examples
            
            Co-authored-by: Anton Evseev <[email protected]>
            Co-authored-by: Henry Chen <[email protected]>
            Co-authored-by: Umesh Kanodia <[email protected]>
            Co-authored-by: Umesh Kanodia <[email protected]>
            Co-authored-by: ritwikbasu <[email protected]>
            Co-authored-by: Jesus Arango <[email protected]>
            Co-authored-by: Hemant Imudianda <[email protected]>
            Co-authored-by: Hemant Imudianda <[email protected]>
            Co-authored-by: irrogozh <[email protected]>
            Co-authored-by: Nilambari <[email protected]>
            Co-authored-by: Anton Evseev <[email protected]>
            Co-authored-by: adgrieve <[email protected]>
            Co-authored-by: Kaihui (Kerwin) Sun <[email protected]>
            Co-authored-by: tyrannicrex <[email protected]>
            Co-authored-by: dagoutha <[email protected]>
            Co-authored-by: David Velasco <[email protected]>
            Co-authored-by: David Velasco <[email protected]>
            Co-authored-by: MyronFanQiu <[email protected]>
            Co-authored-by: dexiang-ms <[email protected]>
            Co-authored-by: naveenchekuri <[email protected]>
            Co-authored-by: odedlaz <[email protected]>
            Co-authored-by: Ishani Gupta <[email protected]>
            Co-authored-by: Ishani Gupta <[email protected]>
            Co-authored-by: Zim Kalinowski <[email protected]>
            Co-authored-by: Sai Sujith Reddy Mankala <[email protected]>
            Co-authored-by: Anchal Kapoor <[email protected]>
            Co-authored-by: shyamshd <[email protected]>
            Co-authored-by: Shyam Dharmarajan <[email protected]>
            Co-authored-by: Ritvika Reddy Nagula <[email protected]>
            Co-authored-by: Khushboo Baheti <[email protected]>
            Co-authored-by: Khushboo Baheti <[email protected]>
            Co-authored-by: jaishals <[email protected]>
            Co-authored-by: Anchal Kapoor <[email protected]>
            Co-authored-by: Neel <[email protected]>
            Co-authored-by: Neel Bhavsar <[email protected]>
            Co-authored-by: francescanarea <[email protected]>
            Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
            Labels
            None yet
            Projects
            None yet
            Development

            Successfully merging this pull request may close these issues.

            5 participants