Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**WaitForARMFeedback** add enableNodePublicIp to AMLCompute #9725

Conversation

comacgin
Copy link
Contributor

@comacgin comacgin commented Jun 4, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • [x ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ArcturusZhang ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 5, 2020
Copy link
Contributor

@chiragg4u chiragg4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@chiragg4u chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 20, 2020
@ArcturusZhang ArcturusZhang merged commit e44a02a into Azure:dev-machinelearningservices-Microsoft.MachineLearningServices-2020-05-15-preview Jun 22, 2020
ArcturusZhang pushed a commit that referenced this pull request Jul 22, 2020
…ervices 2020 05 15 preview (#10133)

* integrate 05-01 into 05-15

* Updates readme

* Adding osType and vmImage parameters (#9519)

* update (#9713) (#9723)

Co-authored-by: Yingying Song <[email protected]>

Co-authored-by: syy0129 <[email protected]>
Co-authored-by: Yingying Song <[email protected]>

* add enableNodePublicIp to AMLCompute (#9725)

* Adding estimatedVMPrices to AML ListVMSzies (#9972)

Co-authored-by: Sriram Kakara <[email protected]>

* Changing description for nodeIdleTimeBeforeScaleDown

* Integrating delete changes

Co-authored-by: syy0129 <[email protected]>
Co-authored-by: Yingying Song <[email protected]>
Co-authored-by: comacgin <[email protected]>
Co-authored-by: sriramkakara <[email protected]>
Co-authored-by: Sriram Kakara <[email protected]>
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
…ervices 2020 05 15 preview (Azure#10133)

* integrate 05-01 into 05-15

* Updates readme

* Adding osType and vmImage parameters (Azure#9519)

* update (Azure#9713) (Azure#9723)

Co-authored-by: Yingying Song <[email protected]>

Co-authored-by: syy0129 <[email protected]>
Co-authored-by: Yingying Song <[email protected]>

* add enableNodePublicIp to AMLCompute (Azure#9725)

* Adding estimatedVMPrices to AML ListVMSzies (Azure#9972)

Co-authored-by: Sriram Kakara <[email protected]>

* Changing description for nodeIdleTimeBeforeScaleDown

* Integrating delete changes

Co-authored-by: syy0129 <[email protected]>
Co-authored-by: Yingying Song <[email protected]>
Co-authored-by: comacgin <[email protected]>
Co-authored-by: sriramkakara <[email protected]>
Co-authored-by: Sriram Kakara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants